Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <21568052-eb0f-a8d6-5225-3b422e9470e9@intel.com>
Date:   Thu, 8 Jun 2023 14:01:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v3 10/21] KVM:x86: Add #CP support in guest exception
 classification
Content-Language: en-US
To:     Chao Gao <chao.gao@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <rppt@kernel.org>, <binbin.wu@linux.intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>
References: <20230511040857.6094-1-weijiang.yang@intel.com>
 <20230511040857.6094-11-weijiang.yang@intel.com>
 <ZH73kDx6VCaBFiyh@chao-email>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZH73kDx6VCaBFiyh@chao-email>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?elRUMW4xKythdThUVVFMTUlIdmJlbTNHcTUzY29rRmY5VHRpMEdJQmk3L1A1?=
 =?utf-8?B?Y2ZHcmVZY0hTdUZmNzJXcXBTdm4zOEsxandqUldCSFNlR2VyQVRnR2NYcE5V?=
 =?utf-8?B?aWxrS1IrQkxpVGYvekI5WFFaRVluTGt4a1dBMHFTZDBsR1VLRWZ0WGRPcHNZ?=
 =?utf-8?B?NlNwN0dhSXpMTnZGYWFaTDJoZWdnK0NRNEdmdWhOMDNXbkVER292a2I1VWJa?=
 =?utf-8?B?R250a1Zhc2VZbHB6eDB0c3oyanNUUzg1WFkxT3NBQ3lhdnl1R01VL2NLUDMz?=
 =?utf-8?B?OTRxV0ZaUXdLazh6cUR6Qy8vZ1BBRE5HY2k4NjRxZ09iLzFEdENNSXlRWVpt?=
 =?utf-8?B?MzlhMjJFYUdWV0UvNlRvZ3UvM0NBVE1lcytnblhSMzhRcStOc0JsQnptbkl5?=
 =?utf-8?B?Rzl6MzVld0JkeFlLWENFdHBpTUpHYUVNREJMSkk1R0xsb3lXUmZiekxoTzlp?=
 =?utf-8?B?TGJQL09tMWdLZnBBcnNqRkoxS2xYNWNNV3IzYnBsbnhkZ2U0UEVtdU1Bb1JL?=
 =?utf-8?B?Um92dDd0dmhBR2xpc1M4OEtYelhWb1JXZzcyMGhqcVQrb0Y1d2l2ZDdYbExl?=
 =?utf-8?B?WnIzK1crbjNBczVvYWRtamFzWkxoQkNJcUYraTVuYjlHTi9Wb0RWWVFtTEtT?=
 =?utf-8?B?VHErYk1KekxQZjB0TGFyK1FVZk0zazh0N3EwUmZVOWUyVWNRL2ovc1hheUZl?=
 =?utf-8?B?ZFk0dTlrOGRCWjlnNUozODlyUjA4ajFKbE5ueEhRd0YwT05kTWZGUXZNUEo0?=
 =?utf-8?B?ejBUcUlWMnFPVG1hVi8xY3o4TE1pTm4rbFdwUmtncDg0aktvby9sK0FvbEt6?=
 =?utf-8?B?eFh6RXFnSXd2WVlBUmY5b0w5S3hZSHJwME5sOGxrTHB6WlpjMnJ2cDZCbm9E?=
 =?utf-8?B?YmtDdUFYZ0dWZjl3L3d1aWRTK0tZMW5CRVZ1Nll5dHpOZnhUc2NLekFoc0NM?=
 =?utf-8?B?YVlHVyswVzJ4YmNHWkdUSSt6cHRsSmY2Z0M2NFFoVFZmNlViTkdrRHRnWWNK?=
 =?utf-8?B?UTJsV1RsM3BNNmhGR3pGd0NJekg0T01hNFhpVXVlZHFRT3pKaWNWakIxelpD?=
 =?utf-8?B?Uk14Zm1GVmd1UHQ1aGxHUC9uKzFCcDNDVThYUkZvUmVqUkpwbWNaSlVwcXBv?=
 =?utf-8?B?R25RelRmdFYvY2hTMDdDR1dRTGtid1lZb3BNRUsvVHVveDdrNnJVTlJNZk9s?=
 =?utf-8?B?UnVrS2hnTEZkWTJhcWZ0TkdBTWVzMkd0MjZwY3haQ0FFMk9VdExxTHNIdmdD?=
 =?utf-8?B?cnZ5c0ZKcHFTeUl1L0FzeTZ2U1NJWEo4WTJjYmNBUzZyMExHYmN6QzFQdzBT?=
 =?utf-8?B?R0VUZVUvZ1doTjlldWpTcVZRazVZQnBHdGtHOGtBTjN3T3cxTWZvNVkyNXVa?=
 =?utf-8?B?bGIrQjZ6S3BEYUp3eDJCYVZiNWxrNXBWUUVLS1g0TGdTV0h4MGVCRklOZHJS?=
 =?utf-8?B?Wkc5eCsyTGhBK1dDdVk3UXMzMCsvQmlFRGM5eXBlTGdRVUkrQUtsWHpWUGxD?=
 =?utf-8?B?R0JuTzFlSndDa3Bvc3pCODJVc0pPOVBtOHg1ZDlCSEZlK2I3V0xGWEZQZWYx?=
 =?utf-8?B?eHdVQjlaaGlKTUNjelpudmdaeHJ6RUNvU3dVcFY1QUxHTjFmUXY5T1NZSElK?=
 =?utf-8?B?RXdHV0NuVHBocnpseVdsR3BYS1ZuM29vSFBFNHdEREtzUVMyZGg2cUthZnJZ?=
 =?utf-8?B?dTBFWkhKcVlWMUNySm1oTnlmc2FKRzJ0N004L25mRzRqK2tFU1JBSXhvL29U?=
 =?utf-8?B?NXdoVjY4Y0VNRmxLRzhwemMwUWpsNUVaZThRd1BWUnNsdE16WStWb25MTEhK?=
 =?utf-8?B?bFRpV3FVVmw5VCtFQ0NiRkk3MEFLVG1CYUJlRWhheHdldHhhTkZVQUZSY1hr?=
 =?utf-8?B?YlRtNjR5dm00MVRVYWlncjI3VFhyK2w4dTZ0enYzNzBPMi9vUUx2TFJ3Zy85?=
 =?utf-8?B?NEZudktKZXdtUlBpckVobFNpcVdleHV0V2pUSDlld3BMZStoaUtaUWNCa29q?=
 =?utf-8?B?bzFRaXAzWHhSSmxKT2dJRndiTEtIUHl6MWx6Vlh5UVF6aUJXaHRXU3o5Z2Uv?=
 =?utf-8?B?ZG1IcWdPYkJVT3k0R0QxZWVRdENtTkhlMWlPV1hIUE5jdG14Rnp3U0F0ZEFo?=
 =?utf-8?B?WnJ1SW5hU3F3aXZVWFBPV1dvRUt0S3NybmZBempwVlh2cGFXWlJJZmRGL2xG?=
 =?utf-8?B?UEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 69dfb2a1-2b63-4017-52fc-08db67e5dcdb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 06:01:55.6681
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vg9Fz0BHSPmKPSPumQGPXlpGltzHwE8EhQQTm8DCk3fKe8PDiQvQo26PRHotWmt3biV10m8a5q6LvqLVnp+pOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6074
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/6/2023 5:08 PM, Chao Gao wrote:
> On Thu, May 11, 2023 at 12:08:46AM -0400, Yang Weijiang wrote:
>> Add handling for Control Protection (#CP) exceptions(vector 21).
>> The new vector is introduced for Intel's Control-Flow Enforcement
>> Technology (CET) relevant violation cases.
>>
>> Although #CP belongs contributory exception class, but the actual
>> effect is conditional on CET being exposed to guest. If CET is not
>> available to guest, #CP falls back to non-contributory and doesn't
>> have an error code.
> This sounds weird. is this the hardware behavior? If yes, could you
> point us to where this behavior is documented?

It's not SDM documented behavior.

The original description is provided by Sean here:

Re: [PATCH v15 04/14] KVM: x86: Add #CP support in guest exception 
dispatch - Sean Christopherson (kernel.org) 
<https://lore.kernel.org/all/YBsZwvwhshw+s7yQ@google.com/>

I also verified the issue on my side.  If the KVM CET patches are there 
in L1 but CET is not enabled, and running some unit test can

trigger unit test failure although the #CP induced one has been fixed in 
KVM unit tests.