Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0f5e95d-d221-8852-72db-cc70cd807754@intel.com>
Date:   Thu, 8 Jun 2023 13:42:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v3 08/21] KVM:x86: Init kvm_caps.supported_xss with
 supported feature bits
To:     Chao Gao <chao.gao@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <rppt@kernel.org>, <binbin.wu@linux.intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>
References: <20230511040857.6094-1-weijiang.yang@intel.com>
 <20230511040857.6094-9-weijiang.yang@intel.com> <ZH7wc4NX66HNqMl9@chao-email>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZH7wc4NX66HNqMl9@chao-email>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkNRQnFUYWFENUJPMFFTMHBKZUhaU3RscmZjdTF6a25HUE10czhDQVBZdU5H?=
 =?utf-8?B?Wk82Tzl1VXNaNUh3b2NmaTdNSGdBc0kxa3hoUlo0T1RBTk5mcVM4amZ5a1Iv?=
 =?utf-8?B?WWNjVU5yY3d1VUJ3WTRnM0V4ZHh1QSt2WVN2bGVqcHFyMXlvN0pQWGZpcHF3?=
 =?utf-8?B?NEorR0pRdkR2N2MwZFBhWS8zM0ZyVWNIN0FEMnE4RmM3MXFFYzAvbUhqYk52?=
 =?utf-8?B?R3d6RERoL20zV0VFVDUwQXAvVmdjU1BXajdlZHNGV0dKS25OamJWKzl6OVE0?=
 =?utf-8?B?UHp4YXNjOHNSMU1DM2pGMTNmRzlTY3RFNWRlRUJWeFZpYUYyc2pjcW03ZENJ?=
 =?utf-8?B?VHJlUHdZSEErMnV1eEVVNTJUbWlaL0MrbmRLQ05nRkVHaUVnQmhQSXcxdjJE?=
 =?utf-8?B?dm91dzNUdzRGOVNnRGxGOGVXU2dyUE14TnBTODcreWcrUmFROWR5WWpEc3pD?=
 =?utf-8?B?cklpTVJIK05Gd1I4ZlNja3BOUE5xN1huOE1vb2RrNUtRK0M4QkQwb3RhVHg5?=
 =?utf-8?B?YkwxcDEvZlZ5VFJTN2h6Z0tNRjU5c3dPRHVuZWorLzNhbE1GdDBjWUJrZ2RD?=
 =?utf-8?B?YWdaczl3S25LMi9CMFRRVGg0citvRll0Vy9reWtzb2lteFUvcGFXZENPdDhT?=
 =?utf-8?B?L0FON1ZKaGJEaFBtS3ZKTzdaYlB5aC9oTDhFdVZXWEVQR1cxclFPcnUzRGcy?=
 =?utf-8?B?T2poWWp0ZDJsTitEaGs3RTUzbVcwaUcvNk5YUE9aT05ZSCtVdkx5cHFldngy?=
 =?utf-8?B?bE1ZdVAzOHdub29NSUhXYnpjcWZVbVdpbGYwTFJjT1BEU1NsbXYrVldFTDlD?=
 =?utf-8?B?OFpBbXVkWGZ5T3RSMTVFTS9sYndsS0NnemZGS1hJZVZCa21mZHg5clVNVFlk?=
 =?utf-8?B?OEV4ZXh3TGYwVzZTZ0RYaVVGSTFOV3dia3BFbGtCbFdKN25wOTY4WVdzYnFE?=
 =?utf-8?B?VFpJNUdNdEVlWWFkRTJRV0ZpWHdMb2xzdFNIclAwQnJqWHViaUI0cjAvaHBk?=
 =?utf-8?B?VHArWnZLWUZXK1JPU0J2NjdmOTlGODBYT09RN1hXUGYzNE5YdzN4RkNQQ0dN?=
 =?utf-8?B?alVhTDJCaEpJOVM5NmNzNERtRy9nelJ5WFlJcWZ4bWpSNUtPcXFPRGI4RW9F?=
 =?utf-8?B?V2FGcGwxZjJRMTdjNFF3VHA4aXJzSW5BN0M1QVJGWUZYaUt3cUVwT0xtRnVs?=
 =?utf-8?B?VUZyM1hnY3FCYllyd0I1VHNuUm91QkJwQVBWWjNJUzVnazVGRklVQ0duL0xm?=
 =?utf-8?B?QkxXUTIwR2NidXNwMFZlL2RCbDk1eG5XcFdxdVhhWnRSSGRXSlpLcldEVmdo?=
 =?utf-8?B?MVFaakpVV0xPc2Q2Vk80czdGVTI4KzlYV3hmQlo1V282eDZEWVZIVXNHQkFo?=
 =?utf-8?B?aFIxMXN3QTRnMldOVU8xT3VxczhEeWhRdEZUM0xQY2dNaU1KMXBNT1ErdTZ2?=
 =?utf-8?B?ZEJsVzNVdnNuaS9CNXJJUDJqWVVGS3FrTldHRSs5MStsUCtRbGZUU05qZUNG?=
 =?utf-8?B?WUlOcWpIU1UzdHVKWno0NmwrUzZER296aThJdzZpdnBUOG5RNlZOc1Q2aWoz?=
 =?utf-8?B?TDdZejIxRERnM3FGYk14YUdtY00xaHg4bnByVkllUUhGTHcvUkxPU0NXd1JD?=
 =?utf-8?B?QjJlU09TQUtrWlRQNVNKV2I0TTlZN0x6QTNkOERQYmltQUlXVHdXWUlQYmpL?=
 =?utf-8?B?Rlg1S0Y3YmYzRGx5QWpWZmlaVlM5NXpITHozdGk5NWdYdnN2dmdZVFBjVnBx?=
 =?utf-8?B?bEg0RkxnZUtZL0lLZGoxcjFZcmpNYWxYUXhkcEF3WitKVUdJUlBkcHN5QThl?=
 =?utf-8?B?TDVsandGYUJvSDUyV0l1ZXEwS3NXWVdRcXh3SXpHRElxdXJlMC9kYnBEUEl6?=
 =?utf-8?B?QlhuQTNyTkRKS1JXS1ptTGZnUmxOQ2x5MzVISXNXRFJURDk3MWJnbTR1R3l3?=
 =?utf-8?B?aTBNcGlzOGV3bmhOd1FWNkd5SlZQL1dOZDRRUU4rWGc2WXEvWUZoa1YwZXJi?=
 =?utf-8?B?UXU3cG9TMW1Fa2ZVcDRscWkwbFMvYXBzRkJuZXNxVzJGdllxbVBoT01tdWY5?=
 =?utf-8?B?ZHJHenZXQTJucEF4MDBBalhHbTFtUHV6WVZqLzVYZlBCRXk4NGlMcFpEL3NR?=
 =?utf-8?B?azAvQVl6NmFHdXpwZnBlNTdDTDlIWHdKZzM5L1BIWG9KUGNzVm1wam5JTmlL?=
 =?utf-8?B?Z2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b7d741ad-9fce-4f77-2537-08db67e33c1c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 05:43:07.1330
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W1uF9A+UfOHEIMn8ntoPlLNFzIBuwUK5QlfKUJNW1iEKxrmJXRxMZC+rZ85kx7DYR6K1inOpH2+EUvmHiTj8/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5285
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/6/2023 4:38 PM, Chao Gao wrote:
> On Thu, May 11, 2023 at 12:08:44AM -0400, Yang Weijiang wrote:
>> Initialize kvm_caps.supported_xss with host XSS msr value AND XSS mask.
>> KVM_SUPPORTED_XSS holds all potential supported feature bits,
>> the result
>> represents all KVM supported feature bits which is used for swapping guest
>> and host FPU contents.
> do you mean kvm_caps.supported_xss by "the result"? I don't see how
> fpu_swap_kvm_fpstate() uses kvm_caps.supported_xss.

The wording is not accurate, what I meant is : the resulting bits are 
supported by

fpu_swap_kvm_fpstate(). I will change the commit logs in next version, thanks!

>
>> Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>> ---
>> arch/x86/kvm/vmx/vmx.c | 1 -
>> arch/x86/kvm/x86.c     | 6 +++++-
>> 2 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>> index 44fb619803b8..c872a5aafa50 100644
>> --- a/arch/x86/kvm/vmx/vmx.c
>> +++ b/arch/x86/kvm/vmx/vmx.c
>> @@ -7806,7 +7806,6 @@ static __init void vmx_set_cpu_caps(void)
>> 		kvm_cpu_cap_set(X86_FEATURE_UMIP);
>>
>> 	/* CPUID 0xD.1 */
>> -	kvm_caps.supported_xss = 0;
> AMD has the same statement. Do you need to remove that one?

Since it appears in svm.c, so I assume Allen(AMD) will change it

in his following up patch series.

[...]