Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 23:42:14 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 03/26] cxl: Rename member @dport of struct cxl_dport
 to @dev
Message-ID: <64817846759c9_e067a294f5@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-4-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-4-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uuj4WqfUfiWAQnM7aNjLfWxE4gh8A2BliuKGoUhu7fHI60uNVZVdVcEDHyOP?=
 =?us-ascii?Q?Ke/nzjgF96eVeCwM+ghNlsmCgY1xcDS5jOuR6ZiplCWXU88Am34kXk9jmsW4?=
 =?us-ascii?Q?cmDToE09eYOocx1oOjysMmMIP9Ns+OyWAZAQK6Dhpdxnirf3wAAj+7pQKnjq?=
 =?us-ascii?Q?W/BGi4ewF+b35F5vem7fGHBLBxReJaV0mQHDKjcUsWFHW9igtHLLaiKti3e8?=
 =?us-ascii?Q?EgaJlUyPbwxZphDHp2DwdjhYPEP8WVWIGNvKjWbysFLjp9yO/l6Tmode9S3s?=
 =?us-ascii?Q?4rY49UUtHZ9PNfsNQPgosQPCw7CXuyvFxjkRt7/fHBvTaOjNXjJG6wBnyKlD?=
 =?us-ascii?Q?gFA1kkPYWst/v8/BjswRl/jVSpvFy3EI59yabKrdWRmNuGAle/CJiZpSQDxP?=
 =?us-ascii?Q?hyGyEfgVJe/w/u2D8BQwiTYjyzN3BuBvCQgNgfR4gLH8tEzxM0f3p0Y3GGoK?=
 =?us-ascii?Q?zz+pubfA70KwPNKrZwpZ96zB4A0M9hVeKHYjcWWtr5QTQPIxCM10OI1Y2j98?=
 =?us-ascii?Q?9yTJmXNCeWgK85lbqsWZrL22NxT0wacpRW36Mwrq3wtbbyW1XRei2featrSR?=
 =?us-ascii?Q?8ocpqcIZBdC8pzFowJVWX6TdOH4sBAppbuszURmIZgYPYmZXsXxucR0c7tL1?=
 =?us-ascii?Q?XM9WvuywGF0DSb17JCIZNl1mMvV6CWPSCZm4mWrXJJwnR3UqvO16UzZcC/Av?=
 =?us-ascii?Q?ynHmN00bz8kEt0mZtMcLyrdkPXOxtJIJaRtoS+fIW0wi4y6/1fQgKoUB1Sjo?=
 =?us-ascii?Q?ooxjy/gjPCpBaEoJCJzIYMUI5mQC2a1h3B0HjM2HMrFN/ksC6s6HWmWVvmdo?=
 =?us-ascii?Q?DZy0UOfkUkPMU69Ak+nD5YNq9xZilUh5QePwgiOmBXVDgn09sC7HmyihDeKn?=
 =?us-ascii?Q?pGBj+IK3Pf/YXHHO7Az/Vn7c3rvKSh9lx7rjP4VmAxqQAtMj2vAWudN3HBef?=
 =?us-ascii?Q?WL7/mVYQ04cgWBa+zCivfMEKr234KOdwA5+TNlBocOi3P7QO/AXy/Xn60NmR?=
 =?us-ascii?Q?ehpaJXttkLs8orqLJIPf7c+i4rLhJicpsQEitH50APJ0+Gb+tY5d+F6m2pcY?=
 =?us-ascii?Q?13P2IIc6hdZ9sh7eL6C7zlJ3d1gVKVd/gdvv/TZSY1VxRrJuhnBkM7QwAuHP?=
 =?us-ascii?Q?u5oZ//UX0hXLtRS0fTNK8JmVrNAoO3l2mkUnMVVjvyiqCUQ4V/80q1i0DdwH?=
 =?us-ascii?Q?AuWtR/pv88AMTYO8XiKGagzCrHBlLrL6Y677EaIDwdLx1zZ1UjqA9eBJIQx2?=
 =?us-ascii?Q?9WlYRVp/009+F5cg8KYbxo/9yBAI4SnolTVRgdRF3F+YJdGgtmXcILeFxlqj?=
 =?us-ascii?Q?J3CX7os3sQyjWOG7lRjJG+twaZDHy7jsUphKJG+GRiciMCfon+G9zXcNx/Pd?=
 =?us-ascii?Q?s7QCJylD/w5FbgWsjkbB/WcOEaelMCUEZGEwcWvYugxJJgdAeYWO7X8do71B?=
 =?us-ascii?Q?EPr4hNvs5kpzWr6h7jDgLpPb2ImIvktg/DNjeHivLgooLd+5MTbRUKztY4Ve?=
 =?us-ascii?Q?MTFIRBElVU3dSum+5AE5Li30RZBGKj04mPPjowRGzPzdkPFt7QUpoaaSU2HA?=
 =?us-ascii?Q?u254xvcQHT7+abN1gzoDIYqxqi9tb7bTy0Ow00+i4MYqdiEZUtRJKM2AduK4?=
 =?us-ascii?Q?yQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bf18843-6f44-4f42-771e-08db67eb801f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 06:42:16.9846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R8lZoNFy/YCysUVOlmuR/B/WbYPjjWKbzXrwnAFwOG8c3vSuci/WafHQw+3RIjTumPkTxIzW2yQ+rcwBVDNH6J478Qimgw8dlTWCWrAFZkg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7637
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> Reading code like dport->dport does not immediately suggest that this
> points to the corresponding device structure of the dport. Rename
> struct member @dport to @dev.

This one I don't agree with.

This can switch to ->dport_dev if you like. The reason for ->dport was
for symmetry with the ->uport of a 'struct cxl_port'. So if you change
this to ->dport_dev then also make the ->uport_dev change for symmetry.

Unlike a 'struct cxl_port' a 'struct cxl_dport' is not a device in its
own right which is what I see when I read dport->dev.

> 
> While at it, also rename @new argument of add_dport() to @dport. This
> better describes the variable as a dport (e.g. new->dport becomes to
> dport->dev).

There is already other occurrences of dport_dev as an argument, so I
think that works here too.