Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 23:47:34 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 04/26] cxl/core/regs: Rename phys_addr in
 cxl_map_component_regs()
Message-ID: <64817986978c2_e067a2947f@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-5-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-5-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y5KvXqZacgQTGNzvHqarmNHUidLwjOnrhS2OXVVt7Rgi+WF0PcuEYF+TSbMt?=
 =?us-ascii?Q?jJjmLGXIPtEmw2CJ152EV0wiA8+bLRDmXO41K0yLUuUBIGrpKqNXTepWgXB1?=
 =?us-ascii?Q?Xphrur/jpK8u1jxBs6/NlVWp5PYI8hnuS7mtWODp9OqyUJn1JyjcOhT3JK05?=
 =?us-ascii?Q?WxzKqT1p8iPeAsRepvcoDQ3pyD4PJRuqcbJUTR7OZysCy+Lxk8DWfSpia0Xg?=
 =?us-ascii?Q?5NC2LvHnIpP1pHqKAtge3pkHJs3c1hV3ZEkDoyizQn4gREyEBPi2O6WwD5o3?=
 =?us-ascii?Q?uWNIPt4wWxyvmdXQuGvHEYmEcM5e/YLMRx6Tx2OS6I59sugLF79UqJI0LFgp?=
 =?us-ascii?Q?AyEmAGgOOSnQpRDIFs5T4if1ToxX35vjBVt/m0SzJXZE8OFHI/uE/AvoJwDq?=
 =?us-ascii?Q?IVVfWbYcJ0Pknscjdz+Eq23ngw2N60pDDiD8gftNmXQNOcYyswDYOg32cctX?=
 =?us-ascii?Q?ueie7WnUQ9M+5PfGzMzFZqSxPjOXu30KO2fcTpdJ61A/huI7tEJNpNpgvUo2?=
 =?us-ascii?Q?F8aZTK8a31srBcGOEaZ+nQ6hAAIzf/MQSFO8M0go7EEbtJmO1DOYlkxrf53j?=
 =?us-ascii?Q?7otSKwTnMZxEKcpyOyDxB+Ji3ZUvKkupuNcDv2YvCDe7X9wzSirjo06xAS8X?=
 =?us-ascii?Q?vEj/jG2qsm6bvveDGg0Owd4HJmlyXJz7TQHH3ulhiT3RE+F3OMZi7k1u+8qy?=
 =?us-ascii?Q?L+yAOfWu6/bye+34q86l0X9Wm/r8XnX3T3eP6AXoQxnDG9LuaPu2OyTyjkDP?=
 =?us-ascii?Q?yTsCIjmC0tAs00kbC67TOKVitsORL/JlcX12Br85trC3IpV2qG9JNdS33YF+?=
 =?us-ascii?Q?jc1zfVmC+EavMnVyvuagPtb+WTKRbuGe/l5GBwLXfbGnlXn+bXi7GAOpmJ8W?=
 =?us-ascii?Q?chPHxqxQR+CfXIq2XjBowj1+veoN0i45RhDx9keJFciC9P2dWFLNoSY6TvXD?=
 =?us-ascii?Q?FNvLIQ4i9YmDeqYu/m55YjyK1vLpNf65AadMLk2+DDjR7yagoTSLlwHqD15O?=
 =?us-ascii?Q?YBK2sYrC2kV72O+c/676aZe68bi4Q1AIkyBENaJ5ossJH0BK3UIGNinVHKYA?=
 =?us-ascii?Q?5Pw3ZnrLi0qvwPGFXjjub9I5EsJB1RtlvPiNDEOjS+jhUb/2062CDvwQXc2U?=
 =?us-ascii?Q?Hp2+AQzwhPJca1RsZ7E0BTZSmdUZnbfvspqFp1dbc17mXNHocn8uYc3sWbw9?=
 =?us-ascii?Q?TiyiNNXO5A2L9FMnt9PROQrJh2gQDSdpBU+lFM6uKeRYFDyhPsLAlWr6luc4?=
 =?us-ascii?Q?0mVxTU3x1xPVlUYOpv50TnDO3xgGhTA2h60BT05fDItY0+beHbRbxFkPv769?=
 =?us-ascii?Q?zt/LwdA2iMlITiicEdvAHw/kErElikDsxyf3/kaYSh2c4ZKoFBt7oq6qOJOq?=
 =?us-ascii?Q?U9alSiann3Bz5rY8o6q06dZqq0RGsZC2bwj6C46L8bNh/gJsYk/52Q9Ow77T?=
 =?us-ascii?Q?R6+0FKR/piBqgvG1CwngV/LoUFl6NbxM7pRlaZ2yYRFQ/O/wbPdW+Uju4CwD?=
 =?us-ascii?Q?FOXZAVxtSblAh0oAZvvs9Iv9dVi8AOVXegH5KG+S5SIY/bDCigTZuuNXFd5H?=
 =?us-ascii?Q?Gb6IOL16LXj8XIxmveH7j/i7cCzLYrlwZgWvJNQUlWbODky9sSeF52DCEQlS?=
 =?us-ascii?Q?sw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c791bfa3-01b2-48d8-da2c-08db67ec3f09
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 06:47:37.1938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dJVPc9vCkqXETTPrYEcUvhZ8aTj/XqiGcfnuKzBliRJSoHMFY1H9BvB4gysfCTrrNMZcOSQNUv958nB8Z2Kmx7KjdFVT5p5h95MCZ04SlhE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7637
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> Trivial change that renames variable phys_addr in
> cxl_map_component_regs() to shorten its length to keep the 80 char
> size limit for the line and also for consistency between the different
> paths.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> ---
>  drivers/cxl/core/regs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cxl/core/regs.c b/drivers/cxl/core/regs.c
> index 08da4c917f99..c2e6ec6e716d 100644
> --- a/drivers/cxl/core/regs.c
> +++ b/drivers/cxl/core/regs.c
> @@ -213,16 +213,16 @@ int cxl_map_component_regs(struct device *dev, struct cxl_component_regs *regs,
>  
>  	for (i = 0; i < ARRAY_SIZE(mapinfo); i++) {
>  		struct mapinfo *mi = &mapinfo[i];
> -		resource_size_t phys_addr;
> +		resource_size_t addr;
>  		resource_size_t length;
>  
>  		if (!mi->rmap->valid)
>  			continue;
>  		if (!test_bit(mi->rmap->id, &map_mask))
>  			continue;
> -		phys_addr = map->resource + mi->rmap->offset;
> +		addr = map->resource + mi->rmap->offset;
>  		length = mi->rmap->size;
> -		*(mi->addr) = devm_cxl_iomap_block(dev, phys_addr, length);
> +		*(mi->addr) = devm_cxl_iomap_block(dev, addr, length);

...but this line is only 75 chars, so not sure why you bothered, I
don't understand the consistency comment either.