Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp291324rwd; Thu, 8 Jun 2023 00:13:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7yUCsN6mdqT90I8LrX4yrqHr9Rw5MC1yZJEPhznE9zruJ9gdQTsPFzZp5rrUWz5rQncFmC X-Received: by 2002:a9d:6ac6:0:b0:6b2:ae03:ff00 with SMTP id m6-20020a9d6ac6000000b006b2ae03ff00mr2315796otq.13.1686208425302; Thu, 08 Jun 2023 00:13:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686208425; cv=none; d=google.com; s=arc-20160816; b=fCmlbAGF18yFC4FyM5MrCZCXH6Ts0njOb7ZsTp0Dc9UzRw8lptEMxE93QaeiRTYluA 4bJx8OuntqrLvlAuifOVg1e5VrfwRr8EWKojQDWcvyiIlC6y/TdlrD4bfSB/AM1B95E6 r6MW7CtPbUfQup0+ItN0bxEF+dJKrw8P5zQ/J8Bk81y7zVsUFg0oR9YcKIgG2h2Zjjqm z3lKfRYXMg+y6rIkzsufX9TPqy/xgHCorkINQEEfyM7n4Y/0RnjQ04VXOphIRSDOkkMR G4voyNFnkvJ00pM7CNHHmS5claKzyHWISktuJc5f/l/tlACvooG5Nk/GOE+ozSg6usP/ DxpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=Lpa+4F6dot7Vr6Y6Gm17X60b5nlO065rdDY8ivQUWUE=; b=Ow+s1O7liq4cLoK4Ef06EAY/jIgWQLvOaWDS7DUDBp44hi4ZFinIV06bC+eyZejXMD WtvhBrkEviJNlZSglIp+qyoc/ow8P0mne1GK0gFfZrQA3vLC1nCsy4ptsIsURjNVBxE2 TT9I5HyRyluqiu0LA0A1eKcj7CjJuxUJCMMZFE5WQowOgGmmZuFy71jLdas0xqVXxk4Q HmZmVmsW4AwCqa9TUemSowR0UX3o2KcuMw2pKHZSjvjvY6f6M/iQJaMmE4SpDd+ScV28 u4nG9ZQ/UhBH4S/7G2dFn8t8dUCFzcK13tWOuonPV2tbJC/yzdL0OGOmvNcBtL6lqkwv eIQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="h5y+/OUJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n20-20020a17090aab9400b00252779bf264si1995664pjq.52.2023.06.08.00.13.31; Thu, 08 Jun 2023 00:13:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="h5y+/OUJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235288AbjFHHCY (ORCPT + 99 others); Thu, 8 Jun 2023 03:02:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235156AbjFHHCD (ORCPT ); Thu, 8 Jun 2023 03:02:03 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBE931BD6; Thu, 8 Jun 2023 00:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686207710; x=1717743710; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=ef5s9TkcxXSlz6lTIJfajIVYzY4IV1HrFB/BqDVmIJA=; b=h5y+/OUJbTuPmHhSWwAORY3VTXo84225FNXdLYyTIXe42ZxNQwwHXyJD 5fZ4I8FTSmxVotSS2mdYMFBfJis9tMOMrEHkh2PcKhwQupPyZg6fd/H9f NBoAcEM1x6As1sCiowGRU+i+hf8kNL4L8D6Gz3X5u6D3SPKG8v/Lt9Ycs H2LnW8mZMVpZJf7xVr3G4L2bimpEIIHy0SV+nGSB7XwSSHu4+xWRF7uca soRWNr11VbtihbsjZGil371AJX5fqKZMVRC1Qvb4+zDwa3niPXVWVHMV+ 2XzOIgdXzHc9bp15WQzzjTuITA/mju9rS20ypoHOuJxLxLzcNH4Erc3iJ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="359696344" X-IronPort-AV: E=Sophos;i="6.00,226,1681196400"; d="scan'208";a="359696344" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 00:01:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="709867969" X-IronPort-AV: E=Sophos;i="6.00,226,1681196400"; d="scan'208";a="709867969" Received: from inesxmail01.iind.intel.com ([10.223.154.20]) by orsmga002.jf.intel.com with ESMTP; 08 Jun 2023 00:01:07 -0700 Received: from inlubt0316.iind.intel.com (inlubt0316.iind.intel.com [10.191.20.213]) by inesxmail01.iind.intel.com (Postfix) with ESMTP id 0E9AD1AA12; Thu, 8 Jun 2023 12:31:07 +0530 (IST) Received: by inlubt0316.iind.intel.com (Postfix, from userid 12101951) id 089691DE; Thu, 8 Jun 2023 12:31:07 +0530 (IST) From: Raag Jadav To: linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com, Raag Jadav Subject: [PATCH v1 1/4] pinctrl: intel: optimize set_mux hook Date: Thu, 8 Jun 2023 12:30:14 +0530 Message-Id: <20230608070017.28072-2-raag.jadav@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230608070017.28072-1-raag.jadav@intel.com> References: <20230608070017.28072-1-raag.jadav@intel.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Utilize a temporary variable for common shift operation inside ->set_mux() hook and save a few bytes. add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-3 (-3) Function old new delta intel_pinmux_set_mux 245 242 -3 Total: Before=10472, After=10469, chg -0.03% Signed-off-by: Raag Jadav --- drivers/pinctrl/intel/pinctrl-intel.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index c7a71c49df0a..e8adf2580321 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -411,18 +411,19 @@ static int intel_pinmux_set_mux(struct pinctrl_dev *pctldev, /* Now enable the mux setting for each pin in the group */ for (i = 0; i < grp->grp.npins; i++) { void __iomem *padcfg0; - u32 value; + u32 value, pmode; padcfg0 = intel_get_padcfg(pctrl, grp->grp.pins[i], PADCFG0); - value = readl(padcfg0); + value = readl(padcfg0); value &= ~PADCFG0_PMODE_MASK; if (grp->modes) - value |= grp->modes[i] << PADCFG0_PMODE_SHIFT; + pmode = grp->modes[i]; else - value |= grp->mode << PADCFG0_PMODE_SHIFT; + pmode = grp->mode; + value |= pmode << PADCFG0_PMODE_SHIFT; writel(value, padcfg0); } -- 2.17.1