Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 09:15:29 +0200
From:   Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To:     Sui Jingfeng <suijingfeng@loongson.cn>
Cc:     David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO
Message-ID: <ZIGAEZTJvq1GqFVD@aptenodytes>
References: <20230608024207.581401-1-suijingfeng@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ukkutT5+Jm73cGF3"
Content-Disposition: inline
In-Reply-To: <20230608024207.581401-1-suijingfeng@loongson.cn>
Precedence: bulk


--ukkutT5+Jm73cGF3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu 08 Jun 23, 10:42, Sui Jingfeng wrote:
> drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this
> two kconfig option, otherwise the driver failed to compile on platform
> without REGMAP_MMIO selected:
>=20
> ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/lo=
gicvc-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
>=20
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>

Thanks for the fix, looks good to me!

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> ---
>  drivers/gpu/drm/logicvc/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/logicvc/Kconfig b/drivers/gpu/drm/logicvc/Kc=
onfig
> index fa7a88368809..1df22a852a23 100644
> --- a/drivers/gpu/drm/logicvc/Kconfig
> +++ b/drivers/gpu/drm/logicvc/Kconfig
> @@ -5,5 +5,7 @@ config DRM_LOGICVC
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_DMA_HELPER
>  	select DRM_GEM_DMA_HELPER
> +	select REGMAP
> +	select REGMAP_MMIO
>  	help
>  	  DRM display driver for the logiCVC programmable logic block from Xylon
> --=20
> 2.25.1
>=20

--=20
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

--ukkutT5+Jm73cGF3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmSBgBEACgkQ3cLmz3+f
v9F1bwf9H0Dd8yQTcM8xZG7Jj89ztiiVUgzIOqIcgvhUGaWzdPj0sNgMZ6tF9Od3
w9YuXfJ/wsR5SqUKo04fPM7hOSX7wrelEUewmv1ZHPtoChGRNFhJ2Bi/KaIaUHNM
jODo6rf7qbDHqTdleg5SJxTAnqSLZQhG20a1sw70pFJTsX6F6bAnG1AaXItSBcAr
2RL43t13UY2MVb4ntFb0YtKho0hPtfsFBLzZsjZfHC4Gv0ZO24eE0TaWWcrQFY7s
n+nYJ+U/ja6/UByiM60gH33zB6OLXfkI8B0TssJ7iVZnqTqsgyLS2rIgA6Nz+9Vt
QYre3y/v+7t4W/GKGMqg5g18vy3akQ==
=M1u4
-----END PGP SIGNATURE-----

--ukkutT5+Jm73cGF3--