Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp318480rwd; Thu, 8 Jun 2023 00:45:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4OtlKqbYjfOty/qmlLrRfO+fVxjXTaW89iOpXbkU9g9Zu0BF8W5a2EyRRw20eDvvqMzi8j X-Received: by 2002:a05:6358:e911:b0:129:c4f1:e7ca with SMTP id gk17-20020a056358e91100b00129c4f1e7camr5818955rwb.27.1686210342401; Thu, 08 Jun 2023 00:45:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686210342; cv=none; d=google.com; s=arc-20160816; b=CtGVcdKoi7QCnxOIPOkbBbP25X4nD0dAFLMWxV4Kyt9s6eCBGhiE/NQXPZ63rIkoVf cjH8MM+ZeKGR1jrHsogGFKHbqtLa8/guQ/g7PlSJWv11mGNLsRkmnCegOe/b1qYhN4WM Ry+cR4hMCEY/DH4NlY1ojfiUbZrpblFMP5Ow4IvyuUT5IAjxTPs7rqxhK2Rw5qlSsQ/a sjB/Nbte34RWJNMCnuJIKSAbZySXyPUmJIcwmC6yT1sqPxhyMsGFf1b6wr6evg/FxvNC pCWCVzsnilD1Lpt6tJgXxdaiEan1ZNRO50X7IriHzjmo0BoMNzl1A+iYvFEYyuGgsKtP vjbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id; bh=iTTKiHbbh00sgy8oXVya9s0prkhzVnueZKqHsQzK/hs=; b=C5GCmpRfL4M3J95xjkPVH1hURtfQUl93K/Jxx75j4WtJQkix/pivxAIreeu354Be22 Lg7mk7bXvOD49x+sK8dJ6/LvnSH+/eltR6evEZ/bsh1h9Wzo1jLob0opbxcHabPP1GEs 9X9FcN+lOAxEhnLA2OD1n9PewkYjg27s13TEcPX4/yECLeaMXs7+/ZNFIpIJ2al1YXz7 gZPG2S5WNq7FlpHqDUgsy3CGd4RFZdBQXXS4j/pcVJeTgFBp8/MPYJ8Y6yheEeAxkg0E 0525Onc2gNq3R5ij00DcjxHfKNmEoVp/bLCBV6I2dn5VOnJIoPA7ZiyQX0zSJVID0y2i FRwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v2-20020a63ac02000000b00518f82d7053si608657pge.493.2023.06.08.00.45.27; Thu, 08 Jun 2023 00:45:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235352AbjFHHZJ (ORCPT + 99 others); Thu, 8 Jun 2023 03:25:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235465AbjFHHZA (ORCPT ); Thu, 8 Jun 2023 03:25:00 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C651B137 for ; Thu, 8 Jun 2023 00:24:57 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.43]) by gateway (Coremail) with SMTP id _____8AxHutGgoFknnMAAA--.1744S3; Thu, 08 Jun 2023 15:24:54 +0800 (CST) Received: from [10.20.42.43] (unknown [10.20.42.43]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxZuRGgoFkr98GAA--.22149S3; Thu, 08 Jun 2023 15:24:54 +0800 (CST) Message-ID: Date: Thu, 8 Jun 2023 15:24:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO Content-Language: en-US To: Paul Kocialkowski Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230608024207.581401-1-suijingfeng@loongson.cn> From: Sui Jingfeng Organization: Loongson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf8AxZuRGgoFkr98GAA--.22149S3 X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBj93XoW7ZF1kZryDZr18GF1xur13Jrc_yoW8XFW7pr W8Ka4jyF4IvFW5KF1xAr13XFy5X3WkGFWS9F12k3WDuwn8AFyDZr93ZrWYgFy5ZrZrJF40 yFn7Ka45Ga12kagCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9Sb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv 67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C2 67AKxVWUXVWUAwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI 8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWU CwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r 1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBI daVFxhVjvjDU0xZFpf9x07jYSoJUUUUU= X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, thanks a lot On 2023/6/8 15:15, Paul Kocialkowski wrote: > Hi, > > On Thu 08 Jun 23, 10:42, Sui Jingfeng wrote: >> drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this >> two kconfig option, otherwise the driver failed to compile on platform >> without REGMAP_MMIO selected: >> >> ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined! >> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 >> make: *** [Makefile:1978: modpost] Error 2 >> >> Signed-off-by: Sui Jingfeng > Thanks for the fix, looks good to me! > > Acked-by: Paul Kocialkowski After received this Acked-by, do a need append this tag to the patch, and resend this again? I don't know about this. I don't need to do anythings ales, you will push it to your repository, right? > Cheers, > > Paul > >> --- >> drivers/gpu/drm/logicvc/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/logicvc/Kconfig b/drivers/gpu/drm/logicvc/Kconfig >> index fa7a88368809..1df22a852a23 100644 >> --- a/drivers/gpu/drm/logicvc/Kconfig >> +++ b/drivers/gpu/drm/logicvc/Kconfig >> @@ -5,5 +5,7 @@ config DRM_LOGICVC >> select DRM_KMS_HELPER >> select DRM_KMS_DMA_HELPER >> select DRM_GEM_DMA_HELPER >> + select REGMAP >> + select REGMAP_MMIO >> help >> DRM display driver for the logiCVC programmable logic block from Xylon >> -- >> 2.25.1 >> -- Jingfeng