Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 09:31:02 +0200
From:   Christian Brauner <brauner@kernel.org>
To:     Florian Fainelli <florian.fainelli@broadcom.com>
Cc:     linux-kernel@vger.kernel.org, gehao@kylinos.cn,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Kieran Bingham <kbingham@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Pankaj Raghav <p.raghav@samsung.com>,
        Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] scripts/gdb: Fix SB_* constants parsing
Message-ID: <20230608-sinkt-melodie-5816a03405de@brauner>
References: <20230607221337.2781730-1-florian.fainelli@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230607221337.2781730-1-florian.fainelli@broadcom.com>
Precedence: bulk

On Wed, Jun 07, 2023 at 03:13:35PM -0700, Florian Fainelli wrote:
> After f15afbd34d8f ("fs: fix undefined behavior in bit shift for
> SB_NOUSER") the constants were changed from plain integers which
> LX_VALUE() can parse to constants using the BIT() macro which causes the
> following:
> 
> Reading symbols from build/linux-custom/vmlinux...done.
> Traceback (most recent call last):
>   File "/home/fainelli/work/buildroot/output/arm64/build/linux-custom/vmlinux-gdb.py", line 25, in <module>
>     import linux.constants
>   File "/home/fainelli/work/buildroot/output/arm64/build/linux-custom/scripts/gdb/linux/constants.py", line 5
>     LX_SB_RDONLY = ((((1UL))) << (0))
> 
> Use LX_GDBPARSED() which does not suffer from that issue.
> 
> f15afbd34d8f ("fs: fix undefined behavior in bit shift for SB_NOUSER")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---

Fine by me,
Acked-by: Christian Brauner <brauner@kernel.org>