Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 11:31:55 +0200
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Andrej Picej <andrej.picej@norik.com>
Cc:     a.zummo@towertech.it, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org, upstream@phytec.de
Subject: Re: [PATCH] rtc: rv3028: Improve trickle charger logic
Message-ID: <20230608093155cedff41a@mail.local>
References: <20230608090446.2899646-1-andrej.picej@norik.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230608090446.2899646-1-andrej.picej@norik.com>
Precedence: bulk

Hello,

On 08/06/2023 11:04:46+0200, Andrej Picej wrote:
> +	ret = regmap_read(rv3028->regmap, RV3028_BACKUP, &val_old);
> +	if (ret < 0)
> +		return ret;
> +
> +	/* mask out only trickle charger bits */
> +	val_old = val_old & (RV3028_BACKUP_TCE | RV3028_BACKUP_TCR_MASK);
> +
>  	/* setup trickle charger */
> -	if (!device_property_read_u32(&client->dev, "trickle-resistor-ohms",
> -				      &ohms)) {
> +	if (device_property_read_u32(&client->dev, "trickle-resistor-ohms", &ohms)) {
> +		/* disable the trickle charger */
> +		val = 0;

You can't do that, this will break existing users that may set the
trickle charger from their bootloader for example.

> +	} else {
>  		int i;
>  
>  		for (i = 0; i < ARRAY_SIZE(rv3028_trickle_resistors); i++)
> @@ -947,15 +957,21 @@ static int rv3028_probe(struct i2c_client *client)
>  				break;
>  
>  		if (i < ARRAY_SIZE(rv3028_trickle_resistors)) {
> -			ret = rv3028_update_cfg(rv3028, RV3028_BACKUP, RV3028_BACKUP_TCE |
> -						 RV3028_BACKUP_TCR_MASK, RV3028_BACKUP_TCE | i);
> -			if (ret)
> -				return ret;
> +			/* enable the trickle charger and setup its resistor accordingly */
> +			val = RV3028_BACKUP_TCE | i;
>  		} else {
>  			dev_warn(&client->dev, "invalid trickle resistor value\n");
>  		}
>  	}
>  
> +	/* only update EEPROM if changes are necessary */
> +	if (val_old != val) {
> +		ret = rv3028_update_cfg(rv3028, RV3028_BACKUP, RV3028_BACKUP_TCE |
> +					RV3028_BACKUP_TCR_MASK, val);
> +		if (ret)
> +			return ret;
> +	}
> +
>  	ret = rtc_add_group(rv3028->rtc, &rv3028_attr_group);
>  	if (ret)
>  		return ret;
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com