Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp427527rwd; Thu, 8 Jun 2023 02:46:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5p9kRGGhSaSTa9AWsWTDBIXTR47Uame0BAuMEIXq5XY7vGuRU8Pj+aD32euV1gBG2vcjg/ X-Received: by 2002:a05:6358:4f89:b0:129:cce3:a876 with SMTP id cg9-20020a0563584f8900b00129cce3a876mr1626516rwb.19.1686217581277; Thu, 08 Jun 2023 02:46:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686217581; cv=none; d=google.com; s=arc-20160816; b=kVwSc8deay6NDcOW7LP+pPxevajRJc6uF7/6txgpLvMhHJgnbHvC7OTX0ZW9dDPK1r jvfCQ1Gd6x29QBkWhb1TQaHsGoSHIemBrxQ+eBHIiS36fdiJLxLHuFOynNqBNyk+QNuI L/L88FZ6sooM1Psh3L9EY4FNsgv8KRxh5FywuVt5WhbQOe6HctQ+r25tulb01LwYr7Bd F/yGGZYnHFSR/7/SbuFEpdaBcKLplF1HN4J5NKPf8BARJ/DuYRWWqaorVl1AgC3ElgnH AUR0ykHIXjl8gYavBj/2be7XI6ox63lwU4JYW9osSXrNAFljMiz4Rtg9kAv+nnvEnkHA cfjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ftCiaD3sOm8AAbXhShWcujgvc86zUIInO5uxAWXSECw=; b=NS0GyazsQLO0Qsfw+cmGaYUTWNTCVn191XAR5S14r35C+IN0TyqxH6+JeS9IOR1bNn m4+JzYjIocXB8hEA0zYpdVB5bgGiVNkMpXptXR4GdDJSMsJp7KIIOd7fn+eF4pmbDCK5 RoQO58sUx1hfrfBmcuLAny723NnfiClhH2RRusIaMaasreGgATFburiXJi26hepwCdja 19SH3eRMMglBt625c02fa/JnT6A+mJt9lYF25VOh2oiU24AGuEl2+U6EwydGsSLhn4pA f1nimofs6QzI/V0xqR+YzEX5yjDgOeZB0MrvaWZeVy7DRHW+WOiBppVn4X52oJqr87mS 7hzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZfcYQpDO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h21-20020a633855000000b00534842e134fsi767319pgn.272.2023.06.08.02.46.09; Thu, 08 Jun 2023 02:46:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZfcYQpDO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233162AbjFHJLe (ORCPT + 99 others); Thu, 8 Jun 2023 05:11:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232164AbjFHJLN (ORCPT ); Thu, 8 Jun 2023 05:11:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94A97E7; Thu, 8 Jun 2023 02:11:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F7B061A21; Thu, 8 Jun 2023 09:11:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18AE2C433EF; Thu, 8 Jun 2023 09:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1686215471; bh=TkoZu+Gddauql3to8E6r++VcgqF/WSm1eT1Il4za0to=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZfcYQpDOjIlDOxp4KZ9MV4WNJ96DSAgWHDHqmWHHqX/+2Zg0cUVJUW3vH7dQx/xQE EyndX5A9cqwFbtfSP6Ga40YUhLvi+aZaSwwCIsujuxPnmtQpUPS36urLR7x76QDRuw M5XX0D0WPyQf+ASlKmLyKKGb0Kqsp9grqubXL0jQ= Date: Thu, 8 Jun 2023 11:11:09 +0200 From: Greg Kroah-Hartman To: zhuyinbo Cc: Minas Harutyunyan , Bjorn Helgaas , Alan Stern , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn Subject: Re: [PATCH v1] usb: dwc2: add pci_device_id driver_data parse support Message-ID: <2023060817-tinker-reaction-bbe1@gregkh> References: <20230518092240.8023-1-zhuyinbo@loongson.cn> <2023051843-scruffy-gush-cdec@gregkh> <2023060827-overlaid-displace-b3a1@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 04:57:04PM +0800, zhuyinbo wrote: > > > 在 2023/6/8 下午4:01, Greg Kroah-Hartman 写道: > > On Thu, Jun 08, 2023 at 03:54:36PM +0800, zhuyinbo wrote: > > > > > > Friendly ping ? > > > > For what? I thought a new series was going to be submitted, I don't > > have anything in my queue to review for this at the moment. > > > I have some comments that need your consent or opinion. > such as, I have a explanation why I using pci_match_id() in > dwc2/params.c. Do you agree with my explanation ? I have no context here, sorry. Remember, we review hundreds of patches a week, when you cut off all context that makes it impossible to remember. Submit your updated patchset based on what you feel is correct and we can review it from there. thanks, greg k-h