Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6d5b5538-6ef3-a409-4a8f-bb9b54eb478c@loongson.cn>
Date:   Thu, 8 Jun 2023 17:43:32 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO
To:     Andi Shyti <andi.shyti@linux.intel.com>
Cc:     Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230608024207.581401-1-suijingfeng@loongson.cn>
 <ZIGAEZTJvq1GqFVD@aptenodytes>
 <aff664c7-b692-4fcf-ad61-8030cc648501@loongson.cn>
 <ZIGf6mKwX9RIm5a5@ashyti-mobl2.lan>
Content-Language: en-US
From:   Sui Jingfeng <suijingfeng@loongson.cn>
Organization: Loongson
In-Reply-To: <ZIGf6mKwX9RIm5a5@ashyti-mobl2.lan>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,  thanks for your reply and help.

On 2023/6/8 17:31, Andi Shyti wrote:
> Hi Jingfeng,
>
> On Thu, Jun 08, 2023 at 03:24:54PM +0800, Sui Jingfeng wrote:
>> Hi,
>>
>> thanks a lot
>>
>> On 2023/6/8 15:15, Paul Kocialkowski wrote:
>>> Hi,
>>>
>>> On Thu 08 Jun 23, 10:42, Sui Jingfeng wrote:
>>>> drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this
>>>> two kconfig option, otherwise the driver failed to compile on platform
>>>> without REGMAP_MMIO selected:
>>>>
>>>> ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined!
>>>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
>>>> make: *** [Makefile:1978: modpost] Error 2
>>>>
>>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>> Thanks for the fix, looks good to me!
>>>
>>> Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
>> After received this Acked-by, do a need append this tag to the patch, and
>> resend this again?
>>
>> I don't know about this.
>>
>> I don't need to do anythings ales, you will push it to your repository,
>> right?
> no need... someone will pick it up and add the needed tags.
Thanks a lot. Happy coding! :-)
> Andi

-- 
Jingfeng