Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8b532eb-5233-f7a1-9e36-7f762208e903@gmail.com>
Date:   Thu, 8 Jun 2023 11:52:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH] drm/panel: s6d7aa0: remove the unneeded variable in
 s6d7aa0_lock
To:     Andi Shyti <andi.shyti@linux.intel.com>,
        Wang Jianzheng <wangjianzheng@vivo.com>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
        open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
References: <20230608033446.18412-1-wangjianzheng@vivo.com>
 <ZIGhBvFlHwVmKJG4@ashyti-mobl2.lan>
Content-Language: en-US
From:   Artur Weber <aweber.kernel@gmail.com>
In-Reply-To: <ZIGhBvFlHwVmKJG4@ashyti-mobl2.lan>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/06/2023 11:36, Andi Shyti wrote:
> Hi Jianzheng,
> 
> On Thu, Jun 08, 2023 at 11:34:46AM +0800, Wang Jianzheng wrote:
>> Remove unneeded variable and directly return 0.
>>
>> Signed-off-by: Wang Jianzheng <wangjianzheng@vivo.com>
>> ---
>>  drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
>> index 102e1fc7ee38..fec0d014fd0e 100644
>> --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
>> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
>> @@ -66,7 +66,6 @@ static void s6d7aa0_reset(struct s6d7aa0 *ctx)
>>  static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock)
> 
> actually this function can completely made void.

It can't be made void, as the mipi_dsi_dcs_write_seq() macro calls
return with an int[1].

Best regards
Artur

[1] https://github.com/torvalds/linux/blob/v6.4-rc5/include/drm/drm_mipi_dsi.h#L319-L337