Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 11:15:38 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Walker Chen <walker.chen@starfivetech.com>
Cc:     Claudiu Beznea <Claudiu.Beznea@microchip.com>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ASoC: starfive: Cleanup and fix error check for
 JH7110 TDM
Message-ID: <fbbc0963-fba5-4178-b886-fbb35c0c8df2@sirena.org.uk>
References: <20230607081439.1517-1-walker.chen@starfivetech.com>
 <3eb7ffc5-a16a-4ac2-93a0-260f7cb1f81c@sirena.org.uk>
 <d941ac20-e8b3-cb13-4258-3a9a86e978d3@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="PKcaVHh5qOw7fnfv"
Content-Disposition: inline
In-Reply-To: <d941ac20-e8b3-cb13-4258-3a9a86e978d3@starfivetech.com>
Precedence: bulk


--PKcaVHh5qOw7fnfv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 08, 2023 at 10:15:03AM +0800, Walker Chen wrote:
> On 2023/6/7 19:44, Mark Brown wrote:

> >> -		  (tdm->rx.wl << WL_BIT) |
> >> -		  (tdm->rx.sscale << SSCALE_BIT) |
> >> -		  (tdm->rx.sl << SL_BIT) |
> >> -		  (tdm->rx.lrj << LRJ_BIT);
> >> +	datarx =3D (tdm->rxwl << 8) |
> >> +		  (tdm->rxsscale << 4) |
> >> +		  (tdm->rxsl << 2) |
> >> +		  TDM_PCMRXCR_LEFT_J;

> > I'm not sure this change to use numbers here is a win - the _BIT
> > definitions look fine (I might've called them _SHIFT but whatever).

> This is Claudiu's advice. Using the macro BIT() to replace these definiti=
on of *_BIT,=20
> it will result in big changes in the code.

I'm questioning doing a change at all.

> Please refer to previous comments:
>  https://lore.kernel.org/all/143e2fa2-e85d-8036-4f74-ca250c026c1b@microch=
ip.com/

I can't find the comments you're referring to in there.

--PKcaVHh5qOw7fnfv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSBqkkACgkQJNaLcl1U
h9CWywf/Z1xfv//r9y6BIdrx+QwhKwPVc+ncix5QdBhiVs6lXk4evYULyaOiLLi1
uajsPVJ7VZgYRbUJpZRbb0QUqXpFiYv7IgCczTeZifvZryIcjopEm3eEaAXMErLI
r5y7LVayIa95enLcjWgyoISRLB9/1kXuBmKqo6JA7xakIyMwG5gioVte7W2B1vpu
AJ3BLVh2zZsIm03d3FagA5omPMLAKEEP6eHbZr9rYkn7oiPutgm6TN4up5h1XWrD
Ua12qPKgU5TnU9bUD4ymUojA2kz4LD69Fy4UgFLyjJ7NF9VrzwHK+iqjgxqrFLOR
WBxCnZbXj6Z+TexDiFUZAgcd2OqhtA==
=i16b
-----END PGP SIGNATURE-----

--PKcaVHh5qOw7fnfv--