Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 12:49:13 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Ivan Mikhaylov <fr0st61te@gmail.com>
Cc:     Samuel Mendoza-Jonas <sam@mendozajonas.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vijay Khemka <vijaykhemka@fb.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
        stable@vger.kernel.org, Paul Fertser <fercerpav@gmail.com>
Subject: Re: [PATCH v3 2/2] net/ncsi: change from ndo_set_mac_address to
 dev_set_mac_address
Message-ID: <ZIGyKQV2yHTa+cI4@corigine.com>
References: <20230607151742.6699-1-fr0st61te@gmail.com>
 <20230607151742.6699-3-fr0st61te@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230607151742.6699-3-fr0st61te@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ptQqlahjc7Qj6HwDkA4mqSdAJJ0D46627c+TQycmPqbD4IXe/E/DFCZg/zL5?=
 =?us-ascii?Q?6qFNZZYtIpc9hKm6Ul5PkEHTeROdsNP6YHgrGcOKxlSnqVGmNaL2A4qBeN1K?=
 =?us-ascii?Q?YIpvTvyijQTaumRVsW/OAnF3qQE5yFQj+uGB5PnXAIrrT3OrZZZpNR8E/b4n?=
 =?us-ascii?Q?Vskn/n2JaVcGBvXKJclN6hnnRkCwDplLEHNqXvFXtSqSETRDbCGIykKFB7tr?=
 =?us-ascii?Q?kxeEDPWg2SIhs9QzBda7GG9C4PRrFVcYU8oeTIRo8Z6ICpa/LXMj96fxHWNm?=
 =?us-ascii?Q?9Qde0IvOOMbolZRUqGBs1vR3xdpaa6zIKx8RtJ3skAbie3ABEPch0g7bItKJ?=
 =?us-ascii?Q?7Z3CgDkrQeg5pe84aVzCSrfGwrvVuE6P4cWms7eFrQ016y06UdR7CW/WTNiN?=
 =?us-ascii?Q?twmLi39NdkSf9yq9jB4srT5dHWgbZgUktrjZzYSPqCdZ+kvEQoaTcLG6dIhN?=
 =?us-ascii?Q?0Rl2L89xZvTGWjV4SrzRBjcs0c7+KvswJpPigKQqaKBAmZYGI7xBEIkdNY6g?=
 =?us-ascii?Q?7dDMzAf2pLR3oWHDmBmehvz4f0I6YnhhG2VFhIZ1X9Gq4rY2CtqVD1gG3LRf?=
 =?us-ascii?Q?T/5gxh98rSvD5g872fescu2izKNKLgTkDriwlqk7KzfjgIj9FQY5RgI+A6Ax?=
 =?us-ascii?Q?pjhpWflUjGyuTjvNIBj7zekk4zPabHXFwmqpPGuMfvrYl+Xpvji7LZT57Y6I?=
 =?us-ascii?Q?ey5ZtUKXB+JBlEqGRhyS8n9Hj7WVags5//RSsD/E9v9WNTP0fVOl7Ab2uo7L?=
 =?us-ascii?Q?k3QJCpzvApD6NJONjWBsSPcrpQAd1lbLsit0VT7BwI4qOoFoLPBGaenq/9/i?=
 =?us-ascii?Q?dBxRD4HKymOJDf1cRLQcfuUM0rYKmVwMQ2Kd1wCjJxcmiiti9qtCyct0LB9P?=
 =?us-ascii?Q?fb22mrow+eS/FjPUPFId2F6EqnNoBbTP8dMVYjYgmsoTW+mZt2qXtJ2vLB6I?=
 =?us-ascii?Q?UF5+qg7NeXdVmImoYWRRaI/6YINWK43Do9V+YU4k78jFkoo/PDhZZHR9xmCi?=
 =?us-ascii?Q?0sh989k2bXq+JXE62qUfX+sbs2rVZeB1S+r0w8e3GURKUYGNJJUBPVmR12H0?=
 =?us-ascii?Q?AxmU1tbs0lscRTYIWGsHbV1AYNQ4cWT4kPCZVAoAzyDNNbhVVoGpv7l4N6HE?=
 =?us-ascii?Q?Hfxn2L6Jpb1L/RZ2KdbvnRzhYmfg7fuCWEh9ygwbxolkpcoYGU4X21M52zu3?=
 =?us-ascii?Q?6+cVcBL29OgYLfC3lGs0B37Jli7ujvPxR5qfOwcPmHmIvPUDiaafixmbWIZs?=
 =?us-ascii?Q?9VpESwpvrii45a2d5GAJ7xapNXVsKXIDHwi03rt6/H1He3HSxfhL18ocfpW9?=
 =?us-ascii?Q?1dq72lf9nwqIgYeEpg7C+r+viMuhXGBcQ92DcBbjpMvHXBBzRh+0QbTqln4Y?=
 =?us-ascii?Q?EqxsgxQe8Rja/iitQb/w2PT8isqnSgJw2Ikcu7AQ+ON8fcmYfTUfVppuyCyk?=
 =?us-ascii?Q?T9yd6FMnx1IvFO21ugcPYX+8uG440EHTAz3vxLGgBSJCz4TChrC9WhCUpEJT?=
 =?us-ascii?Q?uXxUSaVh97NpYU2gME8SSqlUMY3E2YGECyDN1w6zmrdatYqXyhRBg7RI4hSp?=
 =?us-ascii?Q?mFUYRcK/2jCHML4opegkJMBbI6m89YuL8trVKI73aJgIELlxq/XEAtA4zH6C?=
 =?us-ascii?Q?xD+Iz/1igHclZ4xFhvi/7XuHJs2FlfntmbrV+SIuLKnM3CGSP0XvhEO/R43u?=
 =?us-ascii?Q?azNsPg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79de3500-5785-4ad2-eee5-08db680e03fd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 10:49:21.1251
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qjof1PCD6X55MvolL2gvjxHxCs3BG3yq86ZImSrybrvn0j6ilT9BaF06xboTRrzsjAi0iCCSW5gtlX8OBqbvncH5rTcrVtYzen68bkJNO+Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB5044
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 07, 2023 at 06:17:42PM +0300, Ivan Mikhaylov wrote:
> Change ndo_set_mac_address to dev_set_mac_address because
> dev_set_mac_address provides a way to notify network layer about MAC
> change. In other case, services may not aware about MAC change and keep
> using old one which set from network adapter driver.
> 
> As example, DHCP client from systemd do not update MAC address without
> notification from net subsystem which leads to the problem with acquiring
> the right address from DHCP server.
> 
> Fixes: cb10c7c0dfd9e ("net/ncsi: Add NCSI Broadcom OEM command")
> Cc: stable@vger.kernel.org # v6.0+ 2f38e84 net/ncsi: make one oem_gma function for all mfr id
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
> Signed-off-by: Ivan Mikhaylov <fr0st61te@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>