Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <55b59833-d070-f576-9d85-047175d9722c@linaro.org>
Date:   Thu, 8 Jun 2023 13:29:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH 1/2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt
 to yaml
Content-Language: en-US
To:     "Mehta, Piyush" <piyush.mehta@amd.com>,
        Rob Herring <robh@kernel.org>
Cc:     "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "Paladugu, Siva Durga Prasad" <siva.durga.prasad.paladugu@amd.com>,
        "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        "nava.manne@xilinx.com" <nava.manne@xilinx.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "Simek, Michal" <michal.simek@amd.com>,
        "git (AMD-Xilinx)" <git@amd.com>
References: <20230607065121.2265076-1-piyush.mehta@amd.com>
 <20230607065121.2265076-2-piyush.mehta@amd.com>
 <168612336438.2153757.6000360498539992409.robh@kernel.org>
 <MN2PR12MB4333E0628E2E67652E80067A8850A@MN2PR12MB4333.namprd12.prod.outlook.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <MN2PR12MB4333E0628E2E67652E80067A8850A@MN2PR12MB4333.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/06/2023 12:55, Mehta, Piyush wrote:
> Hello,
> 
>> -----Original Message-----
>> From: Rob Herring <robh@kernel.org>
>> Sent: Wednesday, June 7, 2023 1:06 PM
>> To: Mehta, Piyush <piyush.mehta@amd.com>
>> Cc: p.zabel@pengutronix.de; Paladugu, Siva Durga Prasad
>> <siva.durga.prasad.paladugu@amd.com>; michal.simek@xilinx.com;
>> nava.manne@xilinx.com; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-usb@vger.kernel.org; conor+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; robh+dt@kernel.org; Simek, Michal
>> <michal.simek@amd.com>; git (AMD-Xilinx) <git@amd.com>
>> Subject: Re: [PATCH 1/2] dt-bindings: reset: convert the xlnx,zynqmp-reset.txt
>> to yaml
>>
>>
>> On Wed, 07 Jun 2023 12:21:20 +0530, Piyush Mehta wrote:
>>> Convert the binding to DT schema format. It also updates the
>>> reset-controller description.
>>>
>>> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
>>> ---
>>> Note:
>>> The 1/2 patch introduced a warning related to the dt binding check,
>>> which was subsequently fixed in the 2/2 patch. This warning is a
>>> conversion warning due to a dependency on firmware dt binding.
>>>
>>> Warning:
>>>   DTC_CHK
>>> Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.example.dtb
>>>
>> /scratch/piyushm/torvalds/linux/Documentation/devicetree/bindings/reset/xln
>> x,zynqmp-reset.example.dtb: zynqmp-firmware: 'reset-controller' does not
>> match any of the regexes: 'pinctrl-[0-9]+'
>>> 	From schema:
>>> /scratch/piyushm/torvalds/linux/Documentation/devicetree/bindings/firm
>>> ware/xilinx/xlnx,zynqmp-firmware.yaml
>>>
>>> Please suggest to me, if it's fine to make a single patch instead of
>>> the separate patch 1/2 and 2/2.
>>> ---
>>>  .../bindings/reset/xlnx,zynqmp-reset.txt      | 55 ---------------
>>>  .../bindings/reset/xlnx,zynqmp-reset.yaml     | 67 +++++++++++++++++++
>>>  2 files changed, 67 insertions(+), 55 deletions(-)  delete mode
>>> 100644 Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.txt
>>>  create mode 100644
>>> Documentation/devicetree/bindings/reset/xlnx,zynqmp-reset.yaml
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-
>> ci/linux/Documentation/devicetree/bindings/reset/xlnx,zynqmp-
>> reset.example.dtb: zynqmp-firmware: 'reset-controller' does not match any of
>> the regexes: 'pinctrl-[0-9]+'
>> 	From schema: /builds/robherring/dt-review-
>> ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
>> firmware.yaml
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.ozlabs.org/project/devicetree-
>> bindings/patch/20230607065121.2265076-2-piyush.mehta@amd.com
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above error(s),
>> then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
> 
> This dt_binding warning is known to us and is captured in commit description notes and to resolve it, we need to apply 2/2.

So your patchset has broken bisectability. You need to fix it. If the
warning was known, then I am surprised that you sent broken patchset.

> I want to take DT maintainer opinion if we should keep the fix in 2/2 or merge it in 1/2.

Just avoid the warning. Anyway you need only one complete example, right?

Best regards,
Krzysztof