Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 14:08:26 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: pch_gbe: Allow build on MIPS_GENERIC kernel
Message-ID: <ZIHEutLwlOi1YDfX@corigine.com>
References: <20230607055953.34110-1-jiaxun.yang@flygoat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230607055953.34110-1-jiaxun.yang@flygoat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tuYS9VIZe0qhAQf8LHWY82frZUgi5/Ws1/ywr3CThQuAe9XycoqRGaWPd9zy?=
 =?us-ascii?Q?boP0Z9d82Kv3Pckq4Sma+wlXgq33Ee0W48dMM971xMSJC8+2XPwAcz9Z32EY?=
 =?us-ascii?Q?mjEvluTrWqdKtgsRI9biBWOSdJ/yak5+0/vvo5t/2iZwHCJ1T600iDnN0JHY?=
 =?us-ascii?Q?tIaEBiJI9e8RKwy603xfBtiOw6rInIouEuSIv4v+0Aj9Gs+M8b6X8fc0XtWH?=
 =?us-ascii?Q?b0HJa/AsexrCHdipqzYsFUp70JuacKCf7yXszy2WImTISuXW6mPVtEkHl8SC?=
 =?us-ascii?Q?Vgy8+xPP28FLW3y4XIV4nADIxXOyKGseyua7nto5W2o5M1dGNsjxq8MKsGlz?=
 =?us-ascii?Q?+c11T1LyCl2FwxzVMJdJH6Y0K1iknqsS6SJAD4zjy6SiflWgMPIh0S7MDsAH?=
 =?us-ascii?Q?cZNNIDiF1w1hHM35jYR4GxZ54QPqOUM6w5xUX87xCNJKccbi6HEFqhiqnBb5?=
 =?us-ascii?Q?fal5RZqA44EDoJVDnMmXz8C6EjfTGgtSFDs3w/SI+hSqTNhy5AC0vmbdfN/z?=
 =?us-ascii?Q?QB1xCTmJGR7s9ezLUweRoWzT+Jkv7FglcBp/H/+QhxGMvfyIqwAgIn51hsUX?=
 =?us-ascii?Q?5/bPcHVZwyPT/kAPsLq9yIebiupMofr9Y0wujeAmT5vLaGjiBBg1QkU0W5RE?=
 =?us-ascii?Q?ZgGE6qyIV+N8gjaWaB1kqa7Ya59K5LzGoTi399HwoiPonTh0TYusEvRrsPd9?=
 =?us-ascii?Q?OisfNbtSMGiH40b3+5HEg0QArPVdWdYYXI2YnswqjpIO14tSbaBZV9vVa8S6?=
 =?us-ascii?Q?sFpLTR7M4eFCyU8FE2tH5tcn1LNRT7I3qUH2mhLkU5ZCO4XvO83PvRtCTtQV?=
 =?us-ascii?Q?UXdk74iPfjkD+4372dafVKXCJ4eMhlKe0wesdTiQuYNacAFFwjEahYFa/9Jt?=
 =?us-ascii?Q?NddwgZV1aJZXykjtroxB3xUb1Eo/SPsr+7BjvTx+gZYoQuwDEPnTLolGR+Bd?=
 =?us-ascii?Q?C0lZmOA0RoRQwOnXnjNdotodT7ZExC7aDPxfyoBWd4pUte43HToaNjxlGP8q?=
 =?us-ascii?Q?EuZW6k/ESxq0NuSv6xcYGqgilJRuKAA7SKGUdAvhS2zl6F3NziYoBG0zES4K?=
 =?us-ascii?Q?Q3CGnM0v753xd/BXhgYsOElEvc3m8EmBfEYZaYKcv+Wk42Ifg6+wSrAS3hDJ?=
 =?us-ascii?Q?iEOZbiabOHtZUJPP0FFRM1jx1Ec+35vjJ2Xrudxo+XE55O66uXM01awm8EYy?=
 =?us-ascii?Q?BmDPnpE2vQ0aBBiE81PPnMIMYBwuTBEezqpiNdiCcc+ipFzxcRGm5SUuGmSW?=
 =?us-ascii?Q?yQjDvggbcFRyUys3640A+/6/o1rFg2c5w44C8ke7e1aSzMqLO6tqfpZcL2SX?=
 =?us-ascii?Q?ZhrecVtUVkuBeMHl5Rw0fII6cKpu7pCtQHiaV1COXZzUsb8Y5ga7fNAVIJRT?=
 =?us-ascii?Q?yEm1SNlIxWUuNWx7fcMer2WvjyfjRgruFTXrFxOe1Z2g3IV0dC5vXjkJxN9G?=
 =?us-ascii?Q?06StE1fMKSSYqh9l0LbK1PXrSQyVcdF4Xzn7YlbMQvDv+m0CtQDwhjBVEQCP?=
 =?us-ascii?Q?9d4oNKSBAJdZCI1sBmPvdIWjfkzJrqZCZPB9t5KwCrUCEw6sGDC5Q3KJ0h9A?=
 =?us-ascii?Q?cHPnFKOScWdUkclmR+/i8HHhEwGrM89XfR/XPMMaCvTpjvOfEGzXrO2p0hZh?=
 =?us-ascii?Q?VBa8CHAHhOQ8AH7+rs3Lhfu3IUQJZsfp4aVkh58udpWy7FnvH53ImX1rg4G0?=
 =?us-ascii?Q?jTAsnw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e30cc47d-a0e3-4a81-70cb-08db68191360
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 12:08:31.3006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: obg3S/NX3YlhDhT58pK1t1663iR4WmA1uJxSRRP/ivfmcrdvnIeDhEHtJF5fQh+EOdsHmxqiEFLyyVHG97yOzHBh8K1W5B+34TYUoFQc45E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR13MB6428
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 07, 2023 at 01:59:53PM +0800, Jiaxun Yang wrote:
> MIPS Boston board, which is using MIPS_GENERIC kernel is using
> EG20T PCH and thus need this driver.
> 
> Dependency of PCH_GBE, PTP_1588_CLOCK_PCH is also fixed for
> MIPS_GENERIC.
> 
> Note that CONFIG_PCH_GBE is selected in arch/mips/configs/generic/
> board-boston.config for a while, some how it's never wired up
> in Kconfig.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> v2: Add PTP_1588_CLOCK_PCH dependency.
> 
> Netdev maintainers, is it possible to squeeze this tiny patch into
> fixes tree?

That question aside, this looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>