Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 14:30:10 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, kys@microsoft.com, haiyangz@microsoft.com,
        wei.liu@kernel.org, decui@microsoft.com,
        linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] net: hv_netvsc: Remove duplicated include in
 rndis_filter.c
Message-ID: <ZIHJ0pxnv63jGkuW@corigine.com>
References: <20230608080316.84203-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230608080316.84203-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sw4tA6th8gdGxLho9BhMA8w+IgbZ6eoAUbqA49YrLxfO3//2+wpwNO1nRmaM?=
 =?us-ascii?Q?taagZI76IVcecTPTfKr6zVh0+SghBhengHfzTcMvpPlOgtgMsjwcS441Oo8b?=
 =?us-ascii?Q?5xGZ7vv6kVIXukmq+dOCUewB86tv5EeeRCR/N+BmR7IwMb9C7PKdYhTA5C9M?=
 =?us-ascii?Q?88sHHV6jt0h4llUte8/LLtyGlvqNKqQRfeSvb9y+8+dFbhNrCzUF4Ot52jJA?=
 =?us-ascii?Q?yUTP381/xhH1A6Ygyktt6+BixFvr3xAGqy14h6fzcjNyLMoyGh8RR1WhM8ny?=
 =?us-ascii?Q?UOuxJo1nwsRnIlqG5MH1YvXi4MwylOqv9esbU6iBUlmz+j+Ph+LF1iwGq702?=
 =?us-ascii?Q?wTBuQVwgagHXcdUZQnSfB9DF5Oe93dWXQ+NUkGfMjbAJ3fXWBAWdcm6UD7Jq?=
 =?us-ascii?Q?InPekm0ljX+ks9touPh9cbPGG4ZVSPiFqBCHZX52oDwYSJ/SckMVpFNqXgm5?=
 =?us-ascii?Q?+gIFeaoxTnFVsSq4MqfwhLLH/4BSU9Io0iATHB/e+5yAqMLyt1vH84UspThz?=
 =?us-ascii?Q?Z7VnIMdaqdLOk+yzYkIlaYIoORjlLlgKatvnzGePaa1HtYkFZCkAhP+6g+XX?=
 =?us-ascii?Q?R4N90Kma1ufaiQfMiHtYRnwYh0X2F3z6MV9P4aH50kEZeSFddMxmcuXhkogm?=
 =?us-ascii?Q?uW2cpLrxlfvDUrJmkdfTCv2ocN41mdrH+pPo9ENI6NrQ0sDcdAuZ/9r0ClmY?=
 =?us-ascii?Q?nnWIwVHUPxDwmT6gk2rsUjP5ccc2PTggcauC79m7jYF9R9x7Il5Wy7xG2Zn7?=
 =?us-ascii?Q?gZQBtGOuATmpz554Vk5xuOVEKk8VbuvSy57xmNmlS67SSTFQt4WjFHLg3tqt?=
 =?us-ascii?Q?pZ8cjiUuFbo4A6p9pqgPBrCqvY1G1XsPeQ/f5QGgj12fJQBhbiTMlWL4kjTL?=
 =?us-ascii?Q?+Y6c155cGtyfbxFN1/wzAgExsSRZyQwb/CiprfWSTgpu4HDR4RI4q09Xn36B?=
 =?us-ascii?Q?7KvroHGpPzssy8l7mTCzz/xbDoOxrg1wO+aQLPkT+3SVFGfvN7MnDdi2G0vs?=
 =?us-ascii?Q?VXV2DjXDMX5eUyDwc1Ai1JoF2duK0bbU9vc6Ug3KS5rY6UG4rW1eKIOtTxcb?=
 =?us-ascii?Q?aQrYFcNtFLsWDXmOoJ1XYjWNFNelU+moYZDGC+BcLTXgo4q+pr0W3i1oW6lq?=
 =?us-ascii?Q?UjSVs3PzLDRAvI+8S8T8jns9zzoFeunqCm/K4KyH5qZkQ6i0R0fhFFuw0JLS?=
 =?us-ascii?Q?ZM1cLz1xZYYPLhzSgIWZtnWb8v+hiCQyak0ggpnosDVwpLBGbslbGA0HssR0?=
 =?us-ascii?Q?9yp6Vo7ny0AeW6QOuMo1DhUTvRWGokJEj4OZ0lRvh7dml3KcUeDmiQtprroS?=
 =?us-ascii?Q?FHZMcfCFZgBwXQ19Bbr8+8/y2eejEHEspR1GNLMKQVNtdb7Vn5MTwcZ9UUmz?=
 =?us-ascii?Q?xgoKS3UByRHOuAKIRK2vsYiQ+3rPS4rEob5Elye4zsZ+slqru8xrZhHRFRVD?=
 =?us-ascii?Q?egJRsgyo6kPBbFqC4Anm7lZdqoQIL4bWTNTqWA9KB0dsyf5Dnieuk8uT5ER3?=
 =?us-ascii?Q?o7o+59KDdbzVbVLY18RvcTYs6qJ3bbr54DQdiCcDhGORtt7x3Xf0qw1EAkoA?=
 =?us-ascii?Q?TQ96HPb5XPORh/gsem5s8TiTIcZiHoufDqnt1fnpwTwSSuMl1BjJ3q87VQRz?=
 =?us-ascii?Q?KraM7y9/3nsfvKkrxNT9uyfVdmnZ4KuNDeN+738AjUq06DLfhq05W5Tssib5?=
 =?us-ascii?Q?VQcZeQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1231e974-f3ec-47e1-2881-08db681c1db1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 12:30:17.1154
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EgLW48DTnoOA9U40tG8ze3MBJlrKhLrUwnYJ1a8DeZazhzUz8PJIdp2AEytW8HQ0oWGXXt1rUxYUHzgKy15aXqw7oMrnZlFiAGjPP1dXXNc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR13MB5209
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 08, 2023 at 04:03:16PM +0800, Yang Li wrote:
> ./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5462
> Fixes: 4cab498f33f7 ("hv_netvsc: Allocate rx indirection table size dynamically")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Hi Yang Li,

A few nits from my side;

1. The subject should include the target tree, in this case net-next.

	[PATCH net-next] ...

2. I don't think this needs a fixes tag: nothing was broken

I'm not sure this warrants a v2.
If you do decide to post a v2, please allow for 24h since
v1 was posted.

Link: https://kernel.org/doc/html/v6.3/process/maintainer-netdev.html

Lastly, I think at least one other similar change has been posted recently.
Please consider batching up such changes, say in groups of 10 patches,
and posting them as a patch-set.


The change itself seems fine to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> ---
>  drivers/net/hyperv/rndis_filter.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
> index af95947a87c5..ecc2128ca9b7 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -21,7 +21,6 @@
>  #include <linux/rtnetlink.h>
>  #include <linux/ucs2_string.h>
>  #include <linux/string.h>
> -#include <linux/slab.h>
>  
>  #include "hyperv_net.h"
>  #include "netvsc_trace.h"
> -- 
> 2.20.1.7.g153144c
> 
>