Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 14:22:00 +0100
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     Junhao He <hejunhao3@huawei.com>
CC:     <will@kernel.org>, <linux-kernel@vger.kernel.org>,
        <mark.rutland@arm.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-doc@vger.kernel.org>, <linuxarm@huawei.com>,
        <yangyicong@huawei.com>, <shenyang39@huawei.com>,
        <prime.zeng@hisilicon.com>
Subject: Re: [PATCH v3 2/3] drivers/perf: hisi: Add support for HiSilicon UC
 PMU driver
Message-ID: <20230608142200.0000753c@Huawei.com>
In-Reply-To: <20230608113719.27433-3-hejunhao3@huawei.com>
References: <20230608113719.27433-1-hejunhao3@huawei.com>
        <20230608113719.27433-3-hejunhao3@huawei.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 8 Jun 2023 19:37:18 +0800
Junhao He <hejunhao3@huawei.com> wrote:


> On HiSilicon Hip09 platform, there is 4 UC (unified cache) module

are 4 UC (unified cache) modules

> on each chip CCL (CPU Cluster). UC is a cache that provides
> coherence between NUMA and UMA domains. It is located between L2
> and Memory System. And many PMU events are supported. Let's support

Many PMU events are supported.

> the UC PMU driver using the HiSilicon uncore PMU framework.
> 
> * rd_req_en : rd_req_en is the abbreviation of read request tracetag
> enable and allows user to count only read operations. Details are listed
> in the hisi-pmu document at Documentation/admin-guide/perf/hisi-pmu.rst
> 
> * srcid_en & srcid: Allows users to filter statistical information based
> on specific CPU/ICL by srcid.
> srcid_en depending on rd_req_en enabled.

srcid_en depends on rd_req_en being enabled.

> 
> * uring_channel: Allows users to filter statistical information based on
> the specified tx request uring channel.
> uring_channel only supported events: [0x47 ~ 0x59].
> 
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
> Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>

The editorial stuff above is trivial and original text can be easily 
understood. So maintainers may not care. If you happen to be re rolling
the patch then nice to clean it up.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>