Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp839857rwd; Thu, 8 Jun 2023 08:24:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ470/igm+EvBxdKP9H+z6ydDsoextnziDyaI3G8+6i/SvgFOAg5jFisGkMt8e36pZGLwyzl X-Received: by 2002:a17:902:8f96:b0:1ae:14d:8d0a with SMTP id z22-20020a1709028f9600b001ae014d8d0amr7894637plo.29.1686237853935; Thu, 08 Jun 2023 08:24:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686237853; cv=none; d=google.com; s=arc-20160816; b=oTz/+cj8Jkpdzav1bqsNynUN0H6QXcSooPprWn1AqlgDf3wSmhNlOddlzm5bAKPVHz QDOaUfr3kJYElg9Odsc8/tfLaQzDk/4q+GhNU3enk9N4w+yr4R6zS26v4cyOXjgnM+67 UBk4Q8d8dhCbtB9VfGYKpyws2eEUoPCFB3ImfBVzyV44YTA2HmJlqOQ1FdqV+gIOEr+1 YTyvs7bFVT21zb3rt6k2oSlMhneNIj1DBPQ8p660QzDUbjJwDnBKah1GO73d+ABhPw4/ sV+c01OO8NcMWuDQDEHlyxrpqn3hWQblLJQdRiC71nwQiVqyubqbJpSheNPPJ5PWEcGD yfXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AIzYWklHV9yiDI7kxz0MuJTeiPCssttcUF/JaN5Cc0k=; b=pmAowU32m2GyfyQxBQbadQW3O7eiQRas5Vor08DTjisrXa4H8bK8zRRd6HsCvdOjAF 0jsAf4QZBbs9MiGqj2ByZPNTRVJPRhXcqFAD1ISwI6uWOfep47pHfgFm+1GwXPT03nDb i+rANobvao+F+I24zfgXniIu7i+ieNTDXCZhUCQN5WJjYxm7v+6KAID/CLczqNS36UrY l6NlWJ9HX5AeON4o2D60yrPVyGHK74hSiDvqeZ8PZwWPdij5G8HAzO1956YlUQBv6NCD Bwyw2ZRkvlSP5hQxnvOGSlBDTGNC2WiizsHw9Tl/wtGkBOOsQQLubUmFwmCDHGkeWDVW FyWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="OvWfhG/l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e12-20020a17090301cc00b001a6f91439d8si1195571plh.393.2023.06.08.08.24.01; Thu, 08 Jun 2023 08:24:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="OvWfhG/l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236671AbjFHO5M (ORCPT + 99 others); Thu, 8 Jun 2023 10:57:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235799AbjFHO5L (ORCPT ); Thu, 8 Jun 2023 10:57:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E63BD1FFE; Thu, 8 Jun 2023 07:57:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8389D6127C; Thu, 8 Jun 2023 14:57:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E811DC433D2; Thu, 8 Jun 2023 14:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686236230; bh=4jvw6/WUJ2q8p/bP+rspcHDv743jTfh1uzy4i5Wqk7w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OvWfhG/l9MbVzRBetNjpXEBfMnX1EyKf+/IuD4JN0cgRPPxsFV6okmgbTycWIcNpr mRhFL+JSe5PuRWXMaTVGtXXvR3WQqnB6Z0ZdcvrLFIbT98MFTVEU+ecMbl1rvUzIag RZVbsm2vwjNmXVw0HdCQFqbOm3kG4GmKcwyrZ5aa5/04xeRHfm+PcrrMBXs1M2HCTx uFmMaD3ALAK2AzeZ/5lydcwqeQpgH+JJzVFFyuB43zXlcSc8joA210eAFA2aEFNCET xVMs0f0ZvgDxT3b74X7L0KsVR1W2grswPWU3y7Rw/fDU1kJmIRsJSGhTjbuhsqvs3T F9+LCi6a+zhIw== Date: Thu, 8 Jun 2023 15:57:05 +0100 From: Lee Jones To: Tom Rix Cc: pavel@ucw.cz, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static Message-ID: <20230608145705.GN1930705@google.com> References: <20230530234748.3641630-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230530234748.3641630-1-trix@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 May 2023, Tom Rix wrote: > smatch reports > drivers/leds/leds-cht-wcove.c:144:21: warning: symbol > 'cht_wc_leds_brightness_get' was not declared. Should it be static? > > This function is only used in its defining file, so it should be static. > > Signed-off-by: Tom Rix > --- > drivers/leds/leds-cht-wcove.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sorry, you were pipped to the post: https://lore.kernel.org/r/20230525183317.129232-1-hdegoede@redhat.com -- Lee Jones [李琼斯]