Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp892283rwd; Thu, 8 Jun 2023 09:05:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5VKH50EztBx0Dt1kVJIUIRuArb5LHFH46R8OYr4qbgHvqc1Np7ijNlDVKXFXvKbPJjfP/r X-Received: by 2002:a05:6a00:80e:b0:663:14e2:fa0 with SMTP id m14-20020a056a00080e00b0066314e20fa0mr3088217pfk.8.1686240342999; Thu, 08 Jun 2023 09:05:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686240342; cv=none; d=google.com; s=arc-20160816; b=G62kHEYJm0slJvNOHfcI1wDGZQe7rS5Wd3hJB4wAmTFs0MQ7EYZa9lnipRWdMQW3b4 w3v6ib834LVsCTDS+UEb/Wo3GzxsvkujgSPpkptUn+HjtsArJwQjPMlhJdIohJ6avLOJ 5HungxNSN94cs5FiQOX4kdBppabJCx0XzNtvxYQPze1IhIntdMUhXH3Y9nlm1bzl5/nD dxbm+9jBTChaXks2RUTC5Tfhzx25PWCFW71/wA1iDtLzNamvYqs5l2ieTrFSfT/UNHkn OYqrveYPxFXdEKrRK3VGZ0lTPmlYEL2UG/KNVVB0+abfROC5o59zjKkSogv8xlYy/KSA xE1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=g/m6XNFvTOUfG03RZDOMzrTB4ATEHu4pMqVecpMcDjA=; b=tYq6wfu9dwTKDAglVScIVwAX3PVMyN1eozdzu9OmQgVocdEstChqmVveD7ZGuo9SOI 4s7fz1Tm5Ai2j4Lw4mSHNxAS6D40y14/PT22Oi2cI0prYTrLzYBRUkNA91ap+OQE6QS+ rkkuK6TcWqJIIyyr+/mYfuTqjlk9VeIqN3dhM+NLqjlILFup3eQefPXdOPVH1ABhBUPB VReqm1pfi6TY5sNQjrITtG6diCzujayMFZci6VUEwLlsWIOr3VgRmT8n8u6zdf29gcvR 97Jz/ll1OiPWihoU4LznKD29Oa9Sa2N44HARbOeT5qelOVseQs+rYYxCz+apr9sAayiC 7poQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=RB2lXyPB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y16-20020aa79e10000000b00652fd16325asi1024085pfq.218.2023.06.08.09.05.30; Thu, 08 Jun 2023 09:05:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=RB2lXyPB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237256AbjFHPoS (ORCPT + 99 others); Thu, 8 Jun 2023 11:44:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236585AbjFHPoK (ORCPT ); Thu, 8 Jun 2023 11:44:10 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D05F2D69 for ; Thu, 8 Jun 2023 08:43:44 -0700 (PDT) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id F290D3F36A for ; Thu, 8 Jun 2023 15:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1686239019; bh=g/m6XNFvTOUfG03RZDOMzrTB4ATEHu4pMqVecpMcDjA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RB2lXyPBazDFw+z18t6MQN0Mr90Ei3G+ZtYBxzCRhhi3dxlYtn5uHCunor/NvBEzx +IWGgn8+oXotj2rLTw8C16MgU/6yxavJIL3LMeQ6LcrB7s+gD/zrz62AS4zMtdF9rY 7ZjneORo8239/ULdI8obYeijOy0yIV5JIqm5Z2BJmYVdPdqocfH611mlhLg5ZAMaX0 5iqDqoQU6k0ZU9mHl+20ycuT0Mg6duXvfD/B2ZuAfCctLah+aum/I+LpE8viJJPW6c hYGObPAQ2IVyqIeemyYju8BFCmIeqvVC3Hl7w6bm3T97EhF7PLCbYGKCiHFncsnu/l IIa3hKcx90Jfw== Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-977cb78acfcso80506566b.3 for ; Thu, 08 Jun 2023 08:43:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686239019; x=1688831019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g/m6XNFvTOUfG03RZDOMzrTB4ATEHu4pMqVecpMcDjA=; b=bZ/ZdqPj9RrmB5mPFzxth1v7nfvBJB5VkMU3YafKIlp20/Dq2cf9DJBqMr2PEEHLxg JShdTV8PLF2F9vn/+XLd7H3rqTGvEYZxK8I47vKYKKD6nsK08wtl4Q+8Hx5ib4CLnBCp aOkUonLPVYu/teV0R+KKIhcCXU99YCm2qAbh9xZGYgQLPq3BE1uQ9B8pPWe4v3P8RYfm ID0Sy40+iUsvKS4FTNsIEdPnFuYqWcfjBnoHV/dVXzcvcbgzSbr7YEry7G2L2bGHjOBv /LEqnuR3Buek/3yWSy0sNQvblBCPrpfpfEADAJDW1sG4jFkrXnH2p3SMuTIaoaxN3diW Qa7g== X-Gm-Message-State: AC+VfDzzzxhHpQiLDmgf79WJzDN+4lgXmZb0jHhPnzOqSdhbAUDhbBJ7 mMdz6LT+r5XSEOxqgEJxKOpKnj15btpBSFwAvwkB7uL0b6rl5iwhS+bwEv7U9cgMI4i2EubTvRf LaaW2YsI5sjFKFAvLRMDT5iq7/WtivmZaN+n4qeTkPA== X-Received: by 2002:a17:907:74b:b0:978:a964:106e with SMTP id xc11-20020a170907074b00b00978a964106emr142674ejb.17.1686239019654; Thu, 08 Jun 2023 08:43:39 -0700 (PDT) X-Received: by 2002:a17:907:74b:b0:978:a964:106e with SMTP id xc11-20020a170907074b00b00978a964106emr142658ejb.17.1686239019513; Thu, 08 Jun 2023 08:43:39 -0700 (PDT) Received: from amikhalitsyn.local (dslb-002-205-064-187.002.205.pools.vodafone-ip.de. [2.205.64.187]) by smtp.gmail.com with ESMTPSA id y8-20020aa7c248000000b005164ae1c482sm678387edo.11.2023.06.08.08.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 08:43:39 -0700 (PDT) From: Alexander Mikhalitsyn To: xiubli@redhat.com Cc: brauner@kernel.org, stgraber@ubuntu.com, linux-fsdevel@vger.kernel.org, Jeff Layton , Ilya Dryomov , ceph-devel@vger.kernel.org, Alexander Mikhalitsyn , linux-kernel@vger.kernel.org Subject: [PATCH v5 07/14] ceph: pass idmap to __ceph_setattr Date: Thu, 8 Jun 2023 17:42:48 +0200 Message-Id: <20230608154256.562906-8-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230608154256.562906-1-aleksandr.mikhalitsyn@canonical.com> References: <20230608154256.562906-1-aleksandr.mikhalitsyn@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just pass down the mount's idmapping to __ceph_setattr, because we will need it later. Cc: Xiubo Li Cc: Jeff Layton Cc: Ilya Dryomov Cc: brauner@kernel.org Cc: ceph-devel@vger.kernel.org Signed-off-by: Alexander Mikhalitsyn --- fs/ceph/acl.c | 4 ++-- fs/ceph/inode.c | 6 ++++-- fs/ceph/super.h | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c index 6945a938d396..51ffef848429 100644 --- a/fs/ceph/acl.c +++ b/fs/ceph/acl.c @@ -140,7 +140,7 @@ int ceph_set_acl(struct mnt_idmap *idmap, struct dentry *dentry, newattrs.ia_ctime = current_time(inode); newattrs.ia_mode = new_mode; newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; - ret = __ceph_setattr(inode, &newattrs); + ret = __ceph_setattr(idmap, inode, &newattrs); if (ret) goto out_free; } @@ -151,7 +151,7 @@ int ceph_set_acl(struct mnt_idmap *idmap, struct dentry *dentry, newattrs.ia_ctime = old_ctime; newattrs.ia_mode = old_mode; newattrs.ia_valid = ATTR_MODE | ATTR_CTIME; - __ceph_setattr(inode, &newattrs); + __ceph_setattr(idmap, inode, &newattrs); } goto out_free; } diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index 37e1cbfc7c89..bface707c9bb 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -2009,7 +2009,8 @@ static const struct inode_operations ceph_symlink_iops = { .listxattr = ceph_listxattr, }; -int __ceph_setattr(struct inode *inode, struct iattr *attr) +int __ceph_setattr(struct mnt_idmap *idmap, struct inode *inode, + struct iattr *attr) { struct ceph_inode_info *ci = ceph_inode(inode); unsigned int ia_valid = attr->ia_valid; @@ -2206,6 +2207,7 @@ int __ceph_setattr(struct inode *inode, struct iattr *attr) if (mask) { req->r_inode = inode; ihold(inode); + req->r_mnt_idmap = mnt_idmap_get(idmap); req->r_inode_drop = release; req->r_args.setattr.mask = cpu_to_le32(mask); req->r_num_caps = 1; @@ -2252,7 +2254,7 @@ int ceph_setattr(struct mnt_idmap *idmap, struct dentry *dentry, ceph_quota_is_max_bytes_exceeded(inode, attr->ia_size)) return -EDQUOT; - err = __ceph_setattr(inode, attr); + err = __ceph_setattr(idmap, inode, attr); if (err >= 0 && (attr->ia_valid & ATTR_MODE)) err = posix_acl_chmod(&nop_mnt_idmap, dentry, attr->ia_mode); diff --git a/fs/ceph/super.h b/fs/ceph/super.h index d24bf0db5234..d9cc27307cb7 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h @@ -1052,7 +1052,8 @@ static inline int ceph_do_getattr(struct inode *inode, int mask, bool force) } extern int ceph_permission(struct mnt_idmap *idmap, struct inode *inode, int mask); -extern int __ceph_setattr(struct inode *inode, struct iattr *attr); +extern int __ceph_setattr(struct mnt_idmap *idmap, struct inode *inode, + struct iattr *attr); extern int ceph_setattr(struct mnt_idmap *idmap, struct dentry *dentry, struct iattr *attr); extern int ceph_getattr(struct mnt_idmap *idmap, -- 2.34.1