Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230607180958.645115-1-aleksandr.mikhalitsyn@canonical.com>
 <20230607180958.645115-12-aleksandr.mikhalitsyn@canonical.com> <f1e81edf-595b-3f7c-3f00-2c96718fbb69@redhat.com>
In-Reply-To: <f1e81edf-595b-3f7c-3f00-2c96718fbb69@redhat.com>
From:   Aleksandr Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Date:   Thu, 8 Jun 2023 17:46:26 +0200
Message-ID: <CAEivzxeH1rBezS=+gMaEg4_2A9jweLgW7CCc7paaa=MRhh3VXQ@mail.gmail.com>
Subject: Re: [PATCH v4 11/14] ceph: allow idmapped setattr inode op
To:     Xiubo Li <xiubli@redhat.com>
Cc:     brauner@kernel.org, stgraber@ubuntu.com,
        linux-fsdevel@vger.kernel.org,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Jeff Layton <jlayton@kernel.org>,
        Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 8, 2023 at 4:50=E2=80=AFAM Xiubo Li <xiubli@redhat.com> wrote:
>
>
> On 6/8/23 02:09, Alexander Mikhalitsyn wrote:
> > From: Christian Brauner <christian.brauner@ubuntu.com>
> >
> > Enable __ceph_setattr() to handle idmapped mounts. This is just a matte=
r
> > of passing down the mount's idmapping.
> >
> > Cc: Xiubo Li <xiubli@redhat.com>
> > Cc: Jeff Layton <jlayton@kernel.org>
> > Cc: Ilya Dryomov <idryomov@gmail.com>
> > Cc: ceph-devel@vger.kernel.org
> > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> > [ adapted to b27c82e12965 ("attr: port attribute changes to new types")=
 ]
> > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.c=
om>
> > ---
> > v4:
> >       - introduced fsuid/fsgid local variables
> > v3:
> >       - reworked as Christian suggested here:
> >       https://lore.kernel.org/lkml/20230602-vorzeichen-praktikum-f17931=
692301@brauner/
> > ---
> >   fs/ceph/inode.c | 20 ++++++++++++--------
> >   1 file changed, 12 insertions(+), 8 deletions(-)
> >
> > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> > index bcd9b506ec3b..ca438d1353b2 100644
> > --- a/fs/ceph/inode.c
> > +++ b/fs/ceph/inode.c
> > @@ -2052,31 +2052,35 @@ int __ceph_setattr(struct mnt_idmap *idmap, str=
uct inode *inode,
> >       dout("setattr %p issued %s\n", inode, ceph_cap_string(issued));
> >
> >       if (ia_valid & ATTR_UID) {
> > +             kuid_t fsuid =3D from_vfsuid(idmap, i_user_ns(inode), att=
r->ia_vfsuid);
> > +
> >               dout("setattr %p uid %d -> %d\n", inode,
> >                    from_kuid(&init_user_ns, inode->i_uid),
> >                    from_kuid(&init_user_ns, attr->ia_uid));
> >               if (issued & CEPH_CAP_AUTH_EXCL) {
> > -                     inode->i_uid =3D attr->ia_uid;
> > +                     inode->i_uid =3D fsuid;
> >                       dirtied |=3D CEPH_CAP_AUTH_EXCL;
> >               } else if ((issued & CEPH_CAP_AUTH_SHARED) =3D=3D 0 ||
> > -                        !uid_eq(attr->ia_uid, inode->i_uid)) {
> > +                        !uid_eq(fsuid, inode->i_uid)) {
> >                       req->r_args.setattr.uid =3D cpu_to_le32(
> > -                             from_kuid(&init_user_ns, attr->ia_uid));
> > +                             from_kuid(&init_user_ns, fsuid));
> >                       mask |=3D CEPH_SETATTR_UID;
> >                       release |=3D CEPH_CAP_AUTH_SHARED;
> >               }
> >       }
> >       if (ia_valid & ATTR_GID) {
> > +             kgid_t fsgid =3D from_vfsgid(idmap, i_user_ns(inode), att=
r->ia_vfsgid);
> > +
> >               dout("setattr %p gid %d -> %d\n", inode,
> >                    from_kgid(&init_user_ns, inode->i_gid),
> >                    from_kgid(&init_user_ns, attr->ia_gid));
> >               if (issued & CEPH_CAP_AUTH_EXCL) {
> > -                     inode->i_gid =3D attr->ia_gid;
> > +                     inode->i_gid =3D fsgid;
> >                       dirtied |=3D CEPH_CAP_AUTH_EXCL;
> >               } else if ((issued & CEPH_CAP_AUTH_SHARED) =3D=3D 0 ||
> > -                        !gid_eq(attr->ia_gid, inode->i_gid)) {
> > +                        !gid_eq(fsgid, inode->i_gid)) {
> >                       req->r_args.setattr.gid =3D cpu_to_le32(
> > -                             from_kgid(&init_user_ns, attr->ia_gid));
> > +                             from_kgid(&init_user_ns, fsgid));
> >                       mask |=3D CEPH_SETATTR_GID;
> >                       release |=3D CEPH_CAP_AUTH_SHARED;
> >               }
> > @@ -2241,7 +2245,7 @@ int ceph_setattr(struct mnt_idmap *idmap, struct =
dentry *dentry,
> >       if (ceph_inode_is_shutdown(inode))
> >               return -ESTALE;
> >
> > -     err =3D setattr_prepare(&nop_mnt_idmap, dentry, attr);
> > +     err =3D setattr_prepare(idmap, dentry, attr);
> >       if (err !=3D 0)
> >               return err;
> >
> > @@ -2256,7 +2260,7 @@ int ceph_setattr(struct mnt_idmap *idmap, struct =
dentry *dentry,
> >       err =3D __ceph_setattr(idmap, inode, attr);
> >
> >       if (err >=3D 0 && (attr->ia_valid & ATTR_MODE))
> > -             err =3D posix_acl_chmod(&nop_mnt_idmap, dentry, attr->ia_=
mode);
> > +             err =3D posix_acl_chmod(idmap, dentry, attr->ia_mode);
> >
> >       return err;
> >   }

Hi Xiubo,

>
> You should also do 'req->r_mnt_idmap =3D idmap;' for sync setattr request=
.
>
> the setattr will just cache the change locally in client side if the 'x'
> caps are issued and returns directly or will set a sync setattr reqeust.

Have done in v5:
("ceph: pass idmap to __ceph_setattr")
https://lore.kernel.org/lkml/20230608154256.562906-8-aleksandr.mikhalitsyn@=
canonical.com/

Kind regards,
Alex

>
> Thanks
>
> - Xiubo
>