Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp920215rwd; Thu, 8 Jun 2023 09:25:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Mf2EIgZdUXrbRW9KQMHFWikrQeCRt67oUgppQEGfeX3aEC8fRsXQG7LvIsOats0u0yOZv X-Received: by 2002:a17:90a:f986:b0:259:bf40:b571 with SMTP id cq6-20020a17090af98600b00259bf40b571mr5490824pjb.45.1686241519587; Thu, 08 Jun 2023 09:25:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686241519; cv=none; d=google.com; s=arc-20160816; b=FaUfRlYHTmOUfpQH/CQS3g/BKj9r7xU8oFSOrABv+BzuYtJxfBtCN2v7rosczRUNIg ye1FgJXC7/0qDVEO5Gp/Tuf5qREK1ENuCucKnIIQQVZzCjSk4Dt5v3R7j7x4Wt1D3eVt 1NmbadhYfHfI/VDMQ4cBduZYQriUOO3HcUQRlqmFd7aIcL8/U0JLhGv+ROiq9cW7xK3p W4f/ragVbmze7o5DXaSjcDZbyCmIY/tVp0wMfuGmrE7n3t+qVzgREpbCfRuvHcJ9t568 P0l9hMt6piXAX1ox2uNjSDIFnT+LiF4Tm8j3Q8grs0danHK4Y5Zir6D9TN+6Yv+H46yz fktA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:references:cc:to:content-language:subject:reply-to :from:user-agent:mime-version:date:message-id:dkim-signature; bh=7N0Me9LjM46FYnisAvuqmrgrl7WoCTNWh45Ff6Fxt+8=; b=zorJCGSHWcxt9+wBsUtldw8ZRrUQ9LWPWitLziicw+0oje+0cZOgEyU8xNPWck/Uz4 cZt5rMK9uwosUYRCLQEe76ctcWl2c+8IezajyOg1vhf5Xrp9p1IzE5527mOzNIQTAYV0 yElp4SnBwWk8g8LKdUvsM9t33i3UdNGRrZpB00OYrnli6w03lc/6FsEJAGFcfzJR3nQl sWnYC0xYnRxhqgbA4uRKpSzpe6nZcuGTqzMczPzhUiMjIIJ6xnKqOLvOcoStwZ0put9f 1EYB5Cgk63XFFzdPyOZvIzNEXGW+GZdKGi1XdLLvbAzq/NkCZc/TG8zHCedlNskHXdu2 FwCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gttB8sY1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m75-20020a633f4e000000b0053482b814b0si1176275pga.296.2023.06.08.09.25.05; Thu, 08 Jun 2023 09:25:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gttB8sY1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231611AbjFHQC0 (ORCPT + 99 others); Thu, 8 Jun 2023 12:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231830AbjFHQB6 (ORCPT ); Thu, 8 Jun 2023 12:01:58 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5373C30E8 for ; Thu, 8 Jun 2023 09:01:27 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-307d20548adso597212f8f.0 for ; Thu, 08 Jun 2023 09:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686240086; x=1688832086; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=7N0Me9LjM46FYnisAvuqmrgrl7WoCTNWh45Ff6Fxt+8=; b=gttB8sY1m+B86ejkha7nAJU1n0KqrIOK7/sE/rRK+25H1UZieT+zsdO+0rbQsLvd8c I5Wg1cN1mXR6dwl9pV1manGgh6gIXrJ5ejHXFmNhNlK/GwIbcCHiQ4Nol+lvAiZ3Nz/6 IUIodkLs1oL6rJ1BrAJee2TSfDWhch7w+c/l6diK2u07lhMSpEMzoBn7zgHBxyNLbtVO 9krXCIXohBCU0mTJKeVMEoeBhr5PZwHzxlx+2hTEK2V0qawxe5iorOerjQrPdYuT0POs ScbIiHt6M8pjMZUAiz8KlXmLcrq0QAoRHXzQb4VKx/QBUsUWp6OKjqBFlNaFdkGhEYf/ dy8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686240086; x=1688832086; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7N0Me9LjM46FYnisAvuqmrgrl7WoCTNWh45Ff6Fxt+8=; b=MjjwVpHSixLZbkfoUcQc3yIg7didCpCiX/nthT+K4WR2By+djcQjRhHY5Zmpv6FVV3 FS4XZ6PQj//UiacwCNoRVZDQa6jYqg/wfzjq9IzhOXetnhFgEIVNt/B3pUtIwr707Ebx BeTJdLGF+X6a0aODoHDoPbFPT4PVljaoBecnTC3txhcE9+TBRWiPavFKL0aPakX15fze 40eBvXgy1pphP6nIQ2EFwfrANtr7IHkKwLd6JsqzW2UW9fEHIGBoKUycKEQzQ485rWI/ Zc6Blu2qRSXDoDg9yAkaDtGYw4CsFs5cjpyNU3xqufEi2FGdVZld1wOKFWOhNO6Doz08 /bEQ== X-Gm-Message-State: AC+VfDzPz7CHixczAgboAJokedJn7IeQXmKHkWTMtxLtunisrqSLPlpK bUt9jdoC0xey0zbgHMhdi2lEpQ== X-Received: by 2002:a05:6000:108f:b0:306:2fab:1f81 with SMTP id y15-20020a056000108f00b003062fab1f81mr6925306wrw.21.1686240085766; Thu, 08 Jun 2023 09:01:25 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:1b90:b83e:29ce:beb6? ([2a01:e0a:982:cbb0:1b90:b83e:29ce:beb6]) by smtp.gmail.com with ESMTPSA id t12-20020adfe10c000000b00307acec258esm1975127wrz.3.2023.06.08.09.01.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 09:01:25 -0700 (PDT) Message-ID: <817a8764-45ac-74a8-935f-69d32d68f5fc@linaro.org> Date: Thu, 8 Jun 2023 18:01:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 0/2] Add support for Visionox R66451 AMOLED DSI panel Content-Language: en-US To: Jessica Zhang , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski Cc: Abhinav Kumar , Marijn Suijten , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, Krzysztof Kozlowski References: <20230516-b4-r66451-panel-driver-v2-0-9c8d5eeef579@quicinc.com> Organization: Linaro Developer Services In-Reply-To: <20230516-b4-r66451-panel-driver-v2-0-9c8d5eeef579@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 31/05/2023 20:12, Jessica Zhang wrote: > Add support for the 1080x2340 Visionox R66451 AMOLED DSI panel that > comes with the Qualcomm HDK8350 display expansion pack. > > The driver will come with display compression (DSC v1.2) enabled by > default. > > Signed-off-by: Jessica Zhang > --- > Changes in v2: > - Reworded panel bindings commit message for brevity (Krzysztof) > - Used corresponding *_set_column_address() and *_set_page_address() DCS > helper methods (Dmitry) > - Moved *_set_display_[on|off]() and *_[exit|enter]_sleep_mode() calls > into _enable() and _disable(), respectively (Dmitry) > - Dropped cpu_to_le16() conversion for > mipi_dsi_dcs_set_display_brightness() (Dmitry) > - Unset LPM flag after DCS commands are sent in _on() (Dmitry) > - Used real numbers for mode values (Dmitry) > - Used drm_connector_helper_get_modes_fixed() in get_modes() (Dmitry) > - Added BACKLIGHT_CLASS_DEVICE as a Kconfig dependency (Neil) > - Added error handling for mipi_dsi_picture_parameter_set() (Marijn) > - Dropped "0x" for dcs->bits_per_pixel value (Marijn) > - Link to v1: https://lore.kernel.org/r/20230516-b4-r66451-panel-driver-v1-0-4210bcbb1649@quicinc.com > > --- > Jessica Zhang (2): > dt-bindings: display: panel: Add Visionox R66451 AMOLED DSI panel > drm/panel: Add driver for Visionox r66451 panel > > .../bindings/display/panel/visionox,r66451.yaml | 59 ++++ > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-visionox-r66451.c | 390 +++++++++++++++++++++ > 4 files changed, 459 insertions(+) > --- > base-commit: a5abc0900af0cfb1b8093200a265d2791864f26b > change-id: 20230516-b4-r66451-panel-driver-bf04b5fb3d52 > > Best regards, Applied to drm-misc-next Neil