Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fd3e3174-a2cd-9cd1-d04a-cd82a07977b7@ti.com>
Date:   Thu, 8 Jun 2023 21:30:51 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v3 5/5] arm64: dts: ti: k3-j7200-common-proc-board: Add
 uart pin mux in wkup_pmx0
To:     Nishanth Menon <nm@ti.com>
CC:     <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <conor+dt@kernel.org>, <m-chawdhry@ti.com>, <n-francis@ti.com>
References: <20230604045525.1889083-1-u-kumar1@ti.com>
 <20230604045525.1889083-6-u-kumar1@ti.com>
 <20230606120959.r4pnxuigknl7qkjr@outpour>
Content-Language: en-US
From:   "Kumar, Udit" <u-kumar1@ti.com>
In-Reply-To: <20230606120959.r4pnxuigknl7qkjr@outpour>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks Nishanth

On 6/6/2023 5:39 PM, Nishanth Menon wrote:
> On 10:25-20230604, Udit Kumar wrote:
>> Add uart pin mux of wkup domain into common board file.
>>
>> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
>> ---
>>   .../dts/ti/k3-j7200-common-proc-board.dts     | 22 ++++++++++++++++++-
>>   1 file changed, 21 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> index e12d93f56c51..809d1c910015 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>> @@ -79,6 +79,24 @@ vdd_sd_dv: gpio-regulator-TLV71033 {
>>   	};
>>   };
>>   
>> [..]
> Could you add the pins to wkup_uart0 node as well?
>
>> +		pinctrl-single,pins = <
>> +			J721E_WKUP_IOPAD(0xb0, PIN_INPUT, 0) /* (B14) WKUP_UART0_RXD */
>> +			J721E_WKUP_IOPAD(0xb4, PIN_OUTPUT, 0) /* (A14) WKUP_UART0_TXD */
>> +		>;
>> +	};
>> +};
> We are also missing pinmux for main_uart1 and main_uart2


I will address missing pin mux in next version

> [..]