Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp934019rwd; Thu, 8 Jun 2023 09:35:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ665UiI8qZdq/5GOM7v/dZbpM2v5kCeFmHhPTTS4UuhTV0z9POyltfrvYwC2pnslmPQURIM X-Received: by 2002:a05:6a20:9384:b0:105:53:998 with SMTP id x4-20020a056a20938400b0010500530998mr4730787pzh.12.1686242156768; Thu, 08 Jun 2023 09:35:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686242156; cv=none; d=google.com; s=arc-20160816; b=lFJ1WtEpTNCbcR+JlPnJBDY5T/qPAn1AFyG+LWUVfqj8kTUopEnjDcyo2sDj8crfdZ H96CKd4PbAPukvRjlandI+AcYGN/PPxIyE5k4xnpAqsiZfjgW6hxUN5zwGLXO/ugTrgY GTaZ+fzs47OJYRsIDPTWo66KCcm6wShRS1fxYSIxWww09zda1kt34rULR0yb88L8ckvc 28w+Qh5ueRECCHz5BeoNUhTW5NHDa2NPxOxJX7nTC+3CrzRttd1sRu7QYQ/rNGYSX78u yJ6gSuiCvndGq3OHlNaRb0rKWltSk8fSPND7L+qvdzdwiOOt6v4eduQAmb0ENUBE0OvV SxDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=tFKP61ebX9P67TSKJfYCIn58dEl3OxqxlkKMfh6il8w=; b=qA4bdTpTqlipp0BejLnmmQjZxI/p/eFGVp/9m6i+Y0NSCYuYGBfl9E6mCKJHmE6UKj DppjFN1MD0BfFgpOMv+RnwlefA1sWpYxDqDLn5SbqJfHdmUICwILQ64uPNPmjvO48dqd T2c1Cn9I5RMzy2HCMNt5W4Zlux8YfQA4dn+iFl+oOQ5mBQyOPccrGEohbXsIlm4/II6x Fi/majCQBxSFXtM2kbH6YPjh/hW7zpCNPUR1ylVC7HsarDXkeEa5iptHt1gQO7jseEV+ DokYuI7Sr0t0MqOr32sQcdWL04UF+W78ebBqUgLowhGWqWYUPji/1KcPCpmqjUhjTIM3 4OPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GJq5TyBw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j28-20020a637a5c000000b0053413a82947si1155028pgn.447.2023.06.08.09.35.43; Thu, 08 Jun 2023 09:35:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GJq5TyBw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231336AbjFHQZb (ORCPT + 99 others); Thu, 8 Jun 2023 12:25:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233679AbjFHQZ0 (ORCPT ); Thu, 8 Jun 2023 12:25:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DDAB2711 for ; Thu, 8 Jun 2023 09:25:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E6DEA64E9D for ; Thu, 8 Jun 2023 16:25:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58470C433EF; Thu, 8 Jun 2023 16:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686241509; bh=h1kBxLorPIU5PBDes0GulA99549cBEyy7lMp58JWQXw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=GJq5TyBwdDPvaJv8lZ9wwbQvIE+7hIt36nRxZl6r2vkhCUQSJ2AyKfxpyMb6DOubv pugf4v4m00tBz3Ygm1R0GccU3GqXI3sKj42eFYVqiOmnWgCWb5z6EKyk3ZcSn7xir6 +hxsaU5+u5GBF7+J+7p+rJl7DRsYwARmVDjpihoHb8Au7nG/8IuWXroxdcWQTpIsAt wFrKDlpQQ/3a9IPlsRaTG0WazRO6Sce0DjDuPeN8toBW7FCj+UFGBqaCCGO6iV6Vhs iQlxyj53171k6xjKNFI1yUNfFpG1Bjr3qWCKD/7zxplEpts7chj6HLcJxfUBJuhq2P tzwcttFHHCCgQ== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id E809FCE14DD; Thu, 8 Jun 2023 09:25:08 -0700 (PDT) Date: Thu, 8 Jun 2023 09:25:08 -0700 From: "Paul E. McKenney" To: Chris Bainbridge Cc: Feng Tang , tglx@linutronix.de, sboyd@kernel.org, LKML Subject: Re: PROBLEM: skew message does not handle negative ns skew Message-ID: <41b91385-8f04-4498-9eeb-0b3a192b55cb@paulmck-laptop> Reply-To: paulmck@kernel.org References: <86521835-f13f-4d43-9a38-9a55abae0b89@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 10:41:51AM +0100, Chris Bainbridge wrote: > On Wed, 7 Jun 2023 at 20:04, Paul E. McKenney wrote: > > > > That is a bit user-unfriendly. Does the following fix address this > > issue at your end? > > [ 2.095149] clocksource: timekeeping watchdog on CPU3: Marking > clocksource 'tsc' as unstable because the skew is too large: > [ 2.095152] clocksource: 'hpet' wd_nsec: > 515998611 wd_now: 1c29fb9 wd_last: 151e3b8 mask: ffffffff > [ 2.095154] clocksource: 'tsc' cs_nsec: > 515124524 cs_now: 8af4c89f9 cs_last: 874f8e80b mask: ffffffffffffffff > [ 2.095155] clocksource: Clocksource 'tsc' > skewed -874087 ns (0 ms) over watchdog 'hpet' interval of 515998611 ns > (515 ms) Very good, thank you! May I please apply your Tested-by? Thanx, Paul