Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 17:38:12 +0100
From:   Lee Jones <lee@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     pavel@ucw.cz, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] leds: cht-wcove: Fix an unsigned comparison which
 can never be negative
Message-ID: <20230608163812.GC3572061@google.com>
References: <20230531020238.102684-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230531020238.102684-1-yang.lee@linux.alibaba.com>
Precedence: bulk

On Wed, 31 May 2023, Yang Li wrote:

> The return value from the call to cht_wc_leds_find_freq() is int.
> However, the return value is being assigned to an unsigned
> int variable 'ctrl', so making it an int.
> 
> Eliminate the following warning:
> drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/leds/leds-cht-wcove.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]