Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 18:14:29 +0100
From:   Lee Jones <lee@kernel.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: Add missing check for
 platform_get_resource
Message-ID: <20230608171429.GF3572061@google.com>
References: <20230531100257.17769-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230531100257.17769-1-jiasheng@iscas.ac.cn>
Precedence: bulk

On Wed, 31 May 2023, Jiasheng Jiang wrote:

> Add the missing check for platform_get_resource and return error
> if it fails.
> 
> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/mfd/intel-lpss-acpi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c
> index a143c8dca2d9..1a6ebd3d9795 100644
> --- a/drivers/mfd/intel-lpss-acpi.c
> +++ b/drivers/mfd/intel-lpss-acpi.c
> @@ -183,6 +183,9 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	info->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!info->mem)
> +		return -ENOMEM;

This does not mean we're out of memory.

Please use either -EINVAL or -ENODEV.

> +
>  	info->irq = platform_get_irq(pdev, 0);
>  
>  	ret = intel_lpss_probe(&pdev->dev, info);
> -- 
> 2.25.1
> 

-- 
Lee Jones [李琼斯]