Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 18:13:08 +0100
From:   Lee Jones <lee@kernel.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     pavel@ucw.cz, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] leds: flash: leds-qcom-flash: Fix an unsigned comparison
 which can never be negative
Message-ID: <20230608171308.GE3572061@google.com>
References: <20230531053559.5702-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230531053559.5702-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

On Wed, 31 May 2023, Jiapeng Chong wrote:

> The variable 'count' is defined as unsigned type, so the following if
> statement is invalid, we can modify the type of count to int.
> if (count <= 0) {
> 	dev_err(dev, "No led-sources specified\n");
> 	return -ENODEV;
> }
> 
> ./drivers/leds/flash/leds-qcom-flash.c:546:5-10: WARNING: Unsigned expression compared with zero: count <= 0.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5344
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/leds/flash/leds-qcom-flash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]