Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1009900rwd; Thu, 8 Jun 2023 10:39:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6g16jX+n5OEka3YUGztQ+iua9MzYan68jELNjBo1mp4ldmID/Hoy8UmK68M77nTLKg6Doq X-Received: by 2002:a05:6359:205:b0:128:35ec:587c with SMTP id ej5-20020a056359020500b0012835ec587cmr5019540rwb.4.1686245953696; Thu, 08 Jun 2023 10:39:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686245953; cv=none; d=google.com; s=arc-20160816; b=JUGZ7uhuRwMgWBkmZtOgqCYxWe0lYgDscyl+wvfPkCFWz9ivyhr6ffJ25cLMnL9Ls0 F0LPZCEloLj6VBp1QuQLHCIOKfVLIn4C+hHHuXQ05P9/oahtZGOZAioG95Ut/2VI0qxe 6ScCKWX2s0T4SeBbwCrm2/+MbZzvgREnGaju1kHpyA7vPZpDXEVffS6g2gHM5Fkxoq5o e0pE4+OgVzE0gfqeiAK1c0kpA8ILbdE4ecqYMd65wdFwbbBao8vesd3ozQutwfYcP8Oq dM74+MpnRqkhpCF9PL68Q7uQVWgE1ZrezaaUAycyfs8It2/IT3dRrdfKEh1yDgrMqM6G 05ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4fL0Iz+84Of2O6uQDrbf5spT+baeh+BNFvEIQUNU+S0=; b=F5y64Lo79RTtt00aDxGxOW4yg+yNr3Z5NVDO9dRh1d1+Xxhk/EutoprzIOtPgRiQiZ qGb4rmMYtPvItbRkYSjgHMGfrVoIFs0PHIp/QVr1WTgPd0c6LNc77M/aSS4327XWSuIG 2evPBE8epjlGpjjKLU5jiOheOsY5JL2T6ElZjReMZeOc5fjnmlGaYL2TgihxOyopwq4j uOWLkZ+i6iJRiVEoJ1pMM5cSxIsSqyH8ERWA9fG9V+z0B5QkI4yAnwa+xG+EmG27ORXS VIBB6D4lU/rcgFSVpcDfu7WRtZptGRflNG1OCI7zmL250C14teN909BlbNVqoQJQDNg0 KHUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sdXJxjHO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z12-20020a63b90c000000b0053ff2ca1b24si1195552pge.843.2023.06.08.10.38.57; Thu, 08 Jun 2023 10:39:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sdXJxjHO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235456AbjFHR0h (ORCPT + 99 others); Thu, 8 Jun 2023 13:26:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231459AbjFHR0e (ORCPT ); Thu, 8 Jun 2023 13:26:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57DAE1BDF; Thu, 8 Jun 2023 10:26:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E73C264FC5; Thu, 8 Jun 2023 17:26:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABECBC433EF; Thu, 8 Jun 2023 17:26:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686245193; bh=4MtA9tsIyCjcE08STEz2lRLmjFCiwKtdTt5WhNYC+1s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sdXJxjHOWhZWznr2tnKWoFBVwvx7MsQXFy4l9K8zGZ0w6WuldAeL2Q8DSJVfh6que UzPYJhKosKvVRNs3bRtXiK8Ivfm5Ro9Vbhxh+qbEvwm/J5dDgCwsi2ioeSDyjAyb/x X6xmVyVJsqd1GYMNOBID2Q1Ob7HF2RWtCrfkGpIK01mTAdZ8C8ZBkxb5KtEoheo32n bbWhrIA/Gm0DNZ4OvUZ8EhKWkd9ufdGTK5v++946Erm/UTinB0c8hSTfQGMZFP992h 2LiUQbFw1QdMmEGr3mBfCbO+sJVBV9jTXmUaty51O3OQ6PsTHpBIEomH99BMqBZ879 jHwgxy79tQCfA== Date: Thu, 8 Jun 2023 18:26:28 +0100 From: Lee Jones To: Henning Schild Cc: Pavel Machek , Hans de Goede , Mark Gross , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v4 2/4] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table Message-ID: <20230608172628.GI3572061@google.com> References: <20230524124628.32295-1-henning.schild@siemens.com> <20230524124628.32295-3-henning.schild@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230524124628.32295-3-henning.schild@siemens.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 May 2023, Henning Schild wrote: > There are two special pins needed to init the LEDs. We used to have them > at the end of the gpiod_lookup table to give to "leds-gpio". A cleaner > way is to have a dedicated table for the special pins. > > Signed-off-by: Henning Schild > --- > drivers/leds/simple/simatic-ipc-leds-gpio.c | 28 ++++++++++++++++++--- > 1 file changed, 25 insertions(+), 3 deletions(-) Applied, thanks -- Lee Jones [李琼斯]