Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1011147rwd; Thu, 8 Jun 2023 10:40:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ57cpCGHXAnWEScpW3k3omPB2puhCQpRSHwn8knEzlVtmb5APpEzL0nezeHyk8cd1PjaKUj X-Received: by 2002:a05:6a21:6d8d:b0:10b:58f1:7a6f with SMTP id wl13-20020a056a216d8d00b0010b58f17a6fmr8243491pzb.41.1686246024768; Thu, 08 Jun 2023 10:40:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686246024; cv=none; d=google.com; s=arc-20160816; b=s8N+8Y9rD7ykZsXhDAFZFqTH6wfAnbpc/n6QdkO28obCrPQSmFUg+2sNDCf05IYFCZ KS5WHvN5XKYBSnHc/V2836uPmZksxIOvHxcsMXEGmzPRBSQTE49jqfwmErT9/jJxoPg5 pEeaEj+Hxt1pb/DiqQg3jL0FfNZaBRBAJX3pNJnum5fgECmboM8tVpf2SficBbQ85GFW YHkD3gCK+CyxT0Ck53WxKArtk2m9PWCr8qEyKhRY02WHe9ftOz7fwWcCJwT7/J3gK7On 0yN+13rdQbbBnLlZXxGVN6LPyaYWa15st7kGFl9htNYSwsR0ix/gxWGYBf9/BFvK6rr2 1ngQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ptgC8i0J1xaYqu3AD6TAukaI2G/R9Bvw3147dpgN3Zk=; b=D7yKDZqMnbLMWQCuRoqpwXOtROqY2OPutBByhGVZKDAowqTvx5kfZseBGVKxG+oyUD Y1g01c2f6LnAv33hvh75gceZ5R42o487Vft4HpwMGhDMutm6mEpoXt4ETMq4dxUHGmig G/BK4g48ETiZrP0BIUgd197QO6jMx1Ruc7XqOF9eaC+gR9T6xOmb2tGioWwQlYie19Yc Z4GIQBLFYPyaVytZtRavomirGAw4p44gc0eLhpvtm5ZpqdeIDxR/Z0cZPhyjL0ZChXf1 ltjYIOCT0uWpDgkC3NlEmS49rZFC1iuqc63WztWoUBaZHSvMo2hHDjmTym4xMHyc8w5+ i9uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=amNzwcR4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a23-20020aa79717000000b006635fd2ce52si753444pfg.77.2023.06.08.10.40.02; Thu, 08 Jun 2023 10:40:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=amNzwcR4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235704AbjFHR2B (ORCPT + 99 others); Thu, 8 Jun 2023 13:28:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231192AbjFHR17 (ORCPT ); Thu, 8 Jun 2023 13:27:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BC5B2733; Thu, 8 Jun 2023 10:27:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A2EF63F6C; Thu, 8 Jun 2023 17:27:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA9A6C433EF; Thu, 8 Jun 2023 17:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686245274; bh=D3n7QlNTzEG2bZLh2whGRjLa6uCHuMKRqgWF/RqPTXU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=amNzwcR42XFVdnXXAwksBTI5cDivfWubhW01QhpuW8sBSyX7fzsXfVOjUh4LYD7rx AARkvE7qq/aiVPnf6nOjri+4bB9JTh+rf9GY21AEBpZ95CpvAKYFFEqaLMsxCHJ+xq KuC4wjbljWqPix6c9OltAWYYV5nl82D6cJYLvVFockTXTxgFBswW9yTw9SYWXWowSK eAgnXpKTsFx6j/S0J4eJh08QV5lIqp0XLrGRa9fkVZTJJ/1lFwWMZnBi4W1mX3tLMV 81cR9l07NJ0lMIycgIWVqeLtM8xc12yP6385u3qb4+5im76KxrJeNWOJbPJyr6/wKR zzck5p7p/SjmQ== Date: Thu, 8 Jun 2023 18:27:49 +0100 From: Lee Jones To: Henning Schild Cc: Pavel Machek , Hans de Goede , Mark Gross , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v4 3/4] leds: simatic-ipc-leds-gpio: split up into multiple drivers Message-ID: <20230608172749.GJ3572061@google.com> References: <20230524124628.32295-1-henning.schild@siemens.com> <20230524124628.32295-4-henning.schild@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230524124628.32295-4-henning.schild@siemens.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 May 2023, Henning Schild wrote: > In order to clearly describe the dependencies between the GPIO > controller drivers and the users the driver is split up into a core, > two drivers and a common header. > > Signed-off-by: Henning Schild > --- > drivers/leds/simple/Makefile | 4 +- > .../simple/simatic-ipc-leds-gpio-apollolake.c | 66 +++++++ > .../leds/simple/simatic-ipc-leds-gpio-core.c | 104 +++++++++++ > .../simple/simatic-ipc-leds-gpio-f7188x.c | 66 +++++++ > drivers/leds/simple/simatic-ipc-leds-gpio.c | 163 ------------------ > drivers/leds/simple/simatic-ipc-leds-gpio.h | 22 +++ > drivers/leds/simple/simatic-ipc-leds.c | 1 - > drivers/platform/x86/simatic-ipc.c | 7 +- > 8 files changed, 265 insertions(+), 168 deletions(-) > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-apollolake.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-core.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio-f7188x.c > delete mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.h Applied, thanks -- Lee Jones [李琼斯]