Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1024258rwd; Thu, 8 Jun 2023 10:53:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6AfU8O3rakkZWtqxFDQcTTgEGBF6Hl57if686/vs80sKQMc4BvnOdh8GqE3M7N3p5KUTEH X-Received: by 2002:a05:6a21:3285:b0:110:9210:f6ac with SMTP id yt5-20020a056a21328500b001109210f6acmr5141233pzb.37.1686246826328; Thu, 08 Jun 2023 10:53:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686246826; cv=none; d=google.com; s=arc-20160816; b=bbJNUkDMu0FPc4jP73F2hvuJ2i00isXEUOgbFyaBm+1g4C4giCD0vSHvr9YDsf/Uqy KuUkBoSqQ/8CNMTkHtHI6qQ4Rlc393cActqe8BcjQtiIaHQzZ116MRSqLkJAgmatRPc+ EAapY62YG8Um0yKKUWY93sFWa5sk+8g8bkImcnQlQNb0hmaAqp0RZuVe2AnrVyFtFPlX FjTZ9bX+t1UDnHx3Yx+nASadbfk5kaujt1dJJbfXG1A+msSI1eqf19uwUb2ume1wksBX 817zWuPQpE5zNsP4DneMhZARIbijPHzTqCIgIsIkfAOa+vX3PZ+THgjoya14JUtqmRBf OeJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=W02zUw23vwdTR+YUVy4zkPMjnEmeCbcSWZiDujqfAuo=; b=IaRD6pmIplxmxg/EwxRXuI7MdE8GV9Xn29FUtPU5pkPvAmdE4d/3g4yOOcxrzG0aU6 gQqFKQpVpH9+D+qG1nok4jqIctua4YuiCEJzBBWDiHh3vNk4Oqjw5S5GJdeYYzQPf6xX 8C81Z9pMHqE0yMrWfWy7AliHtkRx/abGrbSSFbEwhqnOkfTtZZtWXMBE+m6onTmzB6D0 ztneyriH6hwKN17hvcxg6tCIn6Pp31sWgbgqBN2BBt+ywcHMkXNQZ1xiSVoYjE9YVYH5 OHG7S41b9DADqs9sGLYYYAHNde6AwlKE0zxO4a5BxnVUD98iSOiaPCAdk86TX/Ig6q5K q/dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=B2YRSciH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s192-20020a6377c9000000b00534e310d0d3si1347397pgc.588.2023.06.08.10.53.30; Thu, 08 Jun 2023 10:53:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=B2YRSciH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231908AbjFHRaf (ORCPT + 99 others); Thu, 8 Jun 2023 13:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230113AbjFHRae (ORCPT ); Thu, 8 Jun 2023 13:30:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1C2F95; Thu, 8 Jun 2023 10:30:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55E5464FCA; Thu, 8 Jun 2023 17:30:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0026AC433D2; Thu, 8 Jun 2023 17:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686245432; bh=jzImsaW9M4mP3N4OMbgFXFtC9VulvLbRUrXD1c3RT+4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B2YRSciH18KnS2omzxp1D0TOnR+9JCWqvvbW2FCOlFjoyan3V9hLi+Z4TxM1dBiuQ DwLEfJMCqrl/NpRYiDnE/2HBZpvP62MFTUARvI6Nk8qKNv/nFsM4fEwyAm+bnaZlS3 QNhaaPmavriI9sa1Db88XF3RRsDpKbmyRIUEf/4FNXj8xFcxJbGR7JMxHkoBJTc7A9 KNYoLa0qdi5KNkAUopPHwJ2S0hAGTq4xAawLosDdT55/99ddxinCNo0IFcUwHza67Q Ze2RZIZOtdCCb0Iyp/XPd6OtVG0KIEPcuXoPtOWvYhTBEQH/DG1z6CZzK1CD8ihIp1 v1kBSi+KVDwcw== Date: Thu, 8 Jun 2023 18:30:27 +0100 From: Lee Jones To: Andy Shevchenko Cc: Henning Schild , Pavel Machek , Hans de Goede , Mark Gross , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables Message-ID: <20230608173027.GL3572061@google.com> References: <20230524124628.32295-1-henning.schild@siemens.com> <20230524124628.32295-2-henning.schild@siemens.com> <20230530171100.75e5b86c@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01 Jun 2023, Andy Shevchenko wrote: > On Tue, May 30, 2023 at 05:11:00PM +0200, Henning Schild wrote: > > Am Sat, 27 May 2023 11:54:08 +0300 > > schrieb Andy Shevchenko : > > > > > On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote: > > > > The entries do not seem to be stricly needed when the number of > > > > entries is given via the number of LEDs. But adding them is a > > > > safeguard should anyone ever iterate over the tables to their end, > > > > it also gets us in line with other drivers that register > > > > "leds-gpio" tables. > > > > > > Reported-by? > > > Reviewed-by: Andy Shevchenko > > > > I think we could do > > > > Reported-by: Andy Shevchenko > > > > on merge. But i would not want to send the whole series again for that > > one line. > > Since you added it, `b4` will happily take it, I believe no manual work even > needed for that, thank you! b4 didn't pick this up. Nor the whole-series Ack provided by Hans. I added both manually. -- Lee Jones [李琼斯]