Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230608025435.29249-1-rdunlap@infradead.org>
In-Reply-To: <20230608025435.29249-1-rdunlap@infradead.org>
From:   Joe Tessler <jrt@google.com>
Date:   Thu, 8 Jun 2023 14:28:18 -0400
Message-ID: <CAJPkMDR-7u4nqZTsik8=sZUS28E1EL6R0+UnzynEXG41=RG9Yw@mail.gmail.com>
Subject: Re: [PATCH] media: cec: i2c: ch7322: also select REGMAP
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Jeff Chase <jnchase@google.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-media@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Mark Brown <broonie@kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 7, 2023 at 10:54=E2=80=AFPM Randy Dunlap <rdunlap@infradead.org=
> wrote:
>
> Selecting only REGMAP_I2C can leave REGMAP unset, causing build errors,
> so also select REGMAP to prevent the build errors.

Hi Randy,

I'm curious how you got into this state given that REGMAP is "default
y" when REGMAP_I2C is set.

$ grep -w REGMAP -A4 linux-6.3.6/drivers/base/regmap/Kconfig
config REGMAP
  default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1
|| REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE ||
REGMAP_SOUNDWIRE_MBQ || REGMAP_SCCB || REGMAP_I3C || REGMAP_SPI_AVMM
|| REGMAP_MDIO || REGMAP_FSI)
  select IRQ_DOMAIN if REGMAP_IRQ
  select MDIO_BUS if REGMAP_MDIO
  bool

FWIW, I only see four cases where both REGMAP and REGMAP_I2C are
selected in the linux-6.3.6 tree (out of 400+ REGMAP_I2C instances).

Joe

>
> ../drivers/media/cec/i2c/ch7322.c:158:21: error: variable 'ch7322_regmap'=
 has initializer but incomplete type
>   158 | static const struct regmap_config ch7322_regmap =3D {
> ../drivers/media/cec/i2c/ch7322.c:159:10: error: 'const struct regmap_con=
fig' has no member named 'reg_bits'
>   159 |         .reg_bits =3D 8,
> ../drivers/media/cec/i2c/ch7322.c:159:21: warning: excess elements in str=
uct initializer
>   159 |         .reg_bits =3D 8,
> ../drivers/media/cec/i2c/ch7322.c:160:10: error: 'const struct regmap_con=
fig' has no member named 'val_bits'
>   160 |         .val_bits =3D 8,
> ../drivers/media/cec/i2c/ch7322.c:160:21: warning: excess elements in str=
uct initializer
>   160 |         .val_bits =3D 8,
> ../drivers/media/cec/i2c/ch7322.c:161:10: error: 'const struct regmap_con=
fig' has no member named 'max_register'
>   161 |         .max_register =3D 0x7f,
> ../drivers/media/cec/i2c/ch7322.c:161:25: warning: excess elements in str=
uct initializer
>   161 |         .max_register =3D 0x7f,
> ../drivers/media/cec/i2c/ch7322.c:162:10: error: 'const struct regmap_con=
fig' has no member named 'disable_locking'
>   162 |         .disable_locking =3D true,
> ../drivers/media/cec/i2c/ch7322.c:162:28: warning: excess elements in str=
uct initializer
>   162 |         .disable_locking =3D true,
> ../drivers/media/cec/i2c/ch7322.c: In function 'ch7322_probe':
> ../drivers/media/cec/i2c/ch7322.c:468:26: error: implicit declaration of =
function 'devm_regmap_init_i2c' [-Werror=3Dimplicit-function-declaration]
>   468 |         ch7322->regmap =3D devm_regmap_init_i2c(client, &ch7322_r=
egmap);
> ../drivers/media/cec/i2c/ch7322.c:468:24: warning: assignment to 'struct =
regmap *' from 'int' makes pointer from integer without a cast [-Wint-conve=
rsion]
>   468 |         ch7322->regmap =3D devm_regmap_init_i2c(client, &ch7322_r=
egmap);
> ../drivers/media/cec/i2c/ch7322.c: At top level:
> ../drivers/media/cec/i2c/ch7322.c:158:35: error: storage size of 'ch7322_=
regmap' isn't known
>   158 | static const struct regmap_config ch7322_regmap =3D {
>
> Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller =
driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jeff Chase <jnchase@google.com>
> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Cc: Joe Tessler <jrt@google.com>
> Cc: linux-media@vger.kernel.org
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> ---
>  drivers/media/cec/i2c/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> diff -- a/drivers/media/cec/i2c/Kconfig b/drivers/media/cec/i2c/Kconfig
> --- a/drivers/media/cec/i2c/Kconfig
> +++ b/drivers/media/cec/i2c/Kconfig
> @@ -5,6 +5,7 @@
>  config CEC_CH7322
>         tristate "Chrontel CH7322 CEC controller"
>         depends on I2C
> +       select REGMAP
>         select REGMAP_I2C
>         select CEC_CORE
>         help