Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1125656rwd; Thu, 8 Jun 2023 12:32:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ574E6uBrgXyUYc8xspY3912PFcivKhD0WchWruyKZAdGmCKXnJJ+9j8VhadWkneinzLhj4 X-Received: by 2002:a17:903:2450:b0:1ad:fa2e:17f8 with SMTP id l16-20020a170903245000b001adfa2e17f8mr5820542pls.12.1686252731180; Thu, 08 Jun 2023 12:32:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686252731; cv=none; d=google.com; s=arc-20160816; b=naMCsw9TFUzCEpDKln9ijcU2p41xNJuXU92qPKV352RVff7wyixde/bX47sXmzqLpo Vi3Rhzmy4Gp/7czrG6hjDNTQrhgRSF4/4YImMi7V3VtMieO6aXcQkD4UOhCxDCujz1ld /OaTGBsfBbF1+rqhTwMFyVtB7hP96kNSaD1psvFv8LoGLDFbbvPeS6GW5AmcSZD3DeZ7 QfbzpqmSzS6a8gHU/p+GCXhqaRvA8dxBGnaNlb9wbtwjP/EVILNOMhR98FCUs7Q7/6YE ikbYoNBJb+/InCr7PCwQVBikzhK8cB1bcdJsLZdhyLsQdMEivGFVywb9BAwOQ8uLuv7J FxMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2OPOPDQNskA4BE/Gx3h1tR4IYFZdWY+xCSOk3HTM7xQ=; b=RbIYsY+7/O0PeWAMt01KELl3sJSi6zn8dAwxA5wVWYCTZLk3FDpb92gKMK9Rz0d7Q/ X+4mG4Qk+mas21ONufTJA72NXxFG99d68tAnkG+L3cPpozrvDm8yqM6wXZK+JggbLTc9 vMR3JPXezwjNEKGpX2Zrf6B9F6lRX3zoMOzqI25H/tJS01hsRU810IROqItMfyo654GZ W26PJxn1TTrHG9UiP+mHxDmBLjylA6N6NfTdJrFgHqDYCjUP4Zn0DuovWP3Kh++Fn+Yc Jo0Xxy7gtwZ2ZCiuK/KnYFMxksbCMR/P/qtz6orzHQlKaRELRw0EaJS5GOSeiHvhTTg2 YBhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ndVCovkL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l9-20020a170902f68900b001ac84f87b0fsi1519008plg.339.2023.06.08.12.31.58; Thu, 08 Jun 2023 12:32:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ndVCovkL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231626AbjFHT2X (ORCPT + 99 others); Thu, 8 Jun 2023 15:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230125AbjFHT2W (ORCPT ); Thu, 8 Jun 2023 15:28:22 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3699DA2; Thu, 8 Jun 2023 12:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2OPOPDQNskA4BE/Gx3h1tR4IYFZdWY+xCSOk3HTM7xQ=; b=ndVCovkL3OxQIwE7DQTs8wzCCZ 0+xAnPCsS1Vm90PjXkm3imrmH/DfIi+IZleBJYFlJ+Ga4ibnk0kNfYIcv4oospOfH2gnNKORBJNAd qjJBwkEOTA3Qp4lvVfrkgAuv83Ormd2RlKq6+A7OzcXk2lD5WATXgdvJz3LLaogKmMZFTE6XWGpnS gzJVGprSP3ImLnfpR1yVEbaL08HQbHYqMhH6ljv9VkzvaQZj18KftNwDf5mJoBTP1r5cENJ3Mcera rtCD7guY+rzOzYEd9ztulvyQAnrY9Vf82qotYfMkhcKiBFhfMFB9qvr26Kq5z/yUv2uWztWRG7qLH l0LXi24w==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q7LIg-00AM6g-1o; Thu, 08 Jun 2023 19:28:02 +0000 Date: Thu, 8 Jun 2023 12:28:02 -0700 From: Luis Chamberlain To: Maninder Singh Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, thunder.leizhen@huawei.com, boqun.feng@gmail.com, vincenzopalazzodev@gmail.com, ojeda@kernel.org, jgross@suse.com, brauner@kernel.org, michael.christie@oracle.com, samitolvanen@google.com, glider@google.com, peterz@infradead.org, keescook@chromium.org, stephen.s.brennan@oracle.com, alan.maguire@oracle.com, pmladek@suse.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Onkarnath Subject: Re: [PATCH v5 2/2] kallsyms: make kallsyms_show_value() as generic function Message-ID: References: <20230608033119.1543638-1-maninder1.s@samsung.com> <20230608033119.1543638-2-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608033119.1543638-2-maninder1.s@samsung.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 09:01:19AM +0530, Maninder Singh wrote: > This change makes function kallsyms_show_value() as > generic function without dependency on CONFIG_KALLSYMS. > > Now module address will be displayed with lsmod and /proc/modules. > > Earlier: > ======= > / # insmod test.ko > / # lsmod > test 12288 0 - Live 0x0000000000000000 (O) // No Module Load address > / # > > With change: > ========== > / # insmod test.ko > / # lsmod > test 12288 0 - Live 0xffff800000fc0000 (O) // Module address > / # cat /proc/modules > test 12288 0 - Live 0xffff800000fc0000 (O) > > Co-developed-by: Onkarnath > Signed-off-by: Onkarnath > Signed-off-by: Maninder Singh > Reviewed-by: Zhen Lei Thanks! Pushed to modules-next. Luis