Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Jun 2023 12:57:58 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 06/26] cxl/pci: Refactor component register discovery
 for reuse
Message-ID: <648232c6cde47_1433ac2945d@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-7-terry.bowman@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607221651.2454764-7-terry.bowman@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m5qhZ+A3FjhPwlBvs+YLr2tBE7gVFCu4CTvAv8sbb3G65VEvGy/IXtVNrNb8?=
 =?us-ascii?Q?FnPjDjytNymZ1s60/CcqRO7n0rvzpbbySmvZekTUjiLmqYV156jkoLRexX5s?=
 =?us-ascii?Q?gunlMp3Zo7/+UGuncZEijl2hMZgE73rpKsD+589o7PC2bkx0wcDGSQtpQurj?=
 =?us-ascii?Q?LFedKBYVkIHZfWioC+tSsqeccPmIQ40awneCKT6rZAOaTWD3KhI9Vj0w90rN?=
 =?us-ascii?Q?bXSFztWJTdq8eJ761klhnCedZY7bpYZhdnA3VMTY9n8DUbkViaQNmFJOz/xI?=
 =?us-ascii?Q?Hn6QHCWYjrANqXWNDjR8jlfgUiAAxoA1M0v7CvgH2tBArFoAw89KcLe0GhV7?=
 =?us-ascii?Q?4qwVKpF1USa6O68NrGqbtnYAy9bud55doRTK/lKZx96YAflCxFmwfPkrgFz3?=
 =?us-ascii?Q?Yw731qN1yw+a9kcAjYrbAQfS9+s5Mokxau3WzDmE64o3kg+TQGU4ITnhLoEK?=
 =?us-ascii?Q?fEFqEKZscE0puzHTp+7hZM3ykIBvFk4M8oVwGA+d+FKrVLpz6Jy5tRerKa7l?=
 =?us-ascii?Q?Vk5+o3kA6wnoA/+V+5HNEgpnfr9STWw8+yxw5OyYEiaUSC5ttJoG8IqbeWLy?=
 =?us-ascii?Q?yM0cWw9YJoPDLW5CJGAas5vZxKrhAVx5Y1rh4aClx3rL6i9LAqZ4JatnB+FO?=
 =?us-ascii?Q?+tt7H6g37VwuvuNXgHRg09p422R1B3r+4huJ6GRzR8cjq3nlP6Tl12N65FwL?=
 =?us-ascii?Q?Sf9xQM4yKLE7xfvD/c0lPvgTWcIXpnouRNNCrNvazRChy0R+fiTkEBiUKyYQ?=
 =?us-ascii?Q?WJic9q3q5l++nU/0Emu0lBW8t59OQxEqWF5+iFYjcGdeB1b8XQqF3Lgcxahu?=
 =?us-ascii?Q?MjFD+y33mUUKMg7hFF5lT35EufbZkaIrrKelwH4NjxYqpHvYnpVOMijpUOJU?=
 =?us-ascii?Q?2ngrzXltVPCZkeN7o9ZHF8fmr3YEmqKSMq6ziPSS5/KvaZwUYdxLBRd/cYmO?=
 =?us-ascii?Q?1oCxAvUaST8fQ4W11ChtaPvBBP+J8/DdUyh0de7O596788Jm+9sjD9HbzCpf?=
 =?us-ascii?Q?BMZpyjHw7AyUzD1WHB9mHEPpwvoJdbhB9Vsfa5oWT2EI2Ct0gJbND2ZiFss8?=
 =?us-ascii?Q?95MLaWclG7PzR0tyJ8h59LBO913KPR8DJYzSw01AMrBtCPdz2WPG8frgvx+I?=
 =?us-ascii?Q?GQBM+JjAmhN/HP1k2WQq3wZmhGrcZ55hNKso6zVYsporFVSXmGZuB1PmN4RD?=
 =?us-ascii?Q?hoUDc8IvMB7VkEBANv3XztCpZ1aN5tWKw6fwHHBRXltYJf3/8AWO0nSinRsh?=
 =?us-ascii?Q?HdnHi8y9TTofoUrGV2t1gMgP2/wmxJSKPiR30ECGOwtc296LRrkD3tcg8+SH?=
 =?us-ascii?Q?tW+fGce2t8vpHlv+VRbegYctf6/cYs9WC8Qg95gNLuofmY0ezfIKkvmPRo75?=
 =?us-ascii?Q?HOCD2fKffNH1G8hW2fFAAH/wU9lPyObc1n/5od+K0/A+0rL82AbOzWCBvx1y?=
 =?us-ascii?Q?mHEARbOYnW3fbykLFfyKPn5bmdOhLEV4b9Yrqtg8Du+sl7nQgbs0ooGkYF8n?=
 =?us-ascii?Q?2o5xDNn6CKPfuVqLsTfL9HZaEYw4c+53k3tCx/dlhr2J6K5SGGJdbK0yKpUB?=
 =?us-ascii?Q?nR4F0Wk/y6U+Oxoq63DeLHnl2y81WZEQ4dAiQNWsMUL0CmdL9V0XR5Ww6GHV?=
 =?us-ascii?Q?Qg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: adf2bbda-7f78-46c0-01d6-08db685aac2f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 19:58:05.1296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hgNhUi29FEyFN8WTWubiDf4BVOmIE5o8K4XrEXosV3C6Q0A+G0g3+FYOFL1210lEv5/+GBFQswdh7PH0AUWDLr/wbqlXKo18+y1AiGwyIp0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8263
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Terry Bowman wrote:
> The endpoint implements component register setup code. Refactor it for
> reuse with RCRB, downstream port, and upstream port setup.
> 
> Move PCI specifics from cxl_setup_regs() into cxl_pci_setup_regs().
> 
> Move cxl_setup_regs() into cxl/core/regs.c and export it. This also
> includes supporting static functions cxl_map_registerblock(),
> cxl_unmap_register_block() and cxl_probe_regs().

Looks ok to me. I hit some minor conflicts rebasing it on changes
proposed earlier, but no other concerns from me.