Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1195657rwd; Thu, 8 Jun 2023 13:52:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6M5N8AzA2O+988pu0yTged5uESMXlOayvQQe4+iC3/IC8+pLs7rLUkAiIibd0vQHLFwy70 X-Received: by 2002:a05:6a20:158d:b0:117:71bf:a58a with SMTP id h13-20020a056a20158d00b0011771bfa58amr4901816pzj.17.1686257527712; Thu, 08 Jun 2023 13:52:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686257527; cv=none; d=google.com; s=arc-20160816; b=HZV+RszhhzQU2HBeodssUdHMSMx7J+jF+OGNNCvnG0IWadO2F5UuTmzyAA2pMjU5F9 1iiFdKIDtKAS2dcMvCH08JO+8m1uylYjEZ1VQHE5NSRynKWODYGMlRH26IjWAXxXpZkB NBArfP+ZqknpTEjq86dW/uCvN3rRZaP6PcWtjl17uuIlXe0VmFKx9HgxSvdPlxpI7BDy +dL1KrtnC2SmjPfO+Qoggj1Ebgzz7G2GqpJqwFzF/G/hvRX3IZqpQtXgTu+hNQh509zo opv2a+0keAADng3FhNdZvMVB17wQQsbY7EGbdb8u7O5yhZEprD1hdHY4BZkEtoNzPufb NtHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=yCE7xocRBkEwXdhay/uk+7t0tswMRd2eea3cgJIDzvo=; b=ZigTz+69yofqjtctL8+BdRLDB0mje6weZHgybbOcfQAcwdPZd7ONB03C2ZJpHjYKs7 FD8axjp5smmDnrJoc2WdezhahkNa7Si1W0iSJ12620/vnZp8mLvHJC+jCd2u4/Y3/Kyt qPrX7/lz5QrWOd66SpPnc/MAj+SKi1/EYvnwb0CmmkUslMWje73OLp+wLkZKt9deeg6y tXRmScpDUlm7WjBNMFEBeDqLjWeeWvMyJ5CO/ltj91B49KY8VwWCNDeiD2QUWefyU6Lg 78PwM8faJTD3lWBneAiqPBPjzlBM62cbD5QVYJimwTzXDkEY43JvDgVAy+mlh/vRnLsa sVlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 83-20020a630256000000b00542abcf2ce4si1474947pgc.623.2023.06.08.13.51.53; Thu, 08 Jun 2023 13:52:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236763AbjFHUHX (ORCPT + 99 others); Thu, 8 Jun 2023 16:07:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236548AbjFHUHV (ORCPT ); Thu, 8 Jun 2023 16:07:21 -0400 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EF7BB9; Thu, 8 Jun 2023 13:07:19 -0700 (PDT) Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-77703f20aa9so50155139f.1; Thu, 08 Jun 2023 13:07:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686254839; x=1688846839; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yCE7xocRBkEwXdhay/uk+7t0tswMRd2eea3cgJIDzvo=; b=LYHhKDq7gYK2Pg8UvFlzDprXphJjtdKDejQttxbVjpAQV0+csgaOo918Ne3CNMue/G 3FDJpQ/gkFZyluflfxMhMnydZV9uG10URVZL77EKtILDHsPuTNK62pwIOZMC+vqHAIsh 9MAlduQNk+cf71jRqkbPm5Hy64Rl08RSEcsGebaDWPvfSBixUioxecHQOIqxkFJPJL8h KL6wYx08fFRTe6t+pvijK2+KFhWAFVGd11t03rOHAIQVnstFQVW0QBkjaQnqBvIT+HxW nNvM4sPG0JHLJ5SnlQrGBe6Ge6SNGJJW5fRglBgu4SATfxxZWxRo+9hV4N2uFgZhj2kT s+HQ== X-Gm-Message-State: AC+VfDzS5FUtHlMG5DKbSzqYhlDt4PL83WOiPtNwYfFRKPakVZTFqse8 BelXMqLECzl4hAsidLrbLw== X-Received: by 2002:a6b:6d03:0:b0:76c:6d91:d293 with SMTP id a3-20020a6b6d03000000b0076c6d91d293mr11838245iod.2.1686254838828; Thu, 08 Jun 2023 13:07:18 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id k8-20020a02c768000000b00416650ba62esm476861jao.76.2023.06.08.13.07.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jun 2023 13:07:17 -0700 (PDT) Received: (nullmailer pid 3317123 invoked by uid 1000); Thu, 08 Jun 2023 20:07:15 -0000 Date: Thu, 8 Jun 2023 14:07:15 -0600 From: Rob Herring To: Sascha Hauer Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , kernel@pengutronix.de, Michael Riesch , Robin Murphy , Vincent Legoll , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Subject: Re: [PATCH v5 22/25] dt-bindings: devfreq: event: rockchip,dfi: Add rk3588 support Message-ID: <20230608200715.GA3315970-robh@kernel.org> References: <20230524083153.2046084-1-s.hauer@pengutronix.de> <20230524083153.2046084-23-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524083153.2046084-23-s.hauer@pengutronix.de> X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 10:31:50AM +0200, Sascha Hauer wrote: > This adds rockchip,rk3588-dfi to the list of compatibles. Unlike ealier > SoCs the rk3588 has four interrupts (one for each channel) instead of > only one, so increase the number of allowed interrupts to four and also > add interrupt-names. > > Signed-off-by: Sascha Hauer > --- > > Notes: > Changes since v4: > - new patch > > .../bindings/devfreq/event/rockchip,dfi.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > index e8b64494ee8bd..4e647a9560560 100644 > --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - rockchip,rk3399-dfi > - rockchip,rk3568-dfi > + - rockchip,rk3588-dfi > > clocks: > maxItems: 1 > @@ -23,7 +24,18 @@ properties: > - const: pclk_ddr_mon > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 4 > + > + interrupt-names: > + oneOf: > + - items: > + - const: ch0 > + - items: > + - const: ch0 > + - const: ch1 > + - const: ch2 > + - const: ch3 Names that are just an index are generally pointless.