Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1294727rwd; Thu, 8 Jun 2023 15:50:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6SmB8V7MqLFENvDJXGnKeEzYn+WEg704YLaznUaBynCjwZO9iXm7Bn+ibmeeQBL3MYCR6O X-Received: by 2002:a05:6a20:4304:b0:116:5321:63c0 with SMTP id h4-20020a056a20430400b00116532163c0mr5844290pzk.48.1686264644382; Thu, 08 Jun 2023 15:50:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686264644; cv=none; d=google.com; s=arc-20160816; b=v/g4CS5kzOXlUbWbcXVGWQavAqFBOnwXSFKwK6b1UWPxBt81ySr3V4ZrC/dOnzYoW5 beCd4lx0IsiM3UJStaqDaoYrDEeny7HQohiOeYiIK84QFNYdCK0GEFj7LWeYalNtuBbf S35ORKXzijUf6a5fIpaicIBQJq3mGK/bHXIX4XzzhvN5WXboRA/L2jzaZvTsisB4pjNH EczaO4+s1/j/EWGLfiH7zdWLRkR4ss9ITVNaSdq5GC5G4bkQ29eWYs4IF2DJlBGIesTB Ic+7hyZjcy9D6QjIl2P31OFT+9GEnIpEQMNce1e6QMO2Uu+9Q1COTHDlRFp3ktjgTDl2 hGsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IjMAh4QV72tVO1Xahg6IDGh4HmcjO84xpIRDJ+IKLAQ=; b=z+lFUh57HOBVJdt5hqbsWg3XczKAhH6ht+XK/o2EW4UyhNFVZ/YFcEarBP4mN9to8N 7+ufmtZKcFObS2wmsh7Q07gDrD/KuqA83I3/A50yDgspxN02phjCoYVlrtIjtzxaFCgz tfNF1sueNZPKjnxDB4L/jrD/VmMmrb4T9i600fA2gbJFv3LRxUTKXYBOuefrPBqxq0j2 43KnOSXnvOleutoIeAE4Q7ZN/CYG2cmrUlp0zqfX+UVWpWU1aXkMWSrH5g6b/AsPbM7t Ak0scfTf5wTE17NifYYU5NW28C0YeLckhfJN2+/6J+s6wHOjQc3Q1VFNKMdB7NF4ne3o nYjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DOgZyUui; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a637a47000000b0053fb5df5561si1550383pgn.246.2023.06.08.15.50.32; Thu, 08 Jun 2023 15:50:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DOgZyUui; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237165AbjFHWcX (ORCPT + 99 others); Thu, 8 Jun 2023 18:32:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237014AbjFHWcQ (ORCPT ); Thu, 8 Jun 2023 18:32:16 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41D73C2 for ; Thu, 8 Jun 2023 15:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686263535; x=1717799535; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GtHT20V983sr8n3O3e7GEiqoyfK5vMEHBMPj3byjlrM=; b=DOgZyUuipnZmO8SgyaUmEcIwqlYn1hfR/rC929YszL40yF6fEcaJdd87 Sd8fjK3UZR/RjM//DKXIloMGivn/b3kAilP6oe9kEV5BKssw7HzPkVorg jAlTdChubMIIfRKqtkqamE1tyjF7ObywrVn0JGsxWVYISAiOiBUHUHlji amIP3kp8eLe8nmc0azBdpkodkg/ud60bMTkp8K2YxP7WA2JcDAoISQE1E cSCK65LpkaPi1Og8vjZwbnPbBtes5SnIXHiq1jxJF2x/g7ijhtIJxuGVR Ko8E8rCA4CClUreck7jHnPq/pK94gBrS1AoX1bTPAONRlz/yAV//s+loz w==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="347094722" X-IronPort-AV: E=Sophos;i="6.00,227,1681196400"; d="scan'208";a="347094722" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 15:32:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="956906445" X-IronPort-AV: E=Sophos;i="6.00,227,1681196400"; d="scan'208";a="956906445" Received: from b04f130c83f2.jf.intel.com ([10.165.154.98]) by fmsmga006.fm.intel.com with ESMTP; 08 Jun 2023 15:32:13 -0700 From: Tim Chen To: Peter Zijlstra Cc: Tim C Chen , Juri Lelli , Vincent Guittot , Ricardo Neri , "Ravi V . Shankar" , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Len Brown , Mel Gorman , "Rafael J . Wysocki" , Srinivas Pandruvada , Steven Rostedt , Valentin Schneider , Ionela Voinescu , x86@kernel.org, linux-kernel@vger.kernel.org, Shrikanth Hegde , Srikar Dronamraju , naveen.n.rao@linux.vnet.ibm.com, Yicong Yang , Barry Song , Chen Yu , Hillf Danton Subject: [Patch v2 2/6] sched/topology: Record number of cores in sched group Date: Thu, 8 Jun 2023 15:32:28 -0700 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tim C Chen When balancing sibling domains that have different number of cores, tasks in respective sibling domain should be proportional to the number of cores in each domain. In preparation of implementing such a policy, record the number of tasks in a scheduling group. Signed-off-by: Tim Chen --- kernel/sched/sched.h | 1 + kernel/sched/topology.c | 10 +++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 3d0eb36350d2..5f7f36e45b87 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1860,6 +1860,7 @@ struct sched_group { atomic_t ref; unsigned int group_weight; + unsigned int cores; struct sched_group_capacity *sgc; int asym_prefer_cpu; /* CPU of highest priority in group */ int flags; diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 6d5628fcebcf..6b099dbdfb39 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1275,14 +1275,22 @@ build_sched_groups(struct sched_domain *sd, int cpu) static void init_sched_groups_capacity(int cpu, struct sched_domain *sd) { struct sched_group *sg = sd->groups; + struct cpumask *mask = sched_domains_tmpmask2; WARN_ON(!sg); do { - int cpu, max_cpu = -1; + int cpu, cores = 0, max_cpu = -1; sg->group_weight = cpumask_weight(sched_group_span(sg)); + cpumask_copy(mask, sched_group_span(sg)); + for_each_cpu(cpu, mask) { + cores++; + cpumask_andnot(mask, mask, cpu_smt_mask(cpu)); + } + sg->cores = cores; + if (!(sd->flags & SD_ASYM_PACKING)) goto next; -- 2.32.0