Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b6084daf-990d-9ec2-4fc3-dd95fb25eb72@intel.com>
Date:   Thu, 8 Jun 2023 16:47:58 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [net PATCH 1/2] octeontx2-af: fixed resource availability check
To:     Naveen Mamindlapalli <naveenm@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sgoutham@marvell.com>
CC:     Satha Rao <skoteshwar@marvell.com>
References: <20230608114201.31112-1-naveenm@marvell.com>
 <20230608114201.31112-2-naveenm@marvell.com>
Content-Language: en-US
From:   "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
In-Reply-To: <20230608114201.31112-2-naveenm@marvell.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2tOU040dGpVbXZFOGtmdHFhbGNGR2JoRkp1N2p6WHRPMXJCUzlCN0xhNnJl?=
 =?utf-8?B?cDl1QXd1Rzk1eno5Z1RrWURpcGk4c1U4R2R6UmcyVjJRYVkvSS9kOTcwVU5s?=
 =?utf-8?B?dUl3aEpqTms1bnlBRjVUQVE2RlM0MVN2cE5YWDB1WDV3eDAzeGJjUmpxamZD?=
 =?utf-8?B?VmhrZHVDSDkrbXArWnBPNmZlOEI2ZzRjOG5TZmEwczhtRWwvekZCNndNNUtl?=
 =?utf-8?B?Yk0xa3FJSkxsY0h6MVRxSDh5RFFKeG0vby9ia1NuNGVMeXJ3bU5sMjY3Q0tF?=
 =?utf-8?B?S3cyQURVK041UTJ4UGdXZHdVR3lkNHZtcHRPdlpQT20xbEJvSVFoS0E0SnE5?=
 =?utf-8?B?WDJxRmhGdEh4V2NMMURsR1lBNncwQTlvZmUrZzk1WkU2RjVhOGpwTkxva0lr?=
 =?utf-8?B?UU5aTmNyaVJzbFRzZGpia3ZxcDZlQlBvNE5BaU1RUTVsZDNsVWJhVjNnTENK?=
 =?utf-8?B?d2pFU2MwQkwya1dpVFRYakE2d1R0bWNjRGdoNExKUUIvVnVpMGsrcGpobkpL?=
 =?utf-8?B?anJVcHVjQVZFd2RxMGJIcndIenR2Sk5sL0t1UmhNMHdsaURock14SkJLVDdL?=
 =?utf-8?B?dVU4NHVPaFh2NU1UWTJ5LzdmMDBJaE13bks3cEpJY2gvbHN4Nm1SN1lTM0Ju?=
 =?utf-8?B?eVpWbDV3ZU1QQVlkMDcwNmZHRU84R1N4d2NaeDB1a2NwVk1oSVpOSXJhTEQ2?=
 =?utf-8?B?UzV5eDUzYi9WV2ZmUFgwSmhGelU1T1BNa1MzNkFUQ0xjeDJnUkNVS3h5Nys4?=
 =?utf-8?B?YjBFd0hUa0lqblR1T1gwMzhiR2tUL3lmbjZ5VllBcDcwOGU1NlBJTW5GUS9F?=
 =?utf-8?B?QlYxQnE4cmVhbjNLdmhmd3k5YzNCWVpSV1M2SDl0THJOQWdqUTZSOEovK3lU?=
 =?utf-8?B?VHF3dXNpaDAzMmkxbVVJNXNFWFdVRTJZU0c2OE9DanFjVzMvNzlBR3MvNVVU?=
 =?utf-8?B?SDlnU0hEUldzbTFkZlNIMklTUUJHRzdyWFFRc2lyWWtycVp2OGRVNXlJbVNy?=
 =?utf-8?B?bENWTTVmRXlUOWJQOWJGNEl3L2hTczFSYXVrU2RHWVpvMmdFMmVtSE9OUE9Q?=
 =?utf-8?B?THlUZmpYRzB0N1FtZTdoUmJBdENaSVVMckh5VG44eEhlSGRSc1NWNGh0dFlZ?=
 =?utf-8?B?WUpXK3llRnJjZWZ6SlF5eVBQOEhnSVFCdzVWN2xBaGJpUDY0K2U5dzNWcEN5?=
 =?utf-8?B?R1R3aHlNYTdRdWxsVmJxbHZpM0NwdGlEeTdvRTQrckhwMldBNU0wTVpvV25I?=
 =?utf-8?B?VGJ5aStLNVYyTWVIV2t0VXVHQ2NrL1ZKd2VSUktwUXV4ZWptczl0aGhGNlhk?=
 =?utf-8?B?a3UyVFVQUm4zbXc1YjdBcnhmQmZna2dJNUNrcXM2R3NCcjIxUVNXUjhPRXRw?=
 =?utf-8?B?ODFHd0RiN0VaWmZtN01DUFBialFZWWw2dnVSS1JpajF3cEhCQnJqSGZGdXJl?=
 =?utf-8?B?aEwyVjFDTE5SckUyR1Z5blRnUTZSeFNVYzhTaVFBdndyekIySFBpUHptd29q?=
 =?utf-8?B?UXlkTXhmdkduT2xENzVrVUpiY0hoa09za2dOZVhCMTdCY0Q1V3hpL1FXVW4y?=
 =?utf-8?B?SU9pUnQzZWMwek91WGJKdU5FYTVablhmQUNEUGY1a3liNFdDQmVXYlJxVm5C?=
 =?utf-8?B?Mi84dGVxV2YwRlptdGRhcVQ2WlY4SEcrdVJoUVNEQm1RQWZ3UFdKNnUxalNs?=
 =?utf-8?B?TXdEZFNFT3ZQKzJBZXR6bkFNc0dRaFF1eXlZVkNqMzVwVGh1SFBQY3VVbnZx?=
 =?utf-8?B?NGJ2SWpGT1d5elQ3bWJQU3VqOUZ5cTNMNVVjQ0NreG54ZXlrcElxRUJzV1dy?=
 =?utf-8?B?MFM0dU02NHJLSUVLbGhwVUN3MkFTTWFMSHFnb3pUWjFuM1M2NnRiNHZDL2Jn?=
 =?utf-8?B?UVF5ZmxCVHBxdUo2SU55Zm1uYm9acHlvZUVDbzNVNW1pbUkzREhCREJhR002?=
 =?utf-8?B?ekw4TDlNa3RvTThwNlpHOVY1U3ordEsza3hlWmJCTS9IRVhNd2wzK0FTbFJS?=
 =?utf-8?B?aFB2YXZ6T2Jwb0hZeUFtVURQSk1UM0JDZzFVbUlGa3h1UWJQeXZBRHVoUjFI?=
 =?utf-8?B?QUFrc2I1U3BmN0h6WDYyYVFHdE1JTmZrZVhGVWZXdWxyWTMya0lOZzR1YzVu?=
 =?utf-8?B?VlhYTWdSb3dKU1U2d05CUjVkU05EWlRGNCtzMnRvRXNxcnVvc29MYnVrZXEr?=
 =?utf-8?B?ZXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 37b800d9-6171-4984-4e42-08db687acacf
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4886.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 23:48:00.2780
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tqi0QffmqfZZ6pT1+PYQWa1H1dMZ4N1+4Ed60Hcro1HXmCoc1Qk6YtnUBXoHbB97Yh1QzBZ+rRbWyifHDAPJjzpv+KgmBhUK4C03SyiH4T4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7529
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/8/2023 4:42 AM, Naveen Mamindlapalli wrote:
> From: Satha Rao <skoteshwar@marvell.com>
> 
> txschq_alloc response have two different arrays to store continuous
> and non-continuous schedulers of each level. Requested count should
> be checked for each array separately.
> 
> Fixes: 5d9b976d4480 ("octeontx2-af: Support fixed transmit scheduler topology")
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>

Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>

> ---
>   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> index 26e639e57dae..967370c0a649 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> @@ -1864,7 +1864,8 @@ static int nix_check_txschq_alloc_req(struct rvu *rvu, int lvl, u16 pcifunc,
>   		free_cnt = rvu_rsrc_free_count(&txsch->schq);
>   	}
>   
> -	if (free_cnt < req_schq || req_schq > MAX_TXSCHQ_PER_FUNC)
> +	if (free_cnt < req_schq || req->schq[lvl] > MAX_TXSCHQ_PER_FUNC ||
> +	    req->schq_contig[lvl] > MAX_TXSCHQ_PER_FUNC)
>   		return NIX_AF_ERR_TLX_ALLOC_FAIL;
>   
>   	/* If contiguous queues are needed, check for availability */