Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e7d42dab-ca13-13f3-4b58-b7c95f9e6afd@intel.com>
Date:   Thu, 8 Jun 2023 16:48:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [net PATCH 2/2] octeontx2-af: fix lbk link credits on cn10k
Content-Language: en-US
To:     Naveen Mamindlapalli <naveenm@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sgoutham@marvell.com>
CC:     Nithin Dabilpuram <ndabilpuram@marvell.com>
References: <20230608114201.31112-1-naveenm@marvell.com>
 <20230608114201.31112-3-naveenm@marvell.com>
From:   "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
In-Reply-To: <20230608114201.31112-3-naveenm@marvell.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZG9SOEY2dllRWXJWcXVBMS96UFpNZ3JHV3krTGVoQ1ZuNUNVUitwME5Rb1Mw?=
 =?utf-8?B?YkZaYXV4VHRadmxDM0NjTm0yVGE5eml4aVNCai9rMExGQkVWQ0UreHJDOC9G?=
 =?utf-8?B?Tld3V3hPMmhONzdTVTBTWGxYbGFQbGlETExjSlV6bEN1NDRyRGtSK3ZnU1dY?=
 =?utf-8?B?aG02SW1YWkdLUWFUN2hXUHFndjdvblh0VUFJREZ3dlFRbGJLMngxbE1IUHVT?=
 =?utf-8?B?c2wybHVaZDB3VTl6aEtzdmI0MVJkZG1lWkkwdTJSOTRJSXQyNjJSQzMvKy9l?=
 =?utf-8?B?bm02VmRxUGhqSjg3UWlkQVFnOGdObjNRa2lMWm1pMzJ2emVGUUloOW5XeS90?=
 =?utf-8?B?dURtZXhzYWs4ZTFWMG9ZeGJvMSthbFBzRFdEOGxJK2l1QVB1UFZvZWtxbmRF?=
 =?utf-8?B?T2MvdEdjOWtYVmZza29DOHFiRGRoOVExVWt4bXRUWFBROWNSRHlwQk1NL1Fp?=
 =?utf-8?B?RWI2YVpsMXNRN3pWVnhqY25ZbGs3OVc4dG5NaHhibEVLT3dwdlVuMDhFRlR0?=
 =?utf-8?B?VGg1QlBmbTBvVTJqb0oyaklKUnNFb0o4NVBwbE1SaVN2OWZOcnNVb2hhZlVI?=
 =?utf-8?B?NTlaaGFrbkJzWXZuUXZYV050Y2VnWGZBVUNKRzJrOFJnZmgrTStuVzBrcitI?=
 =?utf-8?B?RzhOWkRMaXhUZzByRUlzclFoT2o4amxUbEc4TVRsK2s1cmZFSlRpRXhNOFU3?=
 =?utf-8?B?UnF3NlpxUDVnMDEvQlYxenUvVHlZTUFaVFV2RmZHZGFjWEQzNjM5RUNhdHFu?=
 =?utf-8?B?Qzk5bWluUUZ1R21BVytDSTZWV3JRa29VeUh0UDV0V0FzOG92SWR6Q1hzWndz?=
 =?utf-8?B?OFN0RTFzb3N1SHBOdE9yb09xWjRsZ3l3TUJ0TEQ3dVA4N09nQ2lPakY0KzNa?=
 =?utf-8?B?RTVFb01UMmRkdVZCd3RXd1J3Q3Q0WHhYNnFMUHJoaTlvRXZiRXgzYStoNkFK?=
 =?utf-8?B?V0pJQ1FFeXVqZTJuV25DOFQrOW5kRFEvVms4aTJsbXE4K2NhT081aHJLRDRC?=
 =?utf-8?B?YUhzSTNTWnNNQmdmZkpBdmdyWkxlbDlQWTlSV1U2WVNUcVVwejBCNWxldllL?=
 =?utf-8?B?R3Q3K25vTmVYODVEVmxiaGpNb29Zdll4TWlxOE5PRnJwbXRMT3Y0N0RlSU41?=
 =?utf-8?B?NTdmUDNWdDV1czRUNGFMNjkzT0RxeUdoVndHRkZhL2Znd1NMMjBBdXRNcXFx?=
 =?utf-8?B?WU9FMmVORW45V0gzdnZ2RnpTcnI2UUEzbmlCeXJqV25iOXgvTVFXNmh2L2oy?=
 =?utf-8?B?bWNHUU1KNFZDRjJrK0g0WjFsSjQvUHllUkg1cnRFQUVGZUpmSGJNb3FHeTRG?=
 =?utf-8?B?WEgvckY4QVJMTkJ3WGk2WjlKQ2dhanZveTA4dGFHTURUa05nVkJueXF3c1lu?=
 =?utf-8?B?MDhKTm95bUJJNjdwYmV3Z1gxalRFWTNQVUYwS09sV08yUzkvU1NkT1d1TWdx?=
 =?utf-8?B?Z0cxQlFEM0N6anVFcEVXQjBzcFFQZUNkbjFlNjVtOGptWUQzUVVEaG5IeHZq?=
 =?utf-8?B?S2JSUjRnTE02U1NxQmVpM1RVM3pESVVyNHBzbXcvVlVmY2l2WlN2WDRjaFdZ?=
 =?utf-8?B?YnF1NFBERDdONEs5NkdROW9UYkVhQWN2eGZNT3NkMXJXYVZXUW9MZFhTdC9o?=
 =?utf-8?B?VUVuaG5ITG5HZXY4MzlkOHBVcWZtcWJ1T0d5dHpHcTdOUmhSQVRBVXp6dGtl?=
 =?utf-8?B?c2FjbDloOXQ5WU1sd2svVFVYL0k0eFlkZkVHeEtPVk1sZExSb0pLeEtaWmlY?=
 =?utf-8?B?OGNjczkxRWZkVDVyWGhuWWIyV0d4ZDJ3ZjNOejIvcUJaUk85akJMbmd5dytr?=
 =?utf-8?B?NyttZW9TOExaa3ExREJxczI1ZSs2UkV6am5DYVp1NjV3L2hDWWdKdE1LTEhC?=
 =?utf-8?B?NnBBaUthR2J3amVOSEJxMGVQVW5FZ0RCYXFCL21GYjJsWFBPNjlnMDh0MFVO?=
 =?utf-8?B?eEJGRk5sT1FvY2t1WTRmZGp5SWZ6M1ZmdzBod3pCZzlURTkrdWszMDRpSkp3?=
 =?utf-8?B?RllXbndMWkEwSHR1MWI5TG5zTlFnNkVWYURxdGdtOFJTanNOakE1dThEenFW?=
 =?utf-8?B?QVhpTTF6amFNTFh6MXhaUlVYQTZTVWhFTkY0TS9vTmF6dmtDZWtzUWNtaGtj?=
 =?utf-8?B?ZG9DN2VTSFM1cmdxTW5HSXBhMzlkSW4zZDhxMUtQYnlDOHdEOHBtaUo1MEZG?=
 =?utf-8?B?TUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9aa7fa4e-3747-43c7-f315-08db687ae6e6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4886.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 23:48:47.3640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mH9bKNOx5J6P+IdLm/1bCC0ir+0cwn/KrfbF3p2x8lmetMFX+u2yvBGrcxeAYdmMfh02DazA6MKiuFyQ2+uGnRgb1+VQ+BqsxD+nyUly4Bc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7529
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/8/2023 4:42 AM, Naveen Mamindlapalli wrote:
> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
> 
> Fix LBK link credits on CN10K to be same as CN9K i.e
> 16 * MAX_LBK_DATA_RATE instead of current scheme of
> calculation based on LBK buf length / FIFO size.
> 
> Fixes: 6e54e1c5399a ("octeontx2-af: cn10K: Add MTU configuration")
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>

Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>

> ---
>   drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> index 967370c0a649..cbb6d7e62d90 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> @@ -4067,10 +4067,6 @@ int rvu_mbox_handler_nix_set_rx_cfg(struct rvu *rvu, struct nix_rx_cfg *req,
>   
>   static u64 rvu_get_lbk_link_credits(struct rvu *rvu, u16 lbk_max_frs)
>   {
> -	/* CN10k supports 72KB FIFO size and max packet size of 64k */
> -	if (rvu->hw->lbk_bufsize == 0x12000)
> -		return (rvu->hw->lbk_bufsize - lbk_max_frs) / 16;
> -
>   	return 1600; /* 16 * max LBK datarate = 16 * 100Gbps */
>   }
>