Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230608022738.1861729-1-huqi@loongson.cn>
In-Reply-To: <20230608022738.1861729-1-huqi@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Fri, 9 Jun 2023 10:04:58 +0800
Message-ID: <CAAhV-H4ve4injzQJNp5=y0qkE7szy6EwxNOnPzzFn0+aAGZgdg@mail.gmail.com>
Subject: Re: [PATCH v2] LoongArch: Fix function write_fcsr
To:     Qi Hu <huqi@loongson.cn>
Cc:     WANG Xuerui <kernel@xen0n.name>,
        Qing Zhang <zhangqing@loongson.cn>,
        Enze Li <lienze@kylinos.cn>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, Miao HAO <haomiao19@mails.ucas.ac.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Queued, thanks.

Huacai

On Thu, Jun 8, 2023 at 10:27=E2=80=AFAM Qi Hu <huqi@loongson.cn> wrote:
>
> Function "write_fcsr" uses wrong asm dest. Fix it!
>
> Reported-by: Miao HAO <haomiao19@mails.ucas.ac.cn>
> Signed-off-by: Qi Hu <huqi@loongson.cn>
> ---
>  arch/loongarch/include/asm/loongarch.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/include/asm/loongarch.h b/arch/loongarch/incl=
ude/asm/loongarch.h
> index b3323ab5b78d..35e8a52fea11 100644
> --- a/arch/loongarch/include/asm/loongarch.h
> +++ b/arch/loongarch/include/asm/loongarch.h
> @@ -1496,7 +1496,7 @@ __BUILD_CSR_OP(tlbidx)
>  #define write_fcsr(dest, val) \
>  do {   \
>         __asm__ __volatile__(   \
> -       "       movgr2fcsr      %0, "__stringify(dest)" \n"     \
> +       "       movgr2fcsr      "__stringify(dest)", %0 \n"     \
>         : : "r" (val)); \
>  } while (0)
>
> --
> 2.40.1
>