Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230608130157.5871-1-zhangqing@loongson.cn>
In-Reply-To: <20230608130157.5871-1-zhangqing@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Fri, 9 Jun 2023 10:04:13 +0800
Message-ID: <CAAhV-H7yLgM7WAnubjkBx27E7UUTpMC+x93y=t6YkcEWBafFGQ@mail.gmail.com>
Subject: Re: [PATCH] LoongArch: Avoid uninitialized alignment_mask
To:     Qing Zhang <zhangqing@loongson.cn>
Cc:     WANG Xuerui <kernel@xen0n.name>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org, Colin King <colin.i.king@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Queued, thanks.

Huacai

On Thu, Jun 8, 2023 at 9:02=E2=80=AFPM Qing Zhang <zhangqing@loongson.cn> w=
rote:
>
> The hardware monitoring points for instruction fetching and
> load/store operations need to align 4 bytes or 1/2/4/8 bytes respectively=
.
>
> Reported-by: Colin King <colin.i.king@gmail.com>
> Signed-off-by: Qing Zhang <zhangqing@loongson.cn>
> ---
>  arch/loongarch/kernel/hw_breakpoint.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/loongarch/kernel/hw_breakpoint.c b/arch/loongarch/kerne=
l/hw_breakpoint.c
> index 2406c95b34cc..021b59c248fa 100644
> --- a/arch/loongarch/kernel/hw_breakpoint.c
> +++ b/arch/loongarch/kernel/hw_breakpoint.c
> @@ -396,6 +396,8 @@ int hw_breakpoint_arch_parse(struct perf_event *bp,
>
>         if (hw->ctrl.type !=3D LOONGARCH_BREAKPOINT_EXECUTE)
>                 alignment_mask =3D 0x7;
> +       else
> +               alignment_mask =3D 0x3;
>         offset =3D hw->address & alignment_mask;
>
>         hw->address &=3D ~alignment_mask;
> --
> 2.20.1
>
>