Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1496366rwd; Thu, 8 Jun 2023 20:05:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6XR5iYMpmikryo/GONeHhu8mXFNTjwNFd32e3dqwh1a6kChm+n3XN0iUcYvTQ1f/B5tygU X-Received: by 2002:a05:6a00:228a:b0:648:c1be:496 with SMTP id f10-20020a056a00228a00b00648c1be0496mr82681pfe.22.1686279943152; Thu, 08 Jun 2023 20:05:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686279943; cv=none; d=google.com; s=arc-20160816; b=zOEHS+AZ9IGU9QUPsa06SHIc6btjL/Q3qIgI5v0iMhuwvkH/C4SPDboy+GGHpSU4io TWfWo5Fwxqg7A3htw98PocPDNstG/6hhmf9+nvMtxVYWRJdcD9cUENgh/VdviS3pV37b v5rYox4Pu7hC/rPfktWVSKH4mEhibOTyUbaxvd56aX768XvZ8JsIm+s7RmW4HAgvMjea ST/fTPq5ao/if70sk2CEaa661HRli62mWMADxR9m9MWWKEex0NK6gwVymWh6B5fFRTrg 16qlPckluDfd127Xht/oQ/qa/euVdRTFV73vAOyKk8mOaN+cEvZGa71KzJjQgmKzxs9Q 94gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=D3GSncTUqs+stp12kqG8regWUG5aPI1z/agydExnOpg=; b=Ri/ZM+hFwqospESvwQiw8PRCsDTT775OwK53Xlq6rO5KM7vHfcATT6dkD5vba8Ob9V UnGOgw003tcjxjzqtnxgL8ud6HumawtUSJDM6SFbqmgaBCLwXG6rCqAhtNZThE/XQted t0qXA9znkvECO7GTfMAiA0O4aYTyLvIjSY07r2SotxoJq9lbo/CInrIqpI0qTb5K249j F/dMnprcufT358vl0pYcVS0MA7KUpFlbl0eslpJaSaPtogW1xKhUAQUUHmDxc2y7gmYK +0POPEp/+96f+yPYIFwlG0O6jRI4eLzHJb/vlA1ZQbQrdoJb+ZjiQkhQuZ/71ld3ZIxV h2Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BRu2Elui; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 79-20020a630252000000b00540ca6239a0si1905115pgc.538.2023.06.08.20.05.27; Thu, 08 Jun 2023 20:05:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BRu2Elui; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230452AbjFICk1 (ORCPT + 99 others); Thu, 8 Jun 2023 22:40:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbjFICkZ (ORCPT ); Thu, 8 Jun 2023 22:40:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F452D52 for ; Thu, 8 Jun 2023 19:40:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 623356530B for ; Fri, 9 Jun 2023 02:40:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 97963C4339B; Fri, 9 Jun 2023 02:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686278423; bh=ktOKcgJcF42n3ju25sxNzNdwoMPdtvE4MEbMAQ1sHZc=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=BRu2EluiE4XIsmXnqAhO+yMK6YmnTPrfUSpZGiVZBxWvMsPPg3/DQTGk76phbtv24 Ze9SlcZP06+/tZ+xk+mhvq93UeQjRUWFGZ7CDegayayKbea5Aa+PURTeXpiNLTKq/P xr2Vx8crx+6LjxGXCTKmCXK1W3dM1Qqa+muGic5wyf1DkGORvZ3fuf+hO1e3++2MTJ S+i4UzSDacI9yoyww31ZrDW5qSNm85bwhu+Y9F6ehmVmDt2FCghgDsTEUkM3+ihPnS /WbAZF1tP2uSqpeNxoKndK6tpLkQnCfDHuc7fCd2axvct4s7822ghB2XpNM2ylUei4 /nHk3wA5hPJZQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 7AD11E87232; Fri, 9 Jun 2023 02:40:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2 net-next] ethtool: ioctl: improve error checking for set_wol From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168627842349.12774.1205929814216417059.git-patchwork-notify@kernel.org> Date: Fri, 09 Jun 2023 02:40:23 +0000 References: <1686179653-29750-1-git-send-email-justin.chen@broadcom.com> In-Reply-To: <1686179653-29750-1-git-send-email-justin.chen@broadcom.com> To: Justin Chen Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, florian.fainelli@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew@lunn.ch, d-tatianin@yandex-team.ru, idosch@nvidia.com, marco@mebeim.net, wsa+renesas@sang-engineering.com, jiri@resnulli.us, gal@nvidia.com, mailhol.vincent@wanadoo.fr, kuniyu@amazon.com, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 7 Jun 2023 16:14:11 -0700 you wrote: > The netlink version of set_wol checks for not supported wolopts and avoids > setting wol when the correct wolopt is already set. If we do the same with > the ioctl version then we can remove these checks from the driver layer. > > Reviewed-by: Simon Horman > Signed-off-by: Justin Chen > > [...] Here is the summary with links: - [v2,net-next] ethtool: ioctl: improve error checking for set_wol https://git.kernel.org/netdev/net-next/c/55b24334c0f2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html