Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1574251rwd; Thu, 8 Jun 2023 21:57:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7pao/QNd+gzplLMsqMIbgZ04MpQPdROFcW5Yn13UNNyoAlKIc514lRxZtPpUsoWdzUigmS X-Received: by 2002:a05:6a00:24d3:b0:64d:4a94:1a60 with SMTP id d19-20020a056a0024d300b0064d4a941a60mr386762pfv.18.1686286679544; Thu, 08 Jun 2023 21:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686286679; cv=none; d=google.com; s=arc-20160816; b=G4XmfJ1Qr7R7AQKY+Y0VSgeygYAW4EDxM3X/Bsg5jHupaXx5mSjbtdysHcIeK25/1b H3lqeDt3sxIvHuROe/T+tHsuG8Aw5AgWrCbLdCLz+M6Pe9f76d0CJr/EsY7m+PWvOs5I qvOEUBeuGi9P7ytxBcMRXiR2YXT8JJ+tmfaS0dbthcr0uF5yLJvlGizE6MkxJvWbJmh8 X3faQNVNO2rBuZPahOsLaG8lADGM6pTiN0QJWmgUd6T2qeAggfjpPd3qJo027aAXbIDe 89xtSV71WiDOccpFsdac++Pz289/wzishpkV8TEimYZFLNDEXv07TWkfPPcpeudsDoM/ JMRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=b3AZE3pZJHy0qvBpCDZa5Wa/fUALhnGkfjcf5NbE0AQ=; b=PJDUyb0D2Vf9KH2y1KvjBdE9+mjtU7yT/Nr3xj0f++D9PYQtQ/iYvyZ7nbIbJhnby9 yRfShbr3pltGnSvw2/mqX/s0bpO8UjPfGX4GXQRB04TkirUl/UMhinHNrG4DdxbhfnAN TkwWbBWEml5H7+87upO/7deiHu/eYWaDS0UVzBaLMudv2mcVo8j9OWonnuczi5f42k/+ q2kPk8/wLx93tRjQPstYsjAu7w1PPoT/HDhoQvXIYEWlKB3FhJ6IvCvameRT//kFlQQo NUE2tNc4JGWcRF/WgnxQ9SldAqK7ZL1mTwXpk6gzmaZz0lsUKYEFjiRwQ8LNHkMacrV0 7z9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z28-20020aa7959c000000b0066356d0888csi1810324pfj.113.2023.06.08.21.57.43; Thu, 08 Jun 2023 21:57:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231528AbjFIEjc (ORCPT + 99 others); Fri, 9 Jun 2023 00:39:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjFIEj2 (ORCPT ); Fri, 9 Jun 2023 00:39:28 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92B0630EE for ; Thu, 8 Jun 2023 21:39:26 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 759C968C4E; Fri, 9 Jun 2023 06:39:22 +0200 (CEST) Date: Fri, 9 Jun 2023 06:39:22 +0200 From: Christoph Hellwig To: Fabio Estevam Cc: Mark Brown , Christoph Hellwig , axboe@kernel.dk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: fix rootwait= Message-ID: <20230609043922.GA30632@lst.de> References: <20230607135746.92995-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 10:02:00PM -0300, Fabio Estevam wrote: > > below) lands on this commit and reverting the first hunk: > > > > > @@ -181,7 +181,7 @@ static int __init devt_from_devname(const char *name, dev_t *devt) > > > *p = '\0'; > > > *devt = blk_lookup_devt(s, part); > > > if (*devt) > > > - return 0; > > > + return -ENODEV; > > I have tested reverting this first hunk and it also works for me, so > if someone submits this fix: Yes, the first hunk is completely bogus, sorry. I'll send the fix.