Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Uladzislau Rezki <urezki@gmail.com>,
        Christoph Hellwig <hch@infradead.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        linux-mm@kvack.org (open list:VMALLOC),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min()
Date:   Fri,  9 Jun 2023 14:13:09 +0800
Message-Id: <20230609061309.42453-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v9r7ckQ1L7KN3DSHc7dNSaH4y6K0fRJwiMZFgoJVSYP51FQsCSS1f/okyEQL?=
 =?us-ascii?Q?tLkC0A5ZQmCQbwAutVkNnxQTAUjCh0UbERE+vtTMFZGkPChgkpo2/A/F97Tb?=
 =?us-ascii?Q?U4Yl49QLC/Pe5ye3gIDp6818UxVrIdtRjsmT9AM4FrXusFErsd0NoBppwXu8?=
 =?us-ascii?Q?EloG9GI3zLKei0DfS9+5gTP+hSv1bE88V43CfVS6G8+iAakb5KVtjtHwpP/P?=
 =?us-ascii?Q?kVcTaclQgqbvEuDjvGpS6yR4IIBP+rdiDViVwD6jleKHsC9Q1ieFGwr14Ip/?=
 =?us-ascii?Q?HojZY8YfoCx0ElUBRa0PJF/CF4t7GIcE0FxBRaX/ILZCNTfToC2mwdmLqP2L?=
 =?us-ascii?Q?sffSl+WhrgqNBcX7JfoNAVFCeTi0OyzVSWlxndEofvAB07HArBciKV8X2kFi?=
 =?us-ascii?Q?434XQBtcwn0C2gMWqFmS/X1IqRbCXCOFeB+3esfvi/TnESkGA2SQAcv4NnwC?=
 =?us-ascii?Q?OgEkGCc+vzXfy+E7B2/9K98VwEvoYLq2j7WMhreNfGHLZixAbvTBTw719Swr?=
 =?us-ascii?Q?dHU+YJMyKbBUwQbKZlQG7qnKarEbA3Me8/VsDi997L9ahT3diHjm/COWcdb3?=
 =?us-ascii?Q?BKpc3ovHMUjqllw9lQQJkmz16eCoLThYbaW9WOXXz0BOmH/AaeDpRl/gci0w?=
 =?us-ascii?Q?/SXu9hk8TPa6zS3OZJk439YtpzCvKa6jNuz0Gsc51AN4N5P1xlzffm+X5txB?=
 =?us-ascii?Q?/cN2DH4XfBxf0PhDHI+BvGV4k1WKFYnn0Z/NUFkS+Stv0of1ujLSNqr9kPVU?=
 =?us-ascii?Q?cmGCzB1Ii6ihAeWpFKfW6HrNLksNXImG3f44d6EjpYiuHNvy5D64Pcr91MX8?=
 =?us-ascii?Q?DpdTNG1vLZ8RU/5NIHWZvnxvQNe31dp4cGRerxAC8O4jVuPRoULcd7FN+ZKA?=
 =?us-ascii?Q?6WxmOnYijjfhV8ae4rec/JaP4P5nktcfrat/vu0BTV2NGZa0fKixMZn2eQmh?=
 =?us-ascii?Q?Yf8hj5zn4wgvGtBKSOO1vy0Qn3uOrr39DzO+8NJNsARDGw4d5jXAzMCuIBkP?=
 =?us-ascii?Q?MUmU/bEhJd5ZgkjUpz0sSixnrXDCJivArZgRvTIcVvoeFZVqXgrtoWTe27bA?=
 =?us-ascii?Q?f8SHWZe/Uu5CeUBfKjX92aSfOiI4Io3KFAsCBFSwbrQfd456bAnGVtNXVYrA?=
 =?us-ascii?Q?YNn8mavbljp7tIqnyyZhrvM9374h25H7X7+CTMhaLmJvVrrw8z/166qNNYee?=
 =?us-ascii?Q?QuwuvtUkiEmxRS+rAMDogp35DHJYATyTSHR61Y/mM5EqP7wrNaYbTIt7cXs+?=
 =?us-ascii?Q?cQePTwbjfL0xWf5E4gu2But8WqHt/dzpP2ujsxnD27HIZRsmjf+ON7vsCfzM?=
 =?us-ascii?Q?slf2+1y8hS18fOQQgvZcjZtQeCuKegrkZ/PoIoXdcRMETSxTWI0aIypKxjqH?=
 =?us-ascii?Q?fYL+bX5N3GEdho0INwRa1/q0C6bYF+9G2oNM2EFpV5AgWXqhoQ7ht5yFrdhr?=
 =?us-ascii?Q?ATupYD8jRBJLiHUlSgpwLCtYdsQFtpkN7vwVdTZtUfgMDF6t8mbP7eOdvSve?=
 =?us-ascii?Q?F74Qism6jr+7H4j8TAIjYMiXeFhx1dLXemfVd8OQhTZbQLpYuqFIFX7gHeiD?=
 =?us-ascii?Q?lKoRTuEJKn1xV20yTBNweDg1MkzFUpxaUPbUN+qj?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82cf24be-465e-4fb4-0768-08db68b0a07c
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 06:13:22.4181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oyy19Od75rV5wcu30JY0ST0oPXQdVZHT4nM1e/6MLKpxINR0ZzuD29jMUqUEM0R4O/BgwldpkaOuyMRgc3g12Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5422
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It would be better to replace the traditional ternary conditional
operator with min() in zero_iter

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 29077d61ff81..42df032e6c27
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count)
 	while (remains > 0) {
 		size_t num, copied;
 
-		num = remains < PAGE_SIZE ? remains : PAGE_SIZE;
+		num = min(remains, PAGE_SIZE);
 		copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter);
 		remains -= copied;
 
-- 
2.39.0