Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7d0ddbeb-c7a1-a5cf-9275-e1d9634cad0e@amd.com>
Date:   Fri, 9 Jun 2023 11:42:57 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v5 29/34] perf pmus: Allow just core PMU scanning
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>
References: <20230527072210.2900565-1-irogers@google.com>
 <20230527072210.2900565-30-irogers@google.com>
Cc:     Suzuki K Poulose <suzuki.poulose@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        John Garry <john.g.garry@oracle.com>,
        Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        Madhavan Srinivasan <maddy@linux.ibm.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Ming Wang <wangming01@loongson.cn>,
        Huacai Chen <chenhuacai@kernel.org>,
        Sandipan Das <sandipan.das@amd.com>,
        Dmitrii Dolgov <9erthalion6@gmail.com>,
        Sean Christopherson <seanjc@google.com>,
        Ali Saidi <alisaidi@amazon.com>, Rob Herring <robh@kernel.org>,
        Thomas Richter <tmricht@linux.ibm.com>,
        Kang Minchul <tegongkang@gmail.com>,
        linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org,
        Ravi Bangoria <ravi.bangoria@amd.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20230527072210.2900565-30-irogers@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UExZbThxTXF4UWkzazdydXFJaTdOYWtCY2lCWjFxaXVrRkFBNzdETDQvZXhy?=
 =?utf-8?B?N2szQ1JpUmR2azlUaWpraFIvRXhwd0RNbW9jNmxBbHM2MkxVRVFRcG1iMXFF?=
 =?utf-8?B?a01ZbGVEU21DM2ZNZ0E0NVJjU0VwcHQzTUNLdWZKQXVFSDUvdDB4NEdpdisx?=
 =?utf-8?B?Q29jOUMwTE1MS3o0ZWtmY3hmWE4zSDh4cDd1Wk1HaXlPUHJSazFYREE5UW1w?=
 =?utf-8?B?UnpGbnR1dnNUemwwbEw0bU01THNBZ3YwT1ZoTG1PZjVKZFRpVFJ2VFZKb1pR?=
 =?utf-8?B?UnJkV1MybUdMMjJLenJYRkpUK2ZycTVzSFpVMTZYNGRqWHRQdU54NEZxNGNp?=
 =?utf-8?B?YVVWekdnUVgzRWRlYVUwckc5a1E0VllYOFladk1jOW93RldQOThpZ242VzZM?=
 =?utf-8?B?YWVmYzd0QUF6bnBrN1BaY2hUWFdaWnBZaW90ekpTb09SWU10Z0RGV2t2T2dI?=
 =?utf-8?B?Rk42QkQxR2RZVlNvUHE3aVhXdmhiblBDTkVqKzZDSytMYUZIOWgxcEVoblJk?=
 =?utf-8?B?aWtmcm9XcTBKQ3BxT2gxTExGRWR2RHJwc0w4LzdnL04yN01pVnk4Zzk0VVJE?=
 =?utf-8?B?MVdhRUFPeUF2RjQ4Q0Z4WEVYZGNzTG9uWHg3ejBWcGREWUxNWEtKMERJM3BJ?=
 =?utf-8?B?aWhlOFpaaHhRcHRodjh3aDFxcU81cHpQd0xNNDVqWFBqMEgxLzlHc3I4U3ov?=
 =?utf-8?B?RlhOMThoMTNwaEkwaUdPdU5STWVLckNDZk43Z2ZGdFFHN2R2NEl3QTB5V0l2?=
 =?utf-8?B?K29aQitTOXIzTmFoZTNQazBYK1IwZlJ4OXdZVThta2FObmt0ZGUzYnk4SWJR?=
 =?utf-8?B?RE9mS2FMTWNBR3k1UENBT3R6Q0o0UDhCTGs0M1BORy9vMWMrMERHQkl0MnlI?=
 =?utf-8?B?TUVBbXlGQXJseGl4M1RDalZtNk1xWDdQMVlrK0lFWFJWWDVqczlQamFNREU0?=
 =?utf-8?B?SjF2cGlwRDZybWxJZ212aC9JN2ROcWU1L1ZHSkRtcUFmdFFyRzVRaGtEQnZQ?=
 =?utf-8?B?bDIyUVA5VS9OVTNCbjVObko0bTdHb2hERE1nMDZBa3BjL3p0Ty9lcFNqZW9q?=
 =?utf-8?B?ZDZGUlVxQkUvakRrUlUxb0FFRGg1REpWNFEwQU9pelA1amJkWHBjU0dHZ0Zh?=
 =?utf-8?B?OE04NVBtekh5bkRGYkpmZjN4YUhMYWtWTllxKzZIUXJUZ2dVakF3OTZnSWhO?=
 =?utf-8?B?NU9IdHNsVlJHc1lsQnE1UlN2V1NUakIzNnpMbEQzb2hma3FTMWJ0OFdJWjFS?=
 =?utf-8?B?N2xLVHpuaWpRVWkzbXFPN3puczUvVW13MkRFcEdhcUowV3NPUXFROWxpRFdt?=
 =?utf-8?B?VlozNitHRVlTTmI5RXBLY25UUXY1OWhCKytDYjRpeU5BbEh2ajEvWHV6TlBF?=
 =?utf-8?B?d2RyVTFMcmVEamZ5dWNKSndlUVFCY213b0F1amhROGsweklTdWFXQkxyY1Nz?=
 =?utf-8?B?ZnovbGNLdDBlTmR2aFFaaFI3UVFNc3hYUUJ3VGJkZFhKRmZ0Y3ZDOWQ4SEpM?=
 =?utf-8?B?OG0zcTBOTytLakc2Z2hONmIrZ0V3QzZqVUdsRSt2TWh2TFg2eXF2MU05UTRS?=
 =?utf-8?B?eU02L2t3ZW16cnBnN3JSQ2U0My9tciszamRjMmUzR1greHlaeWFJOWhsN2dF?=
 =?utf-8?B?L21vR3FuNlRUUU84RXlVbFFhWE03TE8vcWFuRG9kYTY0YmdHSlpYL3BMZ1JD?=
 =?utf-8?B?UDdZRERkaGs0OE1lQkVkcG9FdGpOOHlyWFdsYXlRcmtFM3JZUmt6NDMvMnYr?=
 =?utf-8?B?K25aVDIxRFV5UTNobnVwdTJ4REF2cVpPdDhpeWZ5cXR2dDZIRnFZeDBVWWRJ?=
 =?utf-8?B?RXJDY1dTczZyUzJwckt3b0psbmVJV294M0tSVEFjVEZaelk3cUxZYTBBUFJv?=
 =?utf-8?B?UU1qc2VJUGR0RXlWN29BbnpXR1QwckNoWDl5Qk5zOEdteXpVOS9BSVFhL2RE?=
 =?utf-8?B?YjcvT2ZxWkEzODkxRHdvL3MvOElzYjc1OWVGd1dnT3Z3QnNwNU4xNHd4Z2d3?=
 =?utf-8?B?Mml1M09qenBKUjA1U09keHkvMHBNS21xcERJbmw4ME56Q0lpblhaWkRXTVpR?=
 =?utf-8?B?NkNpNTNJTXhuditIWnlJc1NvaWh3K1UvRy93cEFNQmZiaExCY3I5b0tLb0hi?=
 =?utf-8?Q?T3A8pcadPp4r6wPdsBm5hiOYs?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d439562-e136-4a4a-360b-08db68b09b34
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 06:13:13.3908
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 18unLZue6oFlNpeqZyYNukrWM7nQfZZvvXsi1lEKnj4nrf3N46sge6x7I5YH3Bfu1ezbrRmbobDfv8Klvs0O9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6938
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ian,

> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 08ac3ea2e366..c5596230a308 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -136,10 +136,7 @@ int perf_mem_events__init(void)
>  		} else {
>  			struct perf_pmu *pmu = NULL;
>  
> -			while ((pmu = perf_pmus__scan(pmu)) != NULL) {
> -				if (!pmu->is_core)
> -					continue;
> -
> +			while ((pmu = perf_pmus__scan_core(pmu)) != NULL) {
>  				scnprintf(sysfs_name, sizeof(sysfs_name),
>  					  e->sysfs_name, pmu->name);
>  				e->supported |= perf_mem_event__supported(mnt, sysfs_name);

As I mentioned in other patch, AMD ibs_op// currently belongs to "other_pmus"
list and perf mem/c2c uses IBS on AMD. perf mem/c2c on AMD are working even
after applying this patch because e->sysfs_name contains "ibs_op" and thus
sysfs_name contains "ibs_op", although pmu->name is "cpu".

Let me try to fix it. Suggestions are welcome :)

> @@ -176,10 +173,7 @@ static void perf_mem_events__print_unsupport_hybrid(struct perf_mem_event *e,
>  	char sysfs_name[100];
>  	struct perf_pmu *pmu = NULL;
>  
> -	while ((pmu = perf_pmus__scan(pmu)) != NULL) {
> -		if (!pmu->is_core)
> -			continue;
> -
> +	while ((pmu = perf_pmus__scan_core(pmu)) != NULL) {
>  		scnprintf(sysfs_name, sizeof(sysfs_name), e->sysfs_name,
>  			  pmu->name);
>  		if (!perf_mem_event__supported(mnt, sysfs_name)) {
> @@ -217,9 +211,7 @@ int perf_mem_events__record_args(const char **rec_argv, int *argv_nr,
>  				return -1;
>  			}
>  
> -			while ((pmu = perf_pmus__scan(pmu)) != NULL) {
> -				if (!pmu->is_core)
> -					continue;
> +			while ((pmu = perf_pmus__scan_core(pmu)) != NULL) {
>  				rec_argv[i++] = "-e";
>  				s = perf_mem_events__name(j, pmu->name);
>  				if (s) {

Thanks,
Ravi