Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1670926rwd; Thu, 8 Jun 2023 23:54:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ78liWKuH6ozJqNfI61fvKUsIWjQc4/Rh1iZiIle5A/QD8psDQspzPL66LsDQfs/Ua7yatw X-Received: by 2002:a05:6359:a9a:b0:129:c85c:cf40 with SMTP id em26-20020a0563590a9a00b00129c85ccf40mr599091rwb.6.1686293688440; Thu, 08 Jun 2023 23:54:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686293688; cv=none; d=google.com; s=arc-20160816; b=NdEm3BnOLOMzNjMaPkFw0+uyKg3cxSD2v3IEtEsbXdnvxnyhnIOuHCfgTO3avtIl5N reCelnj3CbZl1k8CssS/UmEjEQCZJWsizbOrQdJrOsEHjObTVFbxo6HJLdLyC76zSbQY OYyBSNazWqPqEDi66G3tZrVLogIMsnGPGsOfxMb5oNKHBRmQi7bL31Ho/aSC/rKd5ZfV So3NdcuQceFTEKYgzm01XS7vQ8dG8qc8GAzzS1naidmaA2LPbeMy2cs8K64iNaGOEKz1 7I/3B9dDs4MR0gyk5JPyoymwejnyrWnnXqM+2E3rj3+L6O2MMXjQyXos17fZBfNPnTiA Dt7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BUjwNr6ruomDs7dn4sP1CyL3qOpF8udLDbstESVqyqc=; b=kqBmpr2hJqtCcn1HkNAK0kdLnTx5SZMDIgFDpRf6Zbz23hnGVw5hRRjxkap9M8hXwu CNp2E9YImoj9GkEEOM8cnGpk70m98UHZ/CPtwWsIwtI4xzG2lkfSLmqa6H4M6oYGPQem KS+Bhua7S2DFKMjjDkpTXib/VRYseOxPsQGS86m0KXXqJAbvdiigpHpNTomdvvNLTojl Q6VT8f9HU4+3D+Nds99LCpIWnDmeNBbZuJSYZR5gr4Mkl3vvJh5THoplQ7cuXni/Lh5O p7z9/V/LxoOBw6eiuFrtQavqO4JEDEz66UfkJ1m4bjTHgzxf76qz40PcrORUWouJnSSY 4IKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="vQBKO7/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c6-20020a6566c6000000b00543e3449f28si2107114pgw.616.2023.06.08.23.54.34; Thu, 08 Jun 2023 23:54:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="vQBKO7/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238517AbjFIGoB (ORCPT + 99 others); Fri, 9 Jun 2023 02:44:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238494AbjFIGns (ORCPT ); Fri, 9 Jun 2023 02:43:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52C693583; Thu, 8 Jun 2023 23:43:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DCB706518B; Fri, 9 Jun 2023 06:43:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5FEBC433D2; Fri, 9 Jun 2023 06:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686293026; bh=OigEpXeDQ3rSjSeIS+qK5il4XD7oD1uJZU95Qjncfhc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vQBKO7/FA/TCVQks52BvyricJiVPMBi09wi0+W4+I57MgVlaTg3P1F5bgIyIDlpUn r1UvjhUxxnsB/JpU0f8aBLGP3N1jYsVrLhVS3r5+ZmuLGJqzlr2qIewLNCney5ZZnp nLc5/cqVmh/CXFqxsd2KbfTX8aHIPw81h3bCCf+JOzZ4yAktdgQCwGCIJpDgi0ufqd Q6U4eZamVEdblQqjWIiJ6ClL+FvKAihGpEaIr6PYwU61nmbJ2wUA6OlWM+ApmAAh8w qvs74xLG3JT8mal+JRHaRA3OaCSFugqyqXXuAl2dya1+9Y2dG5v1c+hgczyyOiRcVH 1bFw/0Cy/TIuA== Date: Fri, 9 Jun 2023 07:43:40 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: pavel@ucw.cz, sean.wang@mediatek.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Alexandre Mergnat Subject: Re: [PATCH v3 6/8] leds: leds-mt6323: Open code and drop MT6323_CAL_HW_DUTY macro Message-ID: <20230609064340.GI3635807@google.com> References: <20230601110813.2373764-1-angelogioacchino.delregno@collabora.com> <20230601110813.2373764-7-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230601110813.2373764-7-angelogioacchino.delregno@collabora.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01 Jun 2023, AngeloGioacchino Del Regno wrote: > There is only one instance of using this macro and it's anyway not > simplifying the flow, or increasing the readability of this driver. > > Drop this macro by open coding it in mt6323_led_set_blink(). > > No functional changes. > > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Alexandre Mergnat > --- > drivers/leds/leds-mt6323.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied, thanks -- Lee Jones [李琼斯]