Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1726684rwd; Fri, 9 Jun 2023 00:57:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6mo0hgQZ0Q8CG0vmcWVx1Pp5DO5PZB26YDle4051RA428nl8NJutPUpc/J3HamiybKaWPL X-Received: by 2002:a05:6a20:72a4:b0:10c:b1b0:3ee3 with SMTP id o36-20020a056a2072a400b0010cb1b03ee3mr1284979pzk.21.1686297442007; Fri, 09 Jun 2023 00:57:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686297441; cv=none; d=google.com; s=arc-20160816; b=MpScJe2uW2ukoRXPQFq/k7Wt03qoWvDVlE/i0TvZ4onLru0RpdU4iulLJHw5AcFU4P tzRGNwfml3nEIsLhUxsrZIEVjGlD58UWe+zXZn2r+eFmH5i1AgBZltG8B2uUI/QMBZRi oRHcY/AM6pWjb8zq8ty7/jlaryflcl8RN4Lcp9X7tR1VeUF1/xCQDXnBV6ZLrFJlf8S/ Nqc1XHNHxB02FLcWttmd0USq7BPXjRoS+/ySTmmAIy9Zm5cwbAAo/owDj0aFL/pp1cDT FQsZX8pQBO+Y9Dx1IyMhqJDgZWsJUFqu1NXNFi58P4NpVEkUU0YYP3wtY787nEluS9qD JFdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=n22j43EkOQDg32COrHKfr3M00AZ/0ZWY6HKFgde4cL8=; b=NkN4xaHhdF4ezQskvIqJW/2rdB2Lv7T8gzobnM8UV3Ua0Vox8e1jkW9KUiD7Y4CT1c 4AiWLa/gr+l90K9Z30hbsll8pxDkdwYqXUXfZCDgTbQ0hXPRmFoCox8ahjqH8ODW/A89 UJlf+QIaG8+A00oPIe+xkUZLPi5y/Qc3F0j4W7YPkRP3IfUMnKpauTzgBHfSWQrCPuDI 3EELRm+APD9O288kEbAZl6jMGpe2SpMBnAdKfyf5iv+pwHgJ6p79RihO1YeSOm2kDySg UBZYxG4roOJQbLbXLG0V7wXGs4F/RuofFyRhElngHT+lJYpNmdKlt6i5dAWWdbEQzWOz dMVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xigE4Ds2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c28-20020aa7953c000000b006620f8fae9asi2104425pfp.371.2023.06.09.00.57.09; Fri, 09 Jun 2023 00:57:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xigE4Ds2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238959AbjFIHn4 (ORCPT + 99 others); Fri, 9 Jun 2023 03:43:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239093AbjFIHno (ORCPT ); Fri, 9 Jun 2023 03:43:44 -0400 Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D7222697 for ; Fri, 9 Jun 2023 00:43:37 -0700 (PDT) Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-569386b7861so38427937b3.0 for ; Fri, 09 Jun 2023 00:43:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686296616; x=1688888616; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n22j43EkOQDg32COrHKfr3M00AZ/0ZWY6HKFgde4cL8=; b=xigE4Ds2RloULZ1O7n6QdIj7g5n2MHKcla3NMyQcPNgn5oDy4jmszVsyLksPsHVQ2A pdTgGqULLsN/GWX785OV8mjaD9L5iIIbCf1o2AOgNYz/kpjdiquJcXhSBq/KlSlfCHMD FVE+ue6kL2EzWZnfjSkN1Zh0QzWQQuBmr30bqi9Sv+tSN7kzZl8ekeDQkNacQYhA6IKO 0rHZuBXwAke6tqomTNYQsdThwDv1LBeb1x7hDit7QKtvi6nwfoc3BAYGUrVXwg9QNVwU 6vYIEMjYU17LaHu0SAsyVKCP85LRm6VlMrbsXuCaVYuwSDzadNNSdruuUbIcUxM0FPoc rlPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686296616; x=1688888616; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n22j43EkOQDg32COrHKfr3M00AZ/0ZWY6HKFgde4cL8=; b=UYIN89IV/YWVGPhEPTKd+1XzpegxgLvObqa1hBdTs1FLoskGP4YQjDmDaPdeyx2EnM fEh8MAmhd8qPXgRPivcyHYw0T2kl+hVGH9lUmSfkvcQzIyYkz2XW5D1Uwqi1fdRRTZb0 d/heLDL1q9/LaA0cexhPSBXb0byXVscsiKW/4DRDYcBZoKzAOAHQyCmXDEEkR56KH0dg wRzi8YMgtBiPoeviUS+DxdaHyms6iSJAVwpmcVomfpIM841FieLTsOMiGMmbF9GUVzFf jsTx8GIhOZBPK2GNJ4O96EszcGYjF7n76t7a4NGG4N0gm+esXFoyfl0vEcOZB7nGL+Ml /+Dw== X-Gm-Message-State: AC+VfDzATJgytRMwXn3lfqkpaxWfMI9Q8QN9qhN1s1lyoGNXJQZPN7Uo ihafNPgISrF+S/hWS05rJxHaeJY1YK/L+5fTZV5ERQ== X-Received: by 2002:a25:11c6:0:b0:bac:ada7:140e with SMTP id 189-20020a2511c6000000b00bacada7140emr1128433ybr.9.1686296616503; Fri, 09 Jun 2023 00:43:36 -0700 (PDT) MIME-Version: 1.0 References: <20230607095829.1345-1-jiasheng@iscas.ac.cn> In-Reply-To: <20230607095829.1345-1-jiasheng@iscas.ac.cn> From: Linus Walleij Date: Fri, 9 Jun 2023 09:43:25 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: npcm7xx: Add missing check for ioremap To: Jiasheng Jiang Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 7, 2023 at 11:58=E2=80=AFAM Jiasheng Jiang wrote: > Add check for ioremap() and return the error if it fails in order to > guarantee the success of ioremap(). > > Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driv= er") > Signed-off-by: Jiasheng Jiang Patch applied as nonurgent fix. Yours, Linus Walleij