Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan Corbet <corbet@lwn.net>
To:     =?utf-8?B?w43DsWlnbw==?= Huguet <ihuguet@redhat.com>,
        ojeda@kernel.org, danny@kdrag0n.dev
Cc:     masahiroy@kernel.org, jgg@nvidia.com, mic@digikod.net,
        linux-kernel@vger.kernel.org, joe@perches.com,
        linux@rasmusvillemoes.dk, willy@infradead.org,
        mailhol.vincent@wanadoo.fr,
        =?utf-8?B?w43DsWlnbw==?= Huguet <ihuguet@redhat.com>
Subject: Re: [PATCH v4] Add .editorconfig file for basic formatting
In-Reply-To: <20230601075333.14021-1-ihuguet@redhat.com>
References: <20230601075333.14021-1-ihuguet@redhat.com>
Date:   Fri, 09 Jun 2023 01:50:00 -0600
Message-ID: <87sfb1oz13.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=C3=8D=C3=B1igo Huguet <ihuguet@redhat.com> writes:

> EditorConfig is a specification to define the most basic code formatting
> stuff, and it's supported by many editors and IDEs, either directly or
> via plugins, including VSCode/VSCodium, Vim, emacs and more.
>
> It allows to define formatting style related to indentation, charset,
> end of lines and trailing whitespaces. It also allows to apply different
> formats for different files based on wildcards, so for example it is
> possible to apply different configs to *.{c,h}, *.py and *.rs.
>
> In linux project, defining a .editorconfig might help to those people
> that work on different projects with different indentation styles, so
> they cannot define a global style. Now they will directly see the
> correct indentation on every fresh clone of the project.
>
> See https://editorconfig.org
>
> Co-developed-by: Danny Lin <danny@kdrag0n.dev>
> Signed-off-by: Danny Lin <danny@kdrag0n.dev>
> Signed-off-by: =C3=8D=C3=B1igo Huguet <ihuguet@redhat.com>

So I must confess to still being really nervous about installing a file
that will silently reconfigure the editors of everybody working on the
kernel source; I wish there were a straightforward way to do this as an
opt-in thing.  We're talking about creating a flag-day behavioral change
for, potentially, thousands of kernel developers.  Something tells me
that we might just hear from a few of them.

I wonder if we should, instead, ship a file like this as something like
Documentation/process/editorconfig, then provide a "make editorconfig"
command that installs it in the top-level directory for those who want
it?

Or perhaps I'm worrying too much?

Thanks,

jon