Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1759373rwd; Fri, 9 Jun 2023 01:31:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ64ZBZpAiqhJrfsfwgL4GoaQoggU+vx4ssh5IT6FuVCrxLyYcH+yzwEg5iYDYZO23h6Wrkg X-Received: by 2002:a17:903:1c8:b0:1ad:d995:54a with SMTP id e8-20020a17090301c800b001add995054amr457697plh.46.1686299467276; Fri, 09 Jun 2023 01:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686299467; cv=none; d=google.com; s=arc-20160816; b=Wzpk1s2P7dymLXBuhib4kI6nkemMJvTxRWnbCoN1iGlNRP3Y1Itj1fFkxcvzdkJ01Q pdLGPFpDRvCrOFkQv9VgzqJ+fJSzK0lg8etCS6TyYcuatUYG5VMETzwcO0SrEtvF3/Hd Jgc81DLfBzEccoYhMYU2VdIiz5QMhZvO+YM7HGby07i/UB5WnTTRrGAbLwVVrko6qpnx 8z4Xa1qzklwxJKsvtY3LsOL3STk8MovxY/U+Q2t2qPXVX7FouJGctaidbQPecnrTLmfL 4mlXqZqYhRZ3W4mMKkDYoi5qrooGodnVBJB0TqAfWFlTP+oFTpL234Yla7gMh+36Xclr LlSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=o3c2ntYAOnDdSkrfl6TadBZmpYpoDIkLc1TtVzVrRJ8=; b=TnrSsZzSA6j7Iavp613pdBQAokf3vXjpHwBK6QVamC4pFeZp7zfkvZeEMm+3p0FsUu hZLVQO/ycxJKtSLUENk3bavNep3rdUNVOCUlEWnKtQlj3rKpY0qlRP0M3WbMpYrhmyKX 19P8UbIPGXRPwH9XMmUlF3mTG//3+E9wXMyaUT9sSvWAInJj8IR0QNcHj5W3UyKgUpV/ SzeXcupcT+Ap9kS9X4NPDHc1LIBgMddiZPc8xqYZ20uMlF7aZ3RG6B0J3I6OzBG1Wv8i 4gAXUTyI/7K1IC9HJF7v8AbQEJfEnimWy7iO9fctkN9igwNirn/zPdp9pQ/1n22oeATF YwHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IKrGMIFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lf8-20020a170902fb4800b001ae4e665c60si2321699plb.156.2023.06.09.01.30.54; Fri, 09 Jun 2023 01:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IKrGMIFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239421AbjFIIGs (ORCPT + 99 others); Fri, 9 Jun 2023 04:06:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239471AbjFIHtn (ORCPT ); Fri, 9 Jun 2023 03:49:43 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A523AA1 for ; Fri, 9 Jun 2023 00:49:21 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-568ba7abc11so13492327b3.3 for ; Fri, 09 Jun 2023 00:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686296960; x=1688888960; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=o3c2ntYAOnDdSkrfl6TadBZmpYpoDIkLc1TtVzVrRJ8=; b=IKrGMIFZ/EjMmj9mSBuFlJHyclCyZWfGsF9i5dacTEK78et2kPUekz7nYsXJRvbKVu AAlWv6lnPv4lVG3NxH/xCOskpaEXs+dwdY0EIGAiyA16DQVL9Tefc2AiqbVpPyfFiE08 QrzR0llTMHM2kimq7fy7i6XtLWK2at8OpZYgQ3YGV8WXP0sqnDxCsP1Fei6uUeV2a8mj P9TM/TEh+u3CjCtabvhK/46qAB4NJOoLQUNwOnhuV/2dwCFJNvTXZD+zJz3aqKODPSAo /NqsIuD9Fen1gD303bC7MOIdDxxkt6Lewdtj4IKv9w/22g+yUWtAwUjjZ+8MGd78ROOo ZtMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686296960; x=1688888960; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o3c2ntYAOnDdSkrfl6TadBZmpYpoDIkLc1TtVzVrRJ8=; b=QYi2siGRXy4UP9+BV8CnDZ3yrnm+4rw7QYuFCwJUmLlUwwBQVSt6eB+vothxTjOMvV USdC/mvGNV7rn0IuDbFTThP63JYoWEd1SHbwpeORA7JjiUReLPuom23yNpN7PeikqC4d Eg/rJ26QgtXgPjV4DpU/R50zhhcCGJzhyTq834tooyJPKWubbvJTV7PyaF6llvOlKw9L C/zgyeSKdYYhnB+Dnv6Qfhne6DF8ahY5cXJC7l5Tje0cnlfUWaqihIBkSFMwuF8bbmT+ 2yx/1c8Dp5jZM3ZQ2SA1hm+V8R93pNXiCXHaGEuC/GDXtoXG8DJClWIPLbIWTSQydo6f 8GHA== X-Gm-Message-State: AC+VfDzICVAQSYSU4e/SOULHzr7wNbrjm/1F16U33waKkwZYpKCjKhWl kOlw13wS0u8RwME96jvpK0gA8Ou6cgxX3pCIRPrxAA== X-Received: by 2002:a25:a349:0:b0:b9e:b9b4:bb12 with SMTP id d67-20020a25a349000000b00b9eb9b4bb12mr370346ybi.48.1686296960015; Fri, 09 Jun 2023 00:49:20 -0700 (PDT) MIME-Version: 1.0 References: <1686249772-26231-1-git-send-email-manikanta.guntupalli@amd.com> In-Reply-To: <1686249772-26231-1-git-send-email-manikanta.guntupalli@amd.com> From: Linus Walleij Date: Fri, 9 Jun 2023 09:49:08 +0200 Message-ID: Subject: Re: [PATCH V2] gpio: zynq: fix zynqmp_gpio not an immutable chip warning To: Manikanta Guntupalli Cc: michal.simek@xilinx.com, michal.simek@amd.com, git@amd.com, shubhrajyoti.datta@xilinx.com, srinivas.neeli@xilinx.com, brgl@bgdev.pl, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.goud@amd.com, manion05gk@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 8, 2023 at 8:43=E2=80=AFPM Manikanta Guntupalli wrote: > Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE, > call gpiochip_disable_irq() in the .irq_mask() callback and > gpiochip_enable_irq() in the .irq_unmask() callback to fix > "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning. > > Signed-off-by: Manikanta Guntupalli This v2 looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij