Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1774949rwd; Fri, 9 Jun 2023 01:49:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5G9RHiDZZ9fBXWwUw9y519bIdNtlIwk3qVUsrJRKOyzKGN9XsELacI/a+ORAhVv+tvUhsH X-Received: by 2002:a05:6a21:6204:b0:10f:1d52:93c2 with SMTP id wm4-20020a056a21620400b0010f1d5293c2mr386719pzb.28.1686300578092; Fri, 09 Jun 2023 01:49:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686300578; cv=none; d=google.com; s=arc-20160816; b=phHnzjvn/0jYO2jk5SlJIAA2kzN8u3sUu6/YwrD2uDtW7gpB2CVD8w4fSgpzB4nxj0 6etqtS0uCIoYbUwDAu43QfGm2NAMLWODjnQ5vSWr64/Zxy90bDrYW6S47a8EsYSQXv2J 9ylR5dLx2W993cXRYYEf/64FiwgBnDFENOCppPpQWGlSVBb+RKWwvTdu/CifGIpA0kXL CnevfR+qSb1bM0ai35ypELrcn4wf60SoznQTb3oW0bMmPm3YiXenMCj5usA2/kmGEuYt SbDE3vHPQZSrR5YSiBdaJWN5a0HWzPn737RTZ5+/1HQbqpXNbQ1yG5KSUpBg+DVH+WEj md2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JmfrwfHnNLcQ3yNKqCYFGPId+iWD3Jy2GcJX9yVV1O0=; b=x299yRa8K2zts4nNj3thW1SpcwLFJHLlDtQPxW6bSjoc8t0zU9B5CmKnh/P4HALWAL Z8IFki4T1n48VCXY8KrIc+ql0qfLJ0cmFpmfBvTzEdcrN7Us/e2fBfCPxh6Xyha4Ac2T RXsv1krVfn+DyzT7+zx/2Jen3TLnIlqEAjx3netEqADdsfj9JBHOGp4B5K8mnIx+dCg4 33RqdGspmgTioIOtgg6QJk4DTOa6ziSkrsmJKnkYvdrKLnF1Slpz7oxVvALhcfDgtzIX 3Cn0hq4HrUMF72HZOlsH/uSCl+bOQVYWgaifPzy6lIMYClo/9QXV5GhyXtCsEnmfoGz5 PE/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BcRxzt6S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y28-20020aa79e1c000000b00653b5ab16c3si2162589pfq.265.2023.06.09.01.49.22; Fri, 09 Jun 2023 01:49:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BcRxzt6S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240970AbjFIIlS (ORCPT + 99 others); Fri, 9 Jun 2023 04:41:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239457AbjFIIlN (ORCPT ); Fri, 9 Jun 2023 04:41:13 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 800742D7E; Fri, 9 Jun 2023 01:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686300066; x=1717836066; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XFEmxaqYNZWfe7AaILsM69VZtz6IwceTV5OeCXpNMVQ=; b=BcRxzt6SGXB3PqUOIro/BI03dyXKJJvkLhZrNC6ASLBEKywLrIbaVp6W +r3YMm+dHodm5oQFOKMuqdYf6474Y1uDU1LnGFL/9LWUw3n1SSwTBTNhq gSPf3D4KaGXTXl/rFDuGr+3DWXZzCTTWXYnvBKh5CEpQYTl5T5yITiIQX 55qHfez1Tk7m4FgbkEOFB6ckRocPAgvjeZxxGQlBOUIMHmrsdJ2Q1JFfl 8iaCZNiV4NN576FTHYq1VtD/xVq0TQt6Sl9MfxyBnSDJBsVDv7e7bGQ0q AQlGfqfhenZYnJ7K2WGzFLfofdDmFflXfs3YQFtSHSqsOJEYBrjDVyi7J Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="356442515" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="356442515" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 01:41:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="822978051" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="822978051" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 09 Jun 2023 01:41:04 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 1A49734C; Fri, 9 Jun 2023 11:41:12 +0300 (EEST) Date: Fri, 9 Jun 2023 11:41:11 +0300 From: Mika Westerberg To: Raag Jadav Cc: linus.walleij@linaro.org, andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com Subject: Re: [PATCH v2 1/2] pinctrl: cherryview: simplify exit path of set_mux hook Message-ID: <20230609084111.GN45886@black.fi.intel.com> References: <20230609083356.24849-1-raag.jadav@intel.com> <20230609083356.24849-2-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230609083356.24849-2-raag.jadav@intel.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09, 2023 at 02:03:55PM +0530, Raag Jadav wrote: > Simplify exit path of ->set_mux() hook and save a few bytes. > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-34 (-34) > Function old new delta > chv_pinmux_set_mux 640 606 -34 > Total: Before=19233, After=19199, chg -0.18% > > Signed-off-by: Raag Jadav > --- > drivers/pinctrl/intel/pinctrl-cherryview.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Ditto here regarding simplifying.