Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Uladzislau Rezki <urezki@gmail.com>,
        Christoph Hellwig <hch@infradead.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        linux-mm@kvack.org (open list:VMALLOC),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH v2] mm/vmalloc: Replace the ternary conditional operator with min()
Date:   Fri,  9 Jun 2023 17:26:02 +0800
Message-Id: <20230609092602.26412-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ynKZaEZhLo6EPYhMwJ9ODASO1rI/qvuH/jkCqNGIBZFfuevYsN9TJS3kPkNM?=
 =?us-ascii?Q?bCMegZjAm9Vhsr3i9YplJSpqGdnHK9WvUxjo9rr+Z45ww8fLpopOUpIEoQfY?=
 =?us-ascii?Q?oQHug2ub+dTuOrEGbMYyCGReeYlrw8ted4//P/SZ4Bs24SqgJwrZUHhnear6?=
 =?us-ascii?Q?KE8D6H8VJTrQp654oALRaxxRKpR+tdJ/kXZhT1onozHx0jnraEhnGgpkTIuD?=
 =?us-ascii?Q?VdHNMVPe5R0VrYmolvZDkyIhfcw4tYLxpslBgOvelty7A3ibyTF8uUqyW/Yq?=
 =?us-ascii?Q?hRItMf9yjLhDyMHUGPi1BgTSSqVinTemAv4DW9uAPGZT9OiaZ46X1yM89/OC?=
 =?us-ascii?Q?UDuEeQYtsXfwjToaJqCbt2MMw/CGpKyZ/EGHJSt6lsKn1+JblkfyCKNDd13/?=
 =?us-ascii?Q?Ccme1D1I8Ro3KEOpmXL7LmrlV6vJOg8GRGUkgp6jv74a9t/9vw6rCbtVTu50?=
 =?us-ascii?Q?g9XxwizbVNOALGx1xAXAFzqPvj4OW8wBKL/aOKno+a9pONPCYU/FgrAa7sx1?=
 =?us-ascii?Q?dTDIFh263Ylr4BsyoyQ9lgY8MtNYMMqSvNx3fh3sx9qc9Oh6UfbwgNhVIMx+?=
 =?us-ascii?Q?9C4Tsx0pepnxRLHYqhF6TNAH5OMi3tfnYiTL3zzbvEmBgFQ8tvUOZ1k5c1w7?=
 =?us-ascii?Q?0xI55IEC0upkDaicHtZFbTy0EQ8UkENtL3BTKVVEUBkC/dQIqUZbj95INCUm?=
 =?us-ascii?Q?SqL+Aco+UWXqjMnU886PsgtoTio7+e2YDN2VW9gquDm8HDwE4eQFAziECxxO?=
 =?us-ascii?Q?zZ4laPTlHiHUrIsX/8KOg9wLUpZTqfMDBVLdg3ZIwcjbiOll29YfhjghrVbB?=
 =?us-ascii?Q?wT+Pe/M5xBk7bM5fkr8/OjSq63lNYDnu1yzHyidwewVXedN+nuikIdAndpnb?=
 =?us-ascii?Q?9Y/8AwN55RcXyxBwGOIQnkjtofKWzZ0Uq3k4viGQiTPrNvAPXKSXMLvJceCO?=
 =?us-ascii?Q?VpkwnlSfkdVATFkdVJUhy6/Sc/PbW5itAZCQab6AAlZHukUGXj/uT0phwJuo?=
 =?us-ascii?Q?X1kvxrtIYs4jj/9sSHa1BZwfcr6oAuVsfzkBxSUKP2Xv98Xc0wZAVufENL68?=
 =?us-ascii?Q?QfRZtXFaSotzEj1yldvAWyDf6oSuGFk5eppG80olQRwKQD8AGOgG2l41NhXJ?=
 =?us-ascii?Q?FPkzg23yEMC2LhYHDY73ImlJWAc0XjInmQoLhSiHgQ/SsLhe1+MSknuBjQRE?=
 =?us-ascii?Q?wWI/7Z1f9qHXFJWVt7rHXwZj38eDEBk4795sYex68a4XQ69arbxTyS5ZhnXy?=
 =?us-ascii?Q?zF8BgICMD4LnVBKdrto2s7IAHpMdiNSEnoCyVLPbsrwW4BJuoEOOdnEQHKMF?=
 =?us-ascii?Q?ZdaWYbdOB/sTRbaqFVXXnouoaLTaXsbJSKf/Q+BL1GlvWH4MSu56Lp5U5zNd?=
 =?us-ascii?Q?+6BLswcv1cZ0moK9aMhJE1LkEwU5s3E05/riTrJ2axmxN5eT75ZqgYTP6Tz9?=
 =?us-ascii?Q?21rk69bOYYg6rz91EhT8Y/TlglYCunOcKRHus7EYIn3m2LQCegNZ9lTR6DsD?=
 =?us-ascii?Q?UiMbbH9XnCgpOsi+adEXh9kICW/cTxQKPu6G2L1vNDt3AmG/gGw9rIT2deeC?=
 =?us-ascii?Q?rhN0tQYI184oSMRUP3XVLCEuCaTGaMDv4hgKgGpt?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f89ad603-151b-47b8-5a9b-08db68cb90a5
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 09:26:11.9788
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /+/RbIN1WI06LeVN1zb9W+vPNeyQOlLsa9M2t3ylKOFnmNfAW/SZHbjKqILYEDaUBYltJa8JaDWYkk2/N2YWyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB3899
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It would be better to replace the traditional ternary conditional
operator with min() in zero_iter

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
---
 mm/vmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 29077d61ff81..6125ed506895
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count)
 	while (remains > 0) {
 		size_t num, copied;
 
-		num = remains < PAGE_SIZE ? remains : PAGE_SIZE;
+		num = min_t(size_t, remains, PAGE_SIZE);
 		copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter);
 		remains -= copied;
 
-- 
2.39.0