Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 11:24:58 +0200
From:   Willy Tarreau <w@1wt.eu>
To:     Zhangjin Wu <falcon@tinylab.org>
Cc:     sfr@canb.auug.org.au, linux-kernel@vger.kernel.org,
        linux-next@vger.kernel.org, paulmck@kernel.org
Subject: Re: linux-next: Signed-off-by missing for commit in the rcu tree
Message-ID: <ZILv6qiLIVJO8+MK@1wt.eu>
References: <20230609082858.5e1b4424@canb.auug.org.au>
 <20230609040804.164292-1-falcon@tinylab.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230609040804.164292-1-falcon@tinylab.org>
Precedence: bulk

On Fri, Jun 09, 2023 at 12:08:04PM +0800, Zhangjin Wu wrote:
> Hi, Stephen, Willy, Thomas, Paul
> 
> > Hi all,
> > 
> > Sorry, the subject should have been "linux-next: fixes tag needs work
> > in rcu tree".
> > 
> > On Fri, 9 Jun 2023 08:27:22 +1000 Stephen Rothwell <sfr@canb.auug.org.au> w=
> > rote:
> > >
> > > In commit
> > >=20
> > >   df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")
> > >=20
> > > Fixes tag
> > >=20
> > >   Fixes: 8e3ab529bef9 ("tools/nolibc/unistd: add syscall()")
> > >=20
> > > has these problem(s):
> > >=20
> > >   - Target SHA1 does not exist
> > >=20
> > > Maybe you meant
> > >=20
> > > Fixes: 6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")
> 
> Thanks, just checked the rcu/next branch of Paul, the commit is really the one
> you corrected:
> 
>     Fixes: 6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")
> 
> Willy, this happened may be because of the 'int' to 'long' fixup merged to the
> old "tools/nolibc/unistd: add syscall()" commit, I forgot the check of this
> change in my patch.

I was very careful about squashing the patches that mentioned commit IDs
that were not merged yet (since we don't want to merge incomplete patches),
but apparently missed this one :-/

> Btw, perhaps it is possible to merge this typo fixup (tools/nolibc: fix up typo
> _sycall_narg -> _syscall_narg) [1] to this commit too:
> 
>     6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")
> 
> And then update the new 'Fixes' tag in this patch:
> 
>     df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")
> 
> Or even merge both of them to the first one, and eventually, no Fixes lines
> required.
> 
> As a summary, the following two fixes:
> 
>     df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")
> 
>     not merged   ("tools/nolibc: fix up typo _sycall_narg -> _syscall_narg"), see [1]
> 
> are for this one:
> 
>     6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")
> 
> Merging both of them to the above one may be a choice ;-)

Agreed. I'll see off-line with Paul how to best proceed.

Thanks,
Willy